Issue metadata
Sign in to add a comment
|
Deprecate and remove pp::WebSocket |
||||||||||||||||||||
Issue descriptionThe Native Client Pepper WebSocket API should be removed. Plan: Display a deprecation message in the console from M70 onwards In M72 disable the API via Finch in the dev + canary channels In M73 also disable it in the beta channel In M74 also disable it in the stable channel Assuming no blockers are found, remove the code in M75.
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77d2955c7480d8d51f31c82d512c944385279891 commit 77d2955c7480d8d51f31c82d512c944385279891 Author: Adam Rice <ricea@chromium.org> Date: Tue Aug 07 10:36:42 2018 Add a deprecation message for PPAPI WebSocket Display a console message (in the context of the page) when a WebSocket is created via the Pepper pp::WebSocket API. Also add deprecation warnings to the documentation. Tested by manual verification that the console message is shown when the PPAPI WebSocket browser_tests are run. Intent to deprecate thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/3NYHaxhRs14/XOdUJBvHAwAJ BUG= 870586 Change-Id: Ib4631d11cd94cecad6c42e6b3fb1fb81ffc2b7fb Reviewed-on: https://chromium-review.googlesource.com/1161712 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581191} [modify] https://crrev.com/77d2955c7480d8d51f31c82d512c944385279891/ppapi/api/ppb_websocket.idl [modify] https://crrev.com/77d2955c7480d8d51f31c82d512c944385279891/ppapi/c/ppb_websocket.h [modify] https://crrev.com/77d2955c7480d8d51f31c82d512c944385279891/ppapi/cpp/websocket.h [modify] https://crrev.com/77d2955c7480d8d51f31c82d512c944385279891/ppapi/utility/websocket/websocket_api.h [modify] https://crrev.com/77d2955c7480d8d51f31c82d512c944385279891/third_party/blink/public/platform/web_feature.mojom [modify] https://crrev.com/77d2955c7480d8d51f31c82d512c944385279891/third_party/blink/renderer/core/frame/deprecation.cc [modify] https://crrev.com/77d2955c7480d8d51f31c82d512c944385279891/third_party/blink/renderer/modules/websockets/web_pepper_socket_impl.cc [modify] https://crrev.com/77d2955c7480d8d51f31c82d512c944385279891/tools/metrics/histograms/enums.xml
,
Aug 13
I will need to add a feature to disable pp::WebSocket in a couple of months' time.
,
Oct 1
The NextAction date has arrived: 2018-10-01
,
Dec 6
We have heard rumours of a user of pp::WebSocket and are considering deprecating the deprecation.
,
Jan 10
The deprecation is cancelled: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lWNvY56OAYs/9IoQx_ncDQAJ.
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfc22b6813741d7ca31a5c0debe2201bb553b483 commit dfc22b6813741d7ca31a5c0debe2201bb553b483 Author: Adam Rice <ricea@chromium.org> Date: Tue Jan 15 06:00:39 2019 Undeprecate PPAPI WebSocket Remove the deprecation console message and documentation comments for PPAPI WebSocket. This is mostly a straightforward revert of https://chromium-review.googlesource.com/c/chromium/src/+/1161712/ except that the enums have been left behind. See https://groups.google.com/a/chromium.org/d/msg/blink-dev/lWNvY56OAYs/9IoQx_ncDQAJ for the background and justification for undoing the deprecation. BUG= 870586 Change-Id: I436e016b98e5e6224fca420ed769420f016bf6ac Reviewed-on: https://chromium-review.googlesource.com/c/1402306 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#622756} [modify] https://crrev.com/dfc22b6813741d7ca31a5c0debe2201bb553b483/ppapi/api/ppb_websocket.idl [modify] https://crrev.com/dfc22b6813741d7ca31a5c0debe2201bb553b483/ppapi/c/ppb_websocket.h [modify] https://crrev.com/dfc22b6813741d7ca31a5c0debe2201bb553b483/ppapi/cpp/websocket.h [modify] https://crrev.com/dfc22b6813741d7ca31a5c0debe2201bb553b483/ppapi/utility/websocket/websocket_api.h [modify] https://crrev.com/dfc22b6813741d7ca31a5c0debe2201bb553b483/third_party/blink/renderer/core/frame/deprecation.cc [modify] https://crrev.com/dfc22b6813741d7ca31a5c0debe2201bb553b483/third_party/blink/renderer/modules/websockets/web_pepper_socket_impl.cc
,
Jan 15
There are currently no plans to proceed with the deprecation, so abandoning this issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ricea@chromium.org
, Aug 3