New issue
Advanced search Search tips

Issue 870531 link

Starred by 1 user
Status: Fixed
Owner:
chaopeng@chromium.org
Closed: Aug 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 836912



Sign in to add a comment

[blink-gen-property-trees] Page flashes on scroll

Project Member Reported by bokan@chromium.org, Aug 3 
Chrome Version       : 70.0.3510.0
OS Version: Android
URLs (if applicable) : https://bokand.github.io/bottomfixed.html

What steps will reproduce the problem?
(0) Start chrome with --enable-blink-gen-property-trees
(1) Visit any scrollable page (e.g. https://bokand.github.io/bottomfixed.html)

What is the expected result?
Page should scroll without graphical glitches

What happens instead of that?
Page disappears while scrolling. Reappears when finger leaves screen (sometimes).

Comment 1 by bokan@chromium.org, Aug 3

Blocking: 836912
Components: Blink>Scroll
Labels: -OS-Linux -Pri-3 OS-Android Pri-2
Owner: chaopeng@chromium.org
Status: Assigned (was: Unconfirmed)
Chao, I think this is basically the same issue as in  bug 846790  but for Android. When I comment out the lines:

  //for (ScrollbarLayerImplBase* scrollbar : Scrollbars()) {
  //  //if (!scrollbar->CanScrollOrientation())
  //  //  scrollbar->SetOverlayScrollbarLayerOpacityAnimated(0);
  //} 

In ScrollbarAnimationController::Animate this makes it work. I believe it's because we're not creating the correct property tree nodes for Android's visual viewport scrollbars. This is likely the same root cause as  bug 870520 . See pdr's TODO in VisualViewport::InitializeScrollbars

Comment 2 by chaopeng@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ba286764b0719fab0b58fc33805e60d7b77ddb3

commit 3ba286764b0719fab0b58fc33805e60d7b77ddb3
Author: chaopeng <chaopeng@chromium.org>
Date: Wed Aug 15 18:08:14 2018

[BlinkGenPropertyTrees] Add layer state for viewport scrollbars

This patch fixes viewport scrollbars flashing page issue. The issue
is causing by it has incorrect effect node. In this patch, we create
the effect and correct the position for viewport scrollbars.

Bug:  870520 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I954d6cddb36d811f693b597644b65ee175137dcf
Reviewed-on: https://chromium-review.googlesource.com/1172919
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583323}
[modify] https://crrev.com/3ba286764b0719fab0b58fc33805e60d7b77ddb3/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/3ba286764b0719fab0b58fc33805e60d7b77ddb3/third_party/blink/renderer/core/frame/visual_viewport.h
[modify] https://crrev.com/3ba286764b0719fab0b58fc33805e60d7b77ddb3/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/3ba286764b0719fab0b58fc33805e60d7b77ddb3/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc

Comment 3 by bokan@chromium.org, Aug 16

Status: Fixed (was: Assigned)
►

Sign in to add a comment