Issue metadata
Sign in to add a comment
|
[WPT Import] Unable to add timeout expectation for a new test |
||||||||||||||||||||||
Issue descriptionExample: https://chromium-review.googlesource.com/c/chromium/src/+/1161012 wpt/clear-site-data/executionContexts.sub.html is a new test that times out everywhere. Log says: 2018-08-02 11:37:54,213 - Tests to rebaseline: 2018-08-02 11:37:54,213 - external/wpt/clear-site-data/executionContexts.sub.html ... 2018-08-02 11:39:24,180 - No lines to write to TestExpectations. The test should have been added to TestExpectations. I'm pretty sure this used to work.
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ab3063985180e11e81e2a9216a349ebebacf4aa commit 9ab3063985180e11e81e2a9216a349ebebacf4aa Author: Robert Ma <robertma@chromium.org> Date: Fri Aug 03 00:52:43 2018 Add two expectations to unblock wpt-importer No-Try because tests haven't been imported. TBR=foolip No-Try: True Bug: 870526 , 870528 Change-Id: I72df4669a5f22d7676ac289eb0c208633b6b019c Reviewed-on: https://chromium-review.googlesource.com/1161559 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#580396} [modify] https://crrev.com/9ab3063985180e11e81e2a9216a349ebebacf4aa/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 7
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/356557dd2f1ad66267ca1df4d22ffe8754111609 commit 356557dd2f1ad66267ca1df4d22ffe8754111609 Author: Robert Ma <robertma@chromium.org> Date: Tue Aug 07 18:38:18 2018 [blinkpy] Fix expectations updater after JSON output tweaks Following https://crrev.com/c/1154107, the test results JSON no longer collapses multiple retries if they are all same, so some of the assumptions in the expectations updater no longer hold. This CL changes the updater to properly support multiple retries in the "actual" results. Besides, add a "--patchset" argument to the tool for easier debugging. Bug: 870528 Change-Id: Ia6045eac7781708046a7ab8f07eb40c23a9f5897 Reviewed-on: https://chromium-review.googlesource.com/1164027 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#581293} [modify] https://crrev.com/356557dd2f1ad66267ca1df4d22ffe8754111609/third_party/blink/tools/blinkpy/common/net/layout_test_results.py [modify] https://crrev.com/356557dd2f1ad66267ca1df4d22ffe8754111609/third_party/blink/tools/blinkpy/w3c/wpt_expectations_updater.py [modify] https://crrev.com/356557dd2f1ad66267ca1df4d22ffe8754111609/third_party/blink/tools/blinkpy/w3c/wpt_expectations_updater_unittest.py
,
Aug 7
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by robertma@chromium.org
, Aug 3