New issue
Advanced search Search tips

Issue 870526 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue gerrit:9640



Sign in to add a comment

wptserve raises exceptions in external/wpt/payment-handler/idlharness.https.any.serviceworker.html

Project Member Reported by robertma@chromium.org, Aug 3

Issue description

The current incoming import is blocked.

Example: https://chromium-review.googlesource.com/c/chromium/src/+/1161012/2/third_party/WebKit/LayoutTests/platform/linux/external/wpt/payment-handler/idlharness.https.any.serviceworker-expected.txt

Perhaps the test depends some new wptserve change that we haven't rolled in yet.
 
Cc: foolip@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ab3063985180e11e81e2a9216a349ebebacf4aa

commit 9ab3063985180e11e81e2a9216a349ebebacf4aa
Author: Robert Ma <robertma@chromium.org>
Date: Fri Aug 03 00:52:43 2018

Add two expectations to unblock wpt-importer

No-Try because tests haven't been imported.

TBR=foolip

No-Try: True
Bug:  870526 ,  870528 
Change-Id: I72df4669a5f22d7676ac289eb0c208633b6b019c
Reviewed-on: https://chromium-review.googlesource.com/1161559
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580396}
[modify] https://crrev.com/9ab3063985180e11e81e2a9216a349ebebacf4aa/third_party/WebKit/LayoutTests/TestExpectations

Status: ExternalDependency (was: Assigned)
Reproducible in upstream as well. Filed https://github.com/web-platform-tests/wpt/issues/12301
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24e5fbf1e9ca43c81405e257c1c13d74c0c233f7

commit 24e5fbf1e9ca43c81405e257c1c13d74c0c233f7
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Aug 08 19:17:41 2018

Skip all idlharness.https.any.serviceworker.html tests

This is currently blocking import. Upstream issue:
https://github.com/web-platform-tests/wpt/issues/12301

TBR=robertma@chromium.org

Bug:  870526 
Change-Id: I1f9026391e3ef44c399472121a32b88b3197e9e1
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1167847
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581655}
[modify] https://crrev.com/24e5fbf1e9ca43c81405e257c1c13d74c0c233f7/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef04d1e80e63e69c26893400e00a1c8b015d910

commit 2ef04d1e80e63e69c26893400e00a1c8b015d910
Author: Robert Ma <robertma@chromium.org>
Date: Sun Aug 12 16:36:33 2018

Skip yet another WPT that crashes wptserve

TBR=foolip

No-Try: True
Bug:  870526 
Change-Id: Id8d7d6c24425674d2a57abbf2b502781726bb0e3
Reviewed-on: https://chromium-review.googlesource.com/1172097
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582477}
[modify] https://crrev.com/2ef04d1e80e63e69c26893400e00a1c8b015d910/third_party/WebKit/LayoutTests/TestExpectations

Cc: smcgruer@chromium.org robertma@chromium.org
 Issue 873522  has been merged into this issue.
Fix has landed upstream. I'll try to roll it into Chromium and see if it fixes things.
Status: Started (was: ExternalDependency)
Blockedon: gerrit:9640
Status: ExternalDependency (was: Started)
Status: Fixed (was: ExternalDependency)
Fixed by  issue 876717 .

Sign in to add a comment