[blink-gen-property-trees] Android viewport scrollbars mispositioned and don't fade out |
||
Issue descriptionChrome Version: 70.0.3510.0 OS: Android What steps will reproduce the problem? (0) Start chrome with --enable-blink-gen-property-trees (1) Visit any scrollable page (e.g. https://bokand.github.io/bottomfixed.html) What is the expected result? Scollbars should appear at bottom and right of screen. Fade out after delay. What happens instead? Scrollbars are positioned at top and left edges of screen. Do not fade out. Almost certainly because of the TODO left in VisualViewport::InitializeScrollbars: // TODO(pdr): The viewport overlay scrollbars do not have the correct // paint properties. See: https://crbug.com/836910
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ba286764b0719fab0b58fc33805e60d7b77ddb3 commit 3ba286764b0719fab0b58fc33805e60d7b77ddb3 Author: chaopeng <chaopeng@chromium.org> Date: Wed Aug 15 18:08:14 2018 [BlinkGenPropertyTrees] Add layer state for viewport scrollbars This patch fixes viewport scrollbars flashing page issue. The issue is causing by it has incorrect effect node. In this patch, we create the effect and correct the position for viewport scrollbars. Bug: 870520 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I954d6cddb36d811f693b597644b65ee175137dcf Reviewed-on: https://chromium-review.googlesource.com/1172919 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583323} [modify] https://crrev.com/3ba286764b0719fab0b58fc33805e60d7b77ddb3/third_party/blink/renderer/core/frame/visual_viewport.cc [modify] https://crrev.com/3ba286764b0719fab0b58fc33805e60d7b77ddb3/third_party/blink/renderer/core/frame/visual_viewport.h [modify] https://crrev.com/3ba286764b0719fab0b58fc33805e60d7b77ddb3/third_party/blink/renderer/core/frame/visual_viewport_test.cc [modify] https://crrev.com/3ba286764b0719fab0b58fc33805e60d7b77ddb3/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
,
Aug 16
|
||
►
Sign in to add a comment |
||
Comment 1 by bokan@chromium.org
, Aug 3