Issue metadata
Sign in to add a comment
|
Work area not reset after hiding accessibility keyboard. |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3511.0 OS: ChromeOS Eve What steps will reproduce the problem? (1) Show accessibility keyboard (2) Hide accessibility keyboard What is the expected result? The work area is reset. What happens instead? The work area does not reset, leaving a large gap on the screen.
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f858e7a7908f59e291d8d16ad0874c632efa6ccf commit f858e7a7908f59e291d8d16ad0874c632efa6ccf Author: Darren Shen <shend@chromium.org> Date: Tue Aug 07 02:24:03 2018 [ash] Remove |change_work_area| from ShelfLayoutManager. |change_work_area| is used to determine whether to change the work area or not. It is currently set to true when the displaced keyboard bounds changes and false when the displaced bounds is the same. However, we can actually set it to true even when the displaced bounds is the same, because changing the work area to its current value should be a no-op anyway. If we make that change, then |change_work_area| is always true, so we can just remove it from the code. Bug: 870503 Change-Id: Ia4359211f35f43996efcbd0152b3f4bfa6517caa Reviewed-on: https://chromium-review.googlesource.com/1160828 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#581098} [modify] https://crrev.com/f858e7a7908f59e291d8d16ad0874c632efa6ccf/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/f858e7a7908f59e291d8d16ad0874c632efa6ccf/ash/shelf/shelf_layout_manager.h
,
Aug 7
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 3