Issue metadata
Sign in to add a comment
|
Decouple asan USE flags from fuzzer |
||||||||||||||||||||||||
Issue descriptionCurrently, use of fuzzer flag needs asan flag. We should deocuple it so that we could fuzzer flag with non-asan builds or different sanitizers/coverage builds etc.
,
Aug 3
In the docs still say fuzzer authors should add "IUSE="asan fuzzer"" to their fuzzers eclass file. Should we remove "asan" here and remove it from existing fuzzers?
,
Aug 3
Adding asan to IUSE only makes the asan flag visible to ebuild but does not enable it. The build system will have to enable it via explicitly adding to USE. So nothing changes from developer side. We'll probably be adding more flags to IUSE in future e.g. coverage, msan, ubsan etc.
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/042861eb27d179fe221fe46aa9fb814c81ea6b9c commit 042861eb27d179fe221fe46aa9fb814c81ea6b9c Author: Manoj Gupta <manojgupta@google.com> Date: Thu Aug 16 20:14:58 2018 common-mk: Split up fuzzing flags based on use flags. Do not pass "-fsanitize=address" unconditionally while fuzzing. Instead add the flags depending on the USE flags. This will let us test fuzzers with msan/ubsan etc. Also add new flags: USE_{asan/coverage/msan/ubsan} to common.gypi. BUG= chromium:870498 BUG=chromium:874179 TEST=fuzzers still build with USE="asan" Change-Id: Idb938693610e0f6055a4af79ade33398332b95bc Reviewed-on: https://chromium-review.googlesource.com/1176551 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/042861eb27d179fe221fe46aa9fb814c81ea6b9c/common-mk/common_fuzzer.gypi [modify] https://crrev.com/042861eb27d179fe221fe46aa9fb814c81ea6b9c/common-mk/common.gypi
,
Aug 22
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 3