New issue
Advanced search Search tips

Issue 870496 link

Starred by 5 users
Status: Fixed
Owner:
osh...@chromium.org
Closed: Aug 10
Cc:
afakhry@chromium.org
est...@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

App title bar does not appear when exiting full screen

Reported by willland...@gmail.com, Aug 2 
UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10718.63.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.76 Safari/537.36
Platform: 10718.63.0 (Official build) beta-channel swanky

Steps to reproduce the problem:
1. Open app other than Chrome
2. Enter full screen (f4)
3. Exit full screen (f4)

What is the expected behavior?
The title bar should appear above the application.

What went wrong?
The title bar does not appear.

Did this work before? N/A 

Chrome version: 68.0.3440.76  Channel: beta
OS Version: 10718.63.0
Flash Version: 30.0.0.134

Can be fixed by closing the application with ctrl+w and reopening the application as well as pressing alt+minus followed by alt+plus. This has not effected Chrome as of yet.

Comment 1 by willland...@gmail.com, Aug 2 

Feedback reports have been sent from a Swanky at Release 10718.63.0 beta (68.0.344.76) and a Candy at Release 10575.58.0 stable (67.0.3396.99).

The Swanky report is from willl...@gmail.com 
The Candy report is from 20wla...@somervilleschools.org

Comment 2 by weifangsun@chromium.org, Aug 3

Components: -UI UI>Shell>WindowManager

Comment 3 by afakhry@chromium.org, Aug 3

Cc: est...@chromium.org
Owner: osh...@chromium.org
Status: Assigned (was: Unconfirmed)
oshima-san please triage.

Comment 4 by osh...@chromium.org, Aug 7

Status: Started (was: Assigned)

Comment 5 by osh...@chromium.org, Aug 7

Cc: afakhry@chromium.org osh...@chromium.org
 Issue 867566  has been merged into this issue.

Comment 6 by osh...@chromium.org, Aug 10

Status: Fixed (was: Started)
Fixed in the following CL. (Sorry I put wrong CL there)


The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f53e977553b6e9b29171a4f50fb45322bdc88d

commit 19f53e977553b6e9b29171a4f50fb45322bdc88d
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Aug 10 07:09:13 2018

AppWindow should exit immersive mode when it exits the fullscreen mode

AppWindow has its own ImmersiveFullscreenController therefore it has to
do this by itself. (similar to CustomFrameViewAshWindowStateDelegate).

Bug:  869945 
Test: covered by unit tests.
Change-Id: Ibbbd71441138ff4f8cabaae6c98d30a1fc0c954d
Reviewed-on: https://chromium-review.googlesource.com/1166254
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582081}
[modify] https://crrev.com/19f53e977553b6e9b29171a4f50fb45322bdc88d/ash/frame/header_view.cc
[modify] https://crrev.com/19f53e977553b6e9b29171a4f50fb45322bdc88d/chrome/browser/ui/views/apps/DEPS
[modify] https://crrev.com/19f53e977553b6e9b29171a4f50fb45322bdc88d/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/19f53e977553b6e9b29171a4f50fb45322bdc88d/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h
[modify] https://crrev.com/19f53e977553b6e9b29171a4f50fb45322bdc88d/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc
►

Sign in to add a comment