Picture-in-Picture: set fallback surface id on window. |
||||||
Issue descriptionThis may be the cause of some flickering we saw on Windows and other black frames on all platforms.
,
Aug 3
Asking for a merge request as it's a very simple change that may resolve intermittent issues we've seen on low end devices.
,
Aug 4
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 4
How is the change listed at #1 looking in canary?
,
Aug 6
The change is expected to fix a bug we very rarely see. Canary build seems fine and I wasn't able to reproduce the bug but it's possible it had no effect too. Given that the change should have no undesirable side effects and at best fix a bug and only impacts a feature that is behind a Finch flag, I think it's safe to merge.
,
Aug 6
Approving merge to M69 branch 3497 based on comment #5. Please merge now. Thank you.
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56bf13c532a030143d839c9da3bfc3a6c94c59c3 commit 56bf13c532a030143d839c9da3bfc3a6c94c59c3 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Mon Aug 06 19:49:54 2018 Picture-in-Picture: use fallback surface id for video layer. Bug: 870493 Change-Id: I0ef3b6ea0c83cea18de59a7a8c135a8c445b6479 Reviewed-on: https://chromium-review.googlesource.com/1161460 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#580423}(cherry picked from commit 9924c89b63a13773747d186cf2fe7066b02eb747) Reviewed-on: https://chromium-review.googlesource.com/1164102 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#430} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/56bf13c532a030143d839c9da3bfc3a6c94c59c3/content/browser/picture_in_picture/overlay_surface_embedder.cc [modify] https://crrev.com/56bf13c532a030143d839c9da3bfc3a6c94c59c3/content/browser/picture_in_picture/overlay_surface_embedder.h [modify] https://crrev.com/56bf13c532a030143d839c9da3bfc3a6c94c59c3/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
,
Aug 6
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 3