Issue metadata
Sign in to add a comment
|
Error page fails to load on 500 response sniffed as download with the network service enabled. |
||||||||||||||||||||||
Issue descriptionErrorPageSniffTest.SniffSmallHttpErrorResponseAsDownload is failing when the network service because the error page isn't being loaded. If you enable pixel output in tests, you just see a blank page. If you run it in visual studio with the debugger attached, the test *passes*, and you do see the error page loaded as expected. If you just add a RunLoop().Run() at the end of the test, you see the page never loads when the test fails. So it looks to me like this is real race bug in production code, rather than a test bug. I'll continue digging, though I'm not an expert in navigation, and my preferred debugger "fixes" the problem. :(
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bd72d862ddfbd4bb4ceed3f9b06b52e0911f16e commit 2bd72d862ddfbd4bb4ceed3f9b06b52e0911f16e Author: Matt Menke <mmenke@chromium.org> Date: Fri Aug 03 15:17:18 2018 NetworkService: Fix case when HTTP error page is sniffed as a download. There were two bugs: When plugins weren't synchronously available, the download checking code was different from when they were. Also, when a download has an HTTP error status code, the navigation was being aborted instead of passing along the error to the renderer to display an error page. Bug: 870475 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie113fab576b4cc8ea2ca444c261335bf183c60e2 Reviewed-on: https://chromium-review.googlesource.com/1161479 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580552} [modify] https://crrev.com/2bd72d862ddfbd4bb4ceed3f9b06b52e0911f16e/chrome/browser/net/errorpage_browsertest.cc [modify] https://crrev.com/2bd72d862ddfbd4bb4ceed3f9b06b52e0911f16e/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/2bd72d862ddfbd4bb4ceed3f9b06b52e0911f16e/content/browser/loader/navigation_url_loader_impl.cc [modify] https://crrev.com/2bd72d862ddfbd4bb4ceed3f9b06b52e0911f16e/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Aug 3
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmenke@chromium.org
, Aug 2