New issue
Advanced search Search tips

Issue 870465 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: NativeWidgetMacTest.SchedulePaintInRect_Titled



Sign in to add a comment

NativeWidgetMacTest.SchedulePaintInRect_Titled is Flaky

Project Member Reported by Findit, Aug 2

Issue description

Owner: sugoi@chromium.org
Status: Assigned (was: Available)
sugoi@ Looks like there is another test that has started flaking since your CL. Could you disable it?
Looking at the bots, this flakiness only caused a single failure so far on build 4521. I'll try to find a proper fix tomorrow before disabling it, and the failure only happens in a subsection of the test, so I could disable only part of it if I can't find a proper fix. It looks like a synchronization issue at first glance.
Cc: tmartino@chromium.org
 Issue 870421  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85cdc133a47282d9c630fcd95bd1c1c6c5313382

commit 85cdc133a47282d9c630fcd95bd1c1c6c5313382
Author: Alexis Hetu <sugoi@google.com>
Date: Fri Aug 03 19:11:19 2018

NativeWidgetMacTest.SchedulePaintInRect_* fix

The gl renderer for all chromium tests was recently changed from OSMesa
to SwiftShader. OSMesa offers a synchronous API to OpenGL, while
SwiftShader is asynchronous (draw calls are received and yield before
the drawing operation is complete, letting chromium resume its execution).

Because of this it seems like the affected MacOS tests here can become
idle while rendering is happening in the background, causing the tests to
fail. To solve this, we need to actually wait for drawing to be completed,
rather than waiting for an idle period, in order to resume the test. Doing
this allows these tests to pass.

R=ccameron@chromium.org

Bug:  chromium:870465 
Change-Id: I6f1555b93a83d80b06e72b3a469c01dde44e1312
Reviewed-on: https://chromium-review.googlesource.com/1162350
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580619}
[modify] https://crrev.com/85cdc133a47282d9c630fcd95bd1c1c6c5313382/ui/views/widget/native_widget_mac_unittest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment