Issue metadata
Sign in to add a comment
|
A11y: about://chrome minor polish |
||||||||||||||||||||||
Issue descriptionChrome: 69.0.3497.23 (Official Build) dev (64-bit) (cohort: Dev) NVDA: 2018.2.1 JAWS: 2018 Steps to repro: # With JAWS or NVDA on, visit about://chrome # Navigate the page with down arrow # Notice that info is repeated twice, once for the label, and once for the button itself: Get help with Chrome Get help with Chrome Button Report an issue Report an issue Button Expected: Only one time announcement on the button. # the text 'Google Chrome' visually appears to be a heading, but is not indicated to screen reader users Expected: Wrap the text in an h1 tag. # Press insert+t # Notice there is no title apart from 'settings' Expected: A title to indicate the purpose of the page such as 'Settings - about Google Chrome'
,
Aug 23
Same is true on ChromeOS Steps to repro: # Turn Chromevox on with ctrl+alt+z # On the about page, use search+right arrow to navigate instead of down arrow # All steps are similar
,
Sep 14
,
Sep 14
,
Sep 18
,
Sep 25
,
Oct 4
Would adding aria-lebeledby on the <div>Report an issue</div> element suffice to prevent the screen reader from reading both the text and the label?
,
Oct 31
,
Oct 31
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcc8145a50852fde3bfca6d6c934fd3f585bc204 commit fcc8145a50852fde3bfca6d6c934fd3f585bc204 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Nov 01 03:29:31 2018 About WebUI: change about section heading into h1 page heading Bug: 870460 Change-Id: I0fa1762ca2f7054ab86116ce406b9acf9b8b37a7 Reviewed-on: https://chromium-review.googlesource.com/c/1311803 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#604508} [modify] https://crrev.com/fcc8145a50852fde3bfca6d6c934fd3f585bc204/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/fcc8145a50852fde3bfca6d6c934fd3f585bc204/chrome/browser/resources/settings/settings_page/settings_section.html
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f124066b1df9cb9345cc68c782938297ccb3c7d commit 6f124066b1df9cb9345cc68c782938297ccb3c7d Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Nov 01 22:38:50 2018 Settings WebUI: add aria-expanded to advanced settings toggle button Bug: 870460 Change-Id: I5a579b584f9fb13a0c1010109b3990ddd4306a0b Reviewed-on: https://chromium-review.googlesource.com/c/1308601 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#604732} [modify] https://crrev.com/6f124066b1df9cb9345cc68c782938297ccb3c7d/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/6f124066b1df9cb9345cc68c782938297ccb3c7d/chrome/browser/resources/settings/basic_page/basic_page.js
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf1d41bb7577080b780be0bd144d169d357a919b commit bf1d41bb7577080b780be0bd144d169d357a919b Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Nov 01 22:48:37 2018 About WebUI: a11y, use cr-link-row so row is treated as one button Bug: 870460 Change-Id: I24fa99baa9e390df94be3e6f01bf2a3127bfc37c Reviewed-on: https://chromium-review.googlesource.com/c/1311773 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#604734} [modify] https://crrev.com/bf1d41bb7577080b780be0bd144d169d357a919b/chrome/browser/resources/settings/about_page/about_page.html
,
Nov 1
CL from comment #12 was meant for crbug.com/870736 .
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4214a73b930475446576c9d1f6440266ed861c3d commit 4214a73b930475446576c9d1f6440266ed861c3d Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Nov 02 01:17:55 2018 About WebUI: when showing about page, indicate that in page title Bug: 870460 Change-Id: I1c8e20231d88fb7cb87b1bb2a31b6edcb031f6aa Reviewed-on: https://chromium-review.googlesource.com/c/1313751 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#604796} [modify] https://crrev.com/4214a73b930475446576c9d1f6440266ed861c3d/chrome/app/settings_strings.grdp [modify] https://crrev.com/4214a73b930475446576c9d1f6440266ed861c3d/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/4214a73b930475446576c9d1f6440266ed861c3d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Nov 2
,
Nov 7
Chrome: 72.0.3604.0 (Official Build) canary (64-bit) (cohort: Clang-64) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by leberly@chromium.org
, Aug 10