New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870451 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Payments: add gpay logo to card unmask dialog

Project Member Reported by ma...@chromium.org, Aug 2

Issue description

Should be identical to the card save dialog.
 
Adding screenshots for crrev.com/c/1170131.

CVC Prompt - can't validate CVC.PNG
31.7 KB View Download
CVC Prompt - invalid CVC.PNG
35.9 KB View Download
CVC Prompt - update expiration date and CVC.PNG
36.1 KB View Download
CVC Prompt.PNG
34.6 KB View Download
Save upstream card.PNG
11.4 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0fdc66eefb8230cc1691f8e4287857b706e1a6f

commit e0fdc66eefb8230cc1691f8e4287857b706e1a6f
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Fri Aug 10 14:43:36 2018

[Card unmask dialog] Add Google Pay logo with separator to the title

This reuses the idea applied to the Save Card bubble to override the
title view with a custom view containing the Google Pay logo, the
separator, and the label. To make it more reusable, this CL introduces
a new views::View subclass to represent that title container.

In the new dialog, it's common to get multiline titles, which was not
properly handled by the custom implementation we had before. This CL
fixes the issue by using a GridLayout.

We also needed to replace DialogDelegateView with
BubbleDialogDelegateView as a base class of CardUnmaskPromptViews,
because the former doesn't expose the BubbleFrameView, needed to
override the title view.

Screenshots in the bug (see comment #1).

Bug:  870451 
Change-Id: I3cf33ff0fff4c34657d1febd1fd2eaf422ed4ccc
Reviewed-on: https://chromium-review.googlesource.com/1170131
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582157}
[modify] https://crrev.com/e0fdc66eefb8230cc1691f8e4287857b706e1a6f/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[modify] https://crrev.com/e0fdc66eefb8230cc1691f8e4287857b706e1a6f/chrome/browser/ui/views/autofill/card_unmask_prompt_views.h
[modify] https://crrev.com/e0fdc66eefb8230cc1691f8e4287857b706e1a6f/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/e0fdc66eefb8230cc1691f8e4287857b706e1a6f/chrome/browser/ui/views/autofill/view_util.cc
[modify] https://crrev.com/e0fdc66eefb8230cc1691f8e4287857b706e1a6f/chrome/browser/ui/views/autofill/view_util.h

Status: Fixed (was: Assigned)
Cc: krajshree@chromium.org
Labels: Needs-Feedback
Able to reproduce the issue on Windows 10 on chrome build without fix.

Tested the issue on Win-10 using latest chrome version #70.0.3521.0, as per comment #0 and #1.
Did not observe gpay logo to card unmask dialog. Attaching screen cast for reference.

ftirelo@ - Could you please check the attached screen cast and help us in verifying the fix.

Thanks...!!
870451.mp4
466 KB View Download
swarnasree.mukkala@: thanks for testing this.

The dialog shown is asking you to save the card to the local machine. The dialog corresponding to this bug is shown when you select a Google Pay card from the autofill dropdown and the card is not saved locally.

In order to test this, you need to:
 - Be signed in;
 - Go to chrome://settings/syncSetup and make sure option "Payment methods and addresses using Google Pay" is selected;
 - Have at least one credit card saved in Google Pay;
 - Click on the field and select the credit card suggestion corresponding to the card saved in Google Pay.

Please let me know if you need additional information or access to a test account.
Labels: TE-NeedsTriageFromHYD
ftirelo@ Thanks for the update.

Adding 'TE-NeedsTriageFromHYD' label as this issue needs Corp account to verify the issue as per comment #5.
Routing to Inhouse team to check and help in verifying the fix on the latest M-70 build.

Thanks..
Cc: jmukthavaram@chromium.org
Tested this issue as per C#1 & C#5 on Windows 10 & Mac 10.13.6 using chrome#70.0.3522.0  with corp sign in.

Observations:
--------------
1. Gpay -save upstream card is seen once we submit the form.
2. No CVC related popup is seen when we click on any of the fields in the below form.
      https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html
3. No Expiration date popup  is seen when we click on any of the fields in the below form.
      https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html

Please find the attached screencast for reference & provide us clear steps to view above CVC popup(C#1).
Thanks in advance!

870451-M70.mp4
1.5 MB View Download
Labels: -TE-NeedsTriageFromHYD
The issue is that the card is copied to Chrome - see at 0:18 that beside the card number, there is a text "Google Pay (copied to Chrome)". In order for the CVC prompt to show up, the card must be only in Google Pay. 

You can fix that by clicking on the three dots beside the expiration date in chrome://settings/payment and choosing "Clear copy". Once you do that, you will see only "Google Pay" beside it.

Can you please retry with these additional instructions?

Sign in to add a comment