Issue metadata
Sign in to add a comment
|
Popup blocker does not block popuptest.com/popuptest1.html |
||||||||||||||||||||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win10, MacOS 10.12, etc...) What steps will reproduce the problem? (1) In canary, open http://www.popuptest.com/popuptest1.html (2) the popup is not blocked... (3) the vertical bar in the omnibox is gone. (it has the vertical bar in Stable) What is the expected result? The popup is blocked & vertical bar is there. *we use the same text animation pattern (with the vertical bar) for Autofill feedback project. (go/autofill-feedback) Wanted to get this pattern be fixed ASAP. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 6
,
Aug 6
,
Aug 6
Able to reproduce the issue on reported chrome version 70.0.3510.0 and on latest chrome# 70.0.3513.0using Mac 10.12.6 hence providing Bisect Info Note: Issue is specific to Mac OS Bisect Info: ================ Good build: 70.0.3503.0 Bad build: 70.0.3504.0 CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/bcb7db78edc13f57577f0a9562c98918bdcc10ae..67d21d10815fe6d87d1785a65a50fbc386e6605b Change-Id: Ife1da1c63b1c2cd2b373c2aa6e349e82e1c6ee7b Reviewed-on: https://chromium-review.googlesource.com/977949 @Elly Fong-Jones: Please confirm the issue and help in re-assigning if it is not related to your change. Adding ReleaseBlock-Stable as it is seems a recent break, feel free to remove it if not applicable. Thanks!
,
Aug 6
I tested this on 10.13.6 with 70.0.3514.0: 1) The popup is blocked 2) The lack of a bar is by design in the new GM2 omnibox, as far as I'm aware - we don't use a bar on the security indicator and such either. Attached is what I see. Assigning this back to rfeng@: a) Can you repro the popup not being blocked? If so, I think that is a bug in the popup blocker and not in the UI. b) Can you consult with design about the vertical bar? I think bettes@ is a good point of contact. Pri-0 -> Pri-2: Pri-0 is for true emergencies (high-frequency stable crashers, major infrastructure fires, etc) and is not appropriate for a missing UI decoration. -RBS: Same.
,
Aug 9
,
Aug 9
I tested again with Alan Bettes, 1) the pop-up does not blocked in Canary 2) Alan is fine with the design without the vertical bar.
,
Aug 13
It sounds like only issue is the pop-up blocker. (The lack of vertical bar is fine.) Adjusting components appropriately. mustaq@, can you help triage? I'm not sure anyone triages that component these days.
,
Aug 14
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by markchang@chromium.org
, Aug 3Owner: robliao@chromium.org
Status: Unconfirmed (was: Accepted)