Add internal audio focus state to chrome://media-internals to make it easier to debug on Chrome OS.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d commit 65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Aug 17 20:38:05 2018 [Audio Focus] Add AudioFocusObserver content API This adds an AudioFocusObserver content API that can be used to listen to audio focus events on platforms where AudioFocusManager is being used. This also refactors AudioFocusType out of AudioFocusManager as we need it for the observer. BUG= 870418 Change-Id: I34dcd664f1bfd5c5d63c0cb8d3a7528534bd2c65 Reviewed-on: https://chromium-review.googlesource.com/1161095 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#584180} [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/BUILD.gn [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_delegate.h [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_delegate_android.cc [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_delegate_android.h [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_delegate_default.cc [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_manager.cc [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_manager.h [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_manager_unittest.cc [add] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_observer.cc [add] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_observer.h [add] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/audio_focus_type.h [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/media_session_android.cc [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/65a2df8f4214d4dc1d8b08e0ef8920bf2e5b170d/content/browser/media/session/media_session_impl_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d344439421cd4f26139a496093c9520467d735df commit d344439421cd4f26139a496093c9520467d735df Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Aug 17 22:15:08 2018 [Audio Focus] Add sessions to media internals Add a list of media sessions and their state to a new audio focus tab on media internals. BUG= 870418 Change-Id: I654b9444c1abc3f5ae12c29d070627e137f5e137 Reviewed-on: https://chromium-review.googlesource.com/1161500 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#584216} [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/media/media_internals.cc [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/media/media_internals.h [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/media/media_internals_proxy.cc [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/media/session/audio_focus_manager.h [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/resources/media/client_renderer.js [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/resources/media/main.js [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/resources/media/manager.js [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/resources/media/media_internals.css [modify] https://crrev.com/d344439421cd4f26139a496093c9520467d735df/content/browser/resources/media/media_internals.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4064e96f0a3e6df677d8e35b5958f693e34b7a4 commit b4064e96f0a3e6df677d8e35b5958f693e34b7a4 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Aug 20 18:02:59 2018 [Audio Focus] Move AudioFocusType enum to service As part of s18n we should move AudioFocusType to the Media Session service and make it a mojo enum. BUG= 870418 Change-Id: I838419b3759c5eae14a44ad639035ecac81dd04e Reviewed-on: https://chromium-review.googlesource.com/1180178 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584497} [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/BUILD.gn [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/media_internals.cc [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/media_internals.h [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/audio_focus_delegate.h [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/audio_focus_delegate_android.cc [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/audio_focus_delegate_android.h [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/audio_focus_delegate_default.cc [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/audio_focus_manager.cc [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/audio_focus_manager.h [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/audio_focus_manager_unittest.cc [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/audio_focus_observer.h [delete] https://crrev.com/bbe6c164a31b19defc6f01f8e14387cd8f7623d4/content/browser/media/session/audio_focus_type.h [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/media_session_android.cc [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/content/test/BUILD.gn [add] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/services/media_session/public/mojom/BUILD.gn [add] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/services/media_session/public/mojom/OWNERS [add] https://crrev.com/b4064e96f0a3e6df677d8e35b5958f693e34b7a4/services/media_session/public/mojom/audio_focus.mojom
Comment 1 by beccahughes@chromium.org
, Aug 623.8 KB
23.8 KB View Download