These are some current failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_tsan_rel_ng/72159

Great. Thanks. I'm reviewing them.

This is testing stale HarfBuzz.  Dominik, any chance you can roll HarfBuzz to 1.8.5?  The warnings should disappear.

https://chromium-review.googlesource.com/c/chromium/src/+/1162229

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48bbb3624c928312c964c93400e9924b4632d3e2

commit 48bbb3624c928312c964c93400e9924b4632d3e2
Author: Dominik Röttsches <drott@chromium.org>
Date: Mon Aug 13 08:55:50 2018

Add instructions to HarfBuzz Readme on determining non-compiled files

Bug:  870379 
Tbr: eae, behdad
Change-Id: I89c78c4b5253706b5c8075576a53dd3791fcd4cf
Reviewed-on: https://chromium-review.googlesource.com/1162229
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582532}
[modify] https://crrev.com/48bbb3624c928312c964c93400e9924b4632d3e2/third_party/harfbuzz-ng/README.chromium

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf7367f36efb7cf34a107fa743ff0a4dae2b8aef

commit cf7367f36efb7cf34a107fa743ff0a4dae2b8aef
Author: Fernando Serboncini <fserb@chromium.org>
Date: Mon Aug 13 20:48:20 2018

Re-enable tsan on HarfBuzz

TBR=behdad

Bug:  870379 
Change-Id: I369278f36a6896c07fc5d945a76e4d41d30da87a
Reviewed-on: https://chromium-review.googlesource.com/1160600
Reviewed-by: Behdad Esfahbod <behdad@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582696}
[modify] https://crrev.com/cf7367f36efb7cf34a107fa743ff0a4dae2b8aef/build/sanitizers/tsan_suppressions.cc

"How many folks does it take to make tsan happy with HarfBuzz?" Three!

Not a joke. Good job everyone.

Nice!  Thanks for instigating.  I learned a lot more about atomic operations and fixed a few bugs in the process as well.

Yay!

We now have a tsan bot inside the project

https://github.com/harfbuzz/harfbuzz/blob/master/test/api/test-multithread.c

Have a look and see if anything can be improved or covered also.