New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870376 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - 99.99% passing upper flake threshold may be ignored

Project Member Reported by lijeffrey@chromium.org, Aug 2

Issue description

This seems unexpected. Is the config in ndb not respected by the code? 
The root cause is the config values are being
read "incorrectly," with upper/lower_flake_threshold being under "swarming_rerun"
within flake settings. The code that reads these values reads them at the root
level (as it should), causing the values not to be found and thus using fallback
values defined in flake_constants.py which still use the old 0.02, 0.98 figure.

The full fix will be to clean up the config definition so the code can read it
from the correct place.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e3deba1486febffd947515d92816a2970b66df37

commit e3deba1486febffd947515d92816a2970b66df37
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Aug 06 21:33:49 2018

[Findit] Flake Analyzer - Fixing check for stability to use proper thresholds

This is part 1 of a 2-part fix. The root cause is the config values are being
read "incorrectly," with upper/lower_flake_threshold being under "swarming_rerun"
within flake settings. The code that reads these values reads them at the root
level (as it should), causing the values not to be found and thus using fallback
values defined in flake_constants.py which still use the old 0.02, 0.98 figure.

In Part 1 here, the fix is to use pass_rate_util.IsStableDefaultThresholds which
will always read from config and to update the fallback values to 1e-7 and
0.9999999.

Part 2 will be to clean up config so it is in the expected format, captured in
 issue 799832 .

Bug:  870376 
Change-Id: Ie7ddd85d558b22c94b2991e8808bc7936115d28c
Reviewed-on: https://chromium-review.googlesource.com/1162665
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/e3deba1486febffd947515d92816a2970b66df37/appengine/findit/services/flake_failure/test/pass_rate_util_test.py
[modify] https://crrev.com/e3deba1486febffd947515d92816a2970b66df37/appengine/findit/services/flake_failure/pass_rate_util.py
[modify] https://crrev.com/e3deba1486febffd947515d92816a2970b66df37/appengine/findit/services/flake_failure/flake_constants.py

Status: Verified (was: Assigned)

Sign in to add a comment