Issue metadata
Sign in to add a comment
|
All/PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation[_SignupForm]/0 are Flaky |
||||||||||||||||||||||
Issue descriptionFindit has detected flake occurrences for the test All/PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation/0 Culprit (70.1% confidence): https://chromium-review.googlesource.com/q/I8e0a113f356ea997ee9dff45e3cd0d465f349006 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy6wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK0AWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzExNDQwL21hc2hfYnJvd3Nlcl90ZXN0cy9RV3hzTDFCaGMzTjNiM0prVFdGdVlXZGxja0p5YjNkelpYSlVaWE4wVjJsMGFGWnBaWGR6Um1WaGRIVnlaUzVRY205dGNIUkdiM0pHWlhSamFGTjFZbTFwZEZkcGRHaHZkWFJPWVhacFoyRjBhVzl1THpBPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20All/PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation/0&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy6wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK0AWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzExNDQwL21hc2hfYnJvd3Nlcl90ZXN0cy9RV3hzTDFCaGMzTjNiM0prVFdGdVlXZGxja0p5YjNkelpYSlVaWE4wVjJsMGFGWnBaWGR6Um1WaGRIVnlaUzVRY205dGNIUkdiM0pHWlhSamFGTjFZbTFwZEZkcGRHaHZkWFJPWVhacFoyRjBhVzl1THpBPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
,
Aug 2
Assigning to sugoi@ who is actively investigating per the comments on the CL.
,
Aug 2
,
Aug 2
CCing ftirelo@ who will help investigate this.
,
Aug 2
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5da0d0d16f47b5f85fc74e95e377bb3597d7264e commit 5da0d0d16f47b5f85fc74e95e377bb3597d7264e Author: Alexis Hetu <sugoi@google.com> Date: Thu Aug 02 21:19:11 2018 Disabling flaky tests on ChromeOS As a result of replacing OSMesa with SwiftShader for running browser_tests recently, 4 tests have become flaky on ChromeOS: SiteDetailsBrowserTest.IsolateExtensions ArcVoiceInteractionArcHomeServiceTest.VoiceInteractionStructureMultipleSelectionTest ExtensionApiNewTabTest.Tabs PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation This cl temporarily disables these 4 tests on ChromeOs until we can find a proper fix for them. TBR=vasilii@chromium.org rdevlin.cronin@chromium.org hidehiko@chromium.org TBR_REASON="Making the linux-chromeos-rel bot less flaky" Bug: chromium:870372 chromium:870322 chromium:870319 chromium:671891 Change-Id: I55fdd44622f7fac13dafaa19699904178e37d1fb Reviewed-on: https://chromium-review.googlesource.com/1161202 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580324} [modify] https://crrev.com/5da0d0d16f47b5f85fc74e95e377bb3597d7264e/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service_browsertest.cc [modify] https://crrev.com/5da0d0d16f47b5f85fc74e95e377bb3597d7264e/chrome/browser/extensions/extension_tabs_apitest.cc [modify] https://crrev.com/5da0d0d16f47b5f85fc74e95e377bb3597d7264e/chrome/browser/password_manager/password_manager_browsertest.cc [modify] https://crrev.com/5da0d0d16f47b5f85fc74e95e377bb3597d7264e/chrome/browser/site_details_browsertest.cc
,
Aug 3
[ RUN ] All/PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation/0 [32098:32098:0802/091823.092681:WARNING:chrome_browser_main_chromeos.cc(586)] Running as stub user with profile dir: test-user [ash:32128:32128:0802/091823.169986:ERROR:shell_delegate_mash.cc(56)] Not implemented reached in virtual void ash::ShellDelegateMash::PreInit() [ash:32128:32128:0802/091823.186659:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [ash:32128:32128:0802/091823.186686:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [ash:32128:32128:0802/091823.186691:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [ash:32128:32128:0802/091823.186713:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [ash:32128:32128:0802/091823.186717:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [ash:32128:32128:0802/091823.186722:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [ash:32128:32128:0802/091823.186737:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [ash:32128:32128:0802/091823.186741:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [ash:32128:32128:0802/091823.186745:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [ash:32128:32128:0802/091823.192818:ERROR:layer_tree_host_impl.cc(2997)] Forcing zero-copy tile initialization as worker context is missing [32098:32098:0802/091823.219349:INFO:remote_commands_service.cc(38)] Fetching remote commands. [32098:32098:0802/091823.219466:WARNING:remote_commands_service.cc(40)] Client is not registered. [32098:32098:0802/091823.219502:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator. [32098:32098:0802/091823.219525:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator. [32098:32098:0802/091823.219583:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData. [32098:32098:0802/091823.219617:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. [ash:32128:32128:0802/091823.266685:ERROR:shell_delegate_mash.cc(51)] Not implemented reached in virtual bool ash::ShellDelegateMash::CanShowWindowForUser(aura::Window *) const [ash:32128:32128:0802/091823.267413:ERROR:server_window.cc(458)] Not implemented reached in void ui::ws2::ServerWindow::SetClientArea(const gfx::Insets &, const std::vector<gfx::Rect> &) [ash:32128:32128:0802/091823.267446:ERROR:window_tree.cc(1346)] Not implemented reached in virtual void ui::ws2::WindowTree::SetHitTestMask(ui::Id, const base::Optional<gfx::Rect> &) [32098:32098:0802/091823.273540:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273559:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273564:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273588:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273593:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273597:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273601:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273605:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273609:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273631:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273636:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.273640:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [32098:32098:0802/091823.329613:ERROR:layer_tree_host_impl.cc(2997)] Forcing zero-copy tile initialization as worker context is missing [32098:32098:0802/091823.330769:ERROR:remote_text_input_client.cc(139)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged() [32098:32098:0802/091823.330793:ERROR:remote_text_input_client.cc(96)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const [32098:32098:0802/091823.330798:ERROR:remote_text_input_client.cc(181)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning() [32098:32098:0802/091823.330813:ERROR:remote_text_input_client.cc(90)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const [32098:32098:0802/091823.330818:ERROR:remote_text_input_client.cc(102)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const [32098:32098:0802/091823.330824:ERROR:remote_text_input_client.cc(157)] Not implemented reached in virtual void RemoteTextInputClient::EnsureCaretNotInRect(const gfx::Rect &) [32098:32098:0802/091823.354966:ERROR:layer_tree_host_impl.cc(2997)] Forcing zero-copy tile initialization as worker context is missing [32098:32098:0802/091823.368876:ERROR:render_widget_host_view_aura.cc(1231)] Not implemented reached in virtual base::i18n::TextDirection content::RenderWidgetHostViewAura::GetTextDirection() const [32098:32098:0802/091823.411408:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: http://127.0.0.1:42005/password/password_fetch_submit.html (0) [32098:32098:0802/091823.411451:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "username"): (More info: https://goo.gl/9p2vKq) %o", source: http://127.0.0.1:42005/password/password_fetch_submit.html (0) [32098:32175:0802/091823.419290:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico [1:8:0802/091823.436348:ERROR:layer_tree_host_impl.cc(2997)] Forcing zero-copy tile initialization as worker context is missing ../../chrome/browser/password_manager/password_manager_browsertest.cc:837: Failure Value of: prompt_observer->IsSavePromptShownAutomatically() Actual: false Expected: true Stack trace: #0 0x000001fe6b8c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x000001fe6569 testing::internal::AssertHelper::operator=() #2 0x000000a3258c password_manager::PasswordManagerBrowserTestWithViewsFeature_PromptForFetchSubmitWithoutNavigation_Test::RunTestOnMainThread() #3 0x00000413b08b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x000003d4a3fa ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x000003d49341 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x000001c00e45 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #7 0x00000295a051 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x000002cbf8e7 content::StartupTaskRunner::RunAllTasksNow() #9 0x000002958a3d content::BrowserMainLoop::CreateStartupTasks() #10 0x00000295c4c3 content::BrowserMainRunnerImpl::Initialize() #11 0x000002956a44 content::BrowserMain() #12 0x000003b8d41c content::ContentMainRunnerImpl::Run() #13 0x0000057ada30 service_manager::Main() #14 0x000003b8b884 content::ContentMain() #15 0x00000413acc2 content::BrowserTestBase::SetUp() #16 0x000003cf9b4e InProcessBrowserTest::SetUp() [32098:32098:0802/091823.584060:ERROR:layer_tree_host_impl.cc(2997)] Forcing zero-copy tile initialization as worker context is missing [32098:32098:0802/091823.595118:ERROR:test_password_store.cc(198)] Not implemented reached in virtual void password_manager::TestPasswordStore::AddSiteStatsImpl(const password_manager::InteractionsStats &) [32098:32098:0802/091823.654149:INFO:remote_commands_invalidator.cc(45)] Shutdown RemoteCommandsInvalidator. [32098:32098:0802/091823.654227:INFO:remote_commands_invalidator.cc(68)] Stopping RemoteCommandsInvalidator. [32098:32098:0802/091823.654244:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. [32098:32098:0802/091823.670645:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [32098:32098:0802/091823.672130:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [ FAILED ] All/PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation/0, where GetParam() = false (646 ms)
,
Aug 10
Issue 873299 has been merged into this issue.
,
Aug 10
,
Aug 10
Note that a bunch of tests seem to be flaking togther: All/PasswordManagerBrowserTestWithViewsFeature.PromptForPushStateWhenFormDisappears/1 All/PasswordManagerBrowserTestWithViewsFeature.ChangePwdFormPushStateBubbleShown/1 CrControlledButtonTest.All CrSettingsSiteListTest.EditExceptionDialog BrowsingDataRemoverBrowserTest.HistoryDeletion CrExtensionsNavigationHelperTest.SupportedRoutes CrSettingsCategoryDefaultSettingTest.All MaterialHistoryRoutingTest.All All/PasswordManagerBrowserTestWithViewsFeature.PromptForPushStateWhenFormDisappears_ParametersInOrigins/1 WebUIImplBrowserTest.SameDocumentNavigationsAndReload SecurityStateTabHelperTest.ConsoleMessageNotPrintedForPushStateNavigation/1 Not sure if they're all related, but suspect some of them are.
,
Aug 10
Oops, sample failures - https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/59883
,
Aug 11
@10: CrSettings/CrExtensions and other mocha bugs are tracked in bug 871692 . I would love to find a common cause to all this stuff... |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by Findit
, Aug 2