New issue
Advanced search Search tips

Issue 870366 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 860526



Sign in to add a comment

[Autofill] Fix all references to chrome://settings/autofill in the feature

Project Member Reported by ma...@chromium.org, Aug 2

Issue description

We now have chrome://settings/autofill and chrome://settings/payments. We should fix the references that now all point to settings/autofill whereas some of them should point to the /payments page.
 
Blocking: 860526
Cc: ma...@chromium.org
Owner: mahmadi@chromium.org
Cc: nyerramilli@chromium.org rbasuvula@chromium.org
 Issue 870660  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/510548ebbfe0ae3841866ed1cd0160182ebce5a9

commit 510548ebbfe0ae3841866ed1cd0160182ebce5a9
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Aug 07 04:07:31 2018

[Autofill] Update all references to settings from the feature.

A previous change split the Autofill settings into addresses
and payments pages. This goes through the feature code and updates
the relevant call sites to lead either to the addresses page or the
payments page.

Bug:  870366 
Test: manual
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2cad30bc762a20d499ec203c8628e63c057e84d2
Reviewed-on: https://chromium-review.googlesource.com/1162502
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581128}
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/510548ebbfe0ae3841866ed1cd0160182ebce5a9/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm

Status: Fixed (was: Assigned)
Moe, do you know if there's 

Sign in to add a comment