The images displayed as favicons next to the suggestions in the accessory sheet appear blurry due to upscaling. Larger icons should probably be used where available.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ce367473d16d509bb8de611cf035611aa873a86 commit 9ce367473d16d509bb8de611cf035611aa873a86 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Thu Oct 11 09:51:00 2018 [Android] Use correctly-scaled icons for keyboard accessory With this CL, the keyboard accessory controller fetches icons using GetRawFaviconForPageURL with the desired size in pixels which results in sharp favicons that scale with Android UI elements. Before this CL, |GetFaviconImageForPageUrl| was used which assumes the default size (16dp, as opposed to 20dp) for icons and doesn't provide scale representation which are suitable for hdpi scales of mobile icons. (The provided scale was 1x to 2x, but modern phones use scales >= 3.5x) Bug: 870346 , 856180 Change-Id: I4371c43ccdf6e7c7b39be805d82a17c8bdb6c661 Reviewed-on: https://chromium-review.googlesource.com/c/1273497 Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#598710} [modify] https://crrev.com/9ce367473d16d509bb8de611cf035611aa873a86/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java [modify] https://crrev.com/9ce367473d16d509bb8de611cf035611aa873a86/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java [modify] https://crrev.com/9ce367473d16d509bb8de611cf035611aa873a86/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java [modify] https://crrev.com/9ce367473d16d509bb8de611cf035611aa873a86/chrome/browser/android/password_manager/password_accessory_view_android.cc [modify] https://crrev.com/9ce367473d16d509bb8de611cf035611aa873a86/chrome/browser/android/password_manager/password_accessory_view_android.h [modify] https://crrev.com/9ce367473d16d509bb8de611cf035611aa873a86/chrome/browser/password_manager/password_accessory_controller.cc [modify] https://crrev.com/9ce367473d16d509bb8de611cf035611aa873a86/chrome/browser/password_manager/password_accessory_controller.h [modify] https://crrev.com/9ce367473d16d509bb8de611cf035611aa873a86/chrome/browser/password_manager/password_accessory_controller_unittest.cc
Comment 1 by fhorschig@chromium.org
, Oct 10