New issue
Advanced search Search tips

Issue 870342 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 889588



Sign in to add a comment

[Autofill Views] Experiment with layouts

Project Member Reported by tmartino@chromium.org, Aug 2

Issue description

This is the eng bug tracking the effort to experiment with alternate layouts in the new desktop dropdown.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da

commit 3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da
Author: Tommy Martino <tmartino@chromium.org>
Date: Mon Aug 20 21:45:44 2018

[Autofill Views] Adding Layout Experiment

This CL adds the flag, feature, and parameters for an upcoming
experiment which will modify the layout of the Autofill dropdown on
Desktop. It also adds the capability to display the icon on the left,
rather than the default right, of each row of the dropdown, which is
the expected behavior under certain experiment groups.

Change-Id: I90ceb546887a76eb836e4aac19ae96ba1a9d107e
Bug:  870342 
Reviewed-on: https://chromium-review.googlesource.com/1152217
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584572}
[modify] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/chrome/browser/about_flags.cc
[modify] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/tools/metrics/histograms/enums.xml

Cc: ftirelo@chromium.org tienmai@chromium.org mahmadi@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd543e3d81c3d54a016181c52af048cbcac5b56b

commit bd543e3d81c3d54a016181c52af048cbcac5b56b
Author: Tien Mai <tienmai@chromium.org>
Date: Mon Sep 24 16:50:44 2018

[Autofill Views] Adding 2-line dropdown display experiment

Adds the new two line suggestion display experiment argument for
credit card and profile autofill drop downs. This new experiment
argument will allow autofill drop downs to show two lines worth of
information for autofill suggestions as well as a leading icon
for the given suggestion (if any).

Bug:  870342 
Change-Id: Iaa303bafea5fe09f81538d452e2f6871c0d4282a

Screenshots (Googlers-only): https://drive.google.com/drive/folders/1XDzDE9GiOt4bAG_kDXZDaiJbbBvuTwPX?usp=sharing

Change-Id: Iaa303bafea5fe09f81538d452e2f6871c0d4282a
Reviewed-on: https://chromium-review.googlesource.com/1234968
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593569}
[modify] https://crrev.com/bd543e3d81c3d54a016181c52af048cbcac5b56b/chrome/browser/about_flags.cc
[modify] https://crrev.com/bd543e3d81c3d54a016181c52af048cbcac5b56b/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/bd543e3d81c3d54a016181c52af048cbcac5b56b/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/bd543e3d81c3d54a016181c52af048cbcac5b56b/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/bd543e3d81c3d54a016181c52af048cbcac5b56b/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/bd543e3d81c3d54a016181c52af048cbcac5b56b/components/autofill/core/browser/credit_card.h
[modify] https://crrev.com/bd543e3d81c3d54a016181c52af048cbcac5b56b/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/bd543e3d81c3d54a016181c52af048cbcac5b56b/components/autofill/core/browser/suggestion.h
[modify] https://crrev.com/bd543e3d81c3d54a016181c52af048cbcac5b56b/components/autofill_strings.grdp

Blocking: 889588
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/521a2b14770301230de9d9bedbca136e1db63853

commit 521a2b14770301230de9d9bedbca136e1db63853
Author: Tommy Martino <tmartino@chromium.org>
Date: Thu Sep 27 17:04:30 2018

[Autofill Views] Expanding two-line password use

Currently, the password dropdown only uses a two-line style when
disambiguation text (i.e., the subdomain on which the password was
saved) is available. For the experiment, when a user is in the Two-Line
group, we want to always use a two-line display, even when no such text
is present. This CL puts the obscured password (e.g., *****) on the
second line in such cases.

Bug:  870342 
Change-Id: I77deba680277bdbe9ed8e435205e8fc7f18f0ef4
Reviewed-on: https://chromium-review.googlesource.com/1247029
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594757}
[modify] https://crrev.com/521a2b14770301230de9d9bedbca136e1db63853/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Status: Fixed (was: Started)

Sign in to add a comment