Left-clicking textbox selects a word |
||||||||
Issue descriptionA left-click in the omnibox while editing selects an entire word in 70.0.3510.0. This doesn't happen in other textfields, or in the omnibox when not editing. 1. Click in the omnibox to focus it (if necessary) 2. Type "abc def" 3. Left-click on "abc" - it gets selected.
,
Aug 2
Mac triage: actually, over to Avi. This one's pretty bad so let's aim to merge a fix to M69 if we can.
,
Aug 2
Definitely my https://chromium-review.googlesource.com/1144225 fix for the shadow overlap.
,
Aug 2
My understanding was incorrect. Even though the TopBackgroundView has mouse event handling, OnMouseEvent is getting double-processed.
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bbcb6d9a77ca05e2cb7ab2cb8dde5beb8b3ab25 commit 4bbcb6d9a77ca05e2cb7ab2cb8dde5beb8b3ab25 Author: Avi Drissman <avi@chromium.org> Date: Fri Aug 03 17:13:31 2018 Only process an omnibox click once when the results pane is showing. BUG= 870341 TEST=as in bug Change-Id: Ia9ede9c30d95b9f569890eff242582129967dd11 Reviewed-on: https://chromium-review.googlesource.com/1161251 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580577} [modify] https://crrev.com/4bbcb6d9a77ca05e2cb7ab2cb8dde5beb8b3ab25/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc
,
Aug 3
,
Aug 3
Issue 870544 has been merged into this issue.
,
Aug 4
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 5
How is the change listed at #5 looking canary? Is it safe to merge to M69? "RBS" for M69 as this is P1 and blocking MacViews launch.
,
Aug 5
This is looking good on 70.0.3513.0 and was written to be a simple and safe merge.
,
Aug 5
Approving merge for CL listed at #5 to M69 branch 3497 based on comments #10. Please merge by 4:00 PM PT, Monday (08/06) so we can pick it up for next week M69 beta release. Thank you.
,
Aug 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36e0a66898307b02953da55eea788ee39d7d9739 commit 36e0a66898307b02953da55eea788ee39d7d9739 Author: Avi Drissman <avi@chromium.org> Date: Sun Aug 05 23:35:56 2018 Only process an omnibox click once when the results pane is showing. BUG= 870341 TEST=as in bug Change-Id: Ia9ede9c30d95b9f569890eff242582129967dd11 Reviewed-on: https://chromium-review.googlesource.com/1161251 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#580577}(cherry picked from commit 4bbcb6d9a77ca05e2cb7ab2cb8dde5beb8b3ab25) Reviewed-on: https://chromium-review.googlesource.com/1163262 Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#404} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/36e0a66898307b02953da55eea788ee39d7d9739/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ellyjo...@chromium.org
, Aug 2