New issue
Advanced search Search tips

Issue 870328 link

Starred by 1 user
Status: Fixed
Owner:
mahmadi@chromium.org
Closed: Aug 14
Cc:
se...@chromium.org
rogerm@chromium.org
ma...@chromium.org
ftirelo@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 860526



Sign in to add a comment

Deprecate autofill::prefs::kAutofillEnabled

Project Member Reported by mahmadi@chromium.org, Aug 2 
Deprecate kAutofillEnabled in favor of three finer grained prefs to control Autofilling addresses, credit cards and autocomplete.

Comment 1 by se...@chromium.org, Aug 2 

You probably already know about this, but please be careful to keep supporting the AutofillEnabled Enterprise Policy :)

It should be as easy as setting the two sub-prefs in the policy handler.

Comment 2 by mahmadi@chromium.org, Aug 2

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/173b0a2b2d8f0481858176694590e06a96a8c492

commit 173b0a2b2d8f0481858176694590e06a96a8c492
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Aug 03 17:35:51 2018

[AF] Replaces direct accesses to Autofill enablement prefs with accessors

- This CL facilitates deprecation and replacement of kAutofillEnabled by
  finer grained prefs.
- This CL also removes unnecessary usages of kAutofillEnabled. The only
  remaining usages are where the pref is registered or observed which will
  be replaced by appropriate pref(s) once kAutofillEnabled is deprecated.

Bug:  870328 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I30f410d11b6c4e4cd9d87bf532ebefeaa5f565f8
Reviewed-on: https://chromium-review.googlesource.com/1160865
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580586}
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/autofill/content_autofill_driver_browsertest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autocomplete_history_manager.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_address_policy_handler.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_address_policy_handler_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_credit_card_policy_handler.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_credit_card_policy_handler_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_download_manager.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_experiments_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_policy_handler.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_policy_handler_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_wallet_data_type_controller.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/autofill_wallet_data_type_controller_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/form_data_importer_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/local_card_migration_manager.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/local_card_migration_manager_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/payments/full_card_request.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/test_local_card_migration_manager.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/common/BUILD.gn
[delete] https://crrev.com/ef36dc19986a90f49d0d31520c88d310d72bd038/components/autofill/core/common/autofill_pref_names.cc
[delete] https://crrev.com/ef36dc19986a90f49d0d31520c88d310d72bd038/components/autofill/core/common/autofill_pref_names.h
[add] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/common/autofill_prefs.cc
[add] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/core/common/autofill_prefs.h
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/autofill/ios/browser/autofill_agent_unittests.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/password_manager/core/browser/votes_uploader_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/unified_consent/unified_consent_service.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/components/unified_consent/unified_consent_service_unittest.cc
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/chrome/browser/autofill/autofill_controller.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/web_view/internal/autofill/cwv_credit_card_verifier_unittest.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/web_view/internal/cwv_preferences.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/web_view/internal/cwv_preferences_unittest.mm
[modify] https://crrev.com/173b0a2b2d8f0481858176694590e06a96a8c492/ios/web_view/internal/web_view_browser_state.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6736aade5e4a00c61d3e70decf8b7eb8ee1c7ced

commit 6736aade5e4a00c61d3e70decf8b7eb8ee1c7ced
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Aug 07 21:50:36 2018

[AF] Add the new Autofill prefs to the extensions prefs API

Adds kAutofillCreditCardEnabled and kAutofillProfileEnabled to
the extensions prefs API

Bug:  870328 
Change-Id: Ic5961b3cd58c58381764f6eddf2698df72db8695
Reviewed-on: https://chromium-review.googlesource.com/1161002
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581354}
[modify] https://crrev.com/6736aade5e4a00c61d3e70decf8b7eb8ee1c7ced/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/6736aade5e4a00c61d3e70decf8b7eb8ee1c7ced/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] https://crrev.com/6736aade5e4a00c61d3e70decf8b7eb8ee1c7ced/chrome/common/extensions/api/privacy.json
[modify] https://crrev.com/6736aade5e4a00c61d3e70decf8b7eb8ee1c7ced/chrome/test/data/extensions/api_test/preference/standard/test.js

Comment 5 by mahmadi@chromium.org, Aug 14

Blocking: 860526
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b24d6f3f4872591db9457559a7fc6bde01aaa2

commit 97b24d6f3f4872591db9457559a7fc6bde01aaa2
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Aug 14 16:30:48 2018

[AF] Deprecates autofill::prefs::kAutofillEnabled

Deprecates kAutofillEnabled in favor of finer grained
kAutofillProfileEnabled and kAutofillCreditCardEnabled

Keeps kAutofillEnabled around to maintain backward compatibility for the
extensions and the policy APIs. If kAutofillEnabled is set by an extension,
values of kAutofillProfileEnabled and  kAutofillCreditCardEnabled are also
set. Similarly, if kAutofillEnabled is disabled by policy, the two
fine-grained prefs are also disabled.

Chrome extension for testing the chrome.privacy.services API:
https://github.com/mhahmadi/autofill-pref-api-test-extension

TBR=michaelbai@

Bug:  870328 ,  860526 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8e6ca4594aa73c3d9228734948353f6a686227ad
Reviewed-on: https://chromium-review.googlesource.com/1166211
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582936}
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/common/extensions/api/privacy.json
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/test/data/extensions/api_test/preference/standard/test.js
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/autofill_policy_handler.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/autofill_policy_handler_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/common/autofill_prefs.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/common/autofill_prefs.h
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/password_manager/core/browser/votes_uploader_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/policy/resources/policy_templates.json
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/ios/web_view/internal/cwv_preferences_unittest.mm

Comment 7 by mahmadi@chromium.org, Aug 14

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3061bdc4b480f5c5f4f91f3735b17178933b9ff

commit c3061bdc4b480f5c5f4f91f3735b17178933b9ff
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Aug 30 16:25:32 2018

[AF] Migrate the value of kAutofillEnabledDeprecated to the new prefs

Sets the value of the new Autofill prefs "once" to the value of the now
deprecated Autofill master pref once all profile prefs are registered.
This is required for those users who had Autofill disabled before
introduction of the new prefs.

Bug:  870328 , 877801 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iac4c1f7325c3a058b3d0fda0af0500a0ff23106a
Reviewed-on: https://chromium-review.googlesource.com/1194598
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587613}
[modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/components/autofill/core/common/BUILD.gn
[modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/components/autofill/core/common/autofill_prefs.cc
[modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/components/autofill/core/common/autofill_prefs.h
[add] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/components/autofill/core/common/autofill_prefs_unittest.cc
[modify] https://crrev.com/c3061bdc4b480f5c5f4f91f3735b17178933b9ff/ios/chrome/browser/prefs/browser_prefs.mm
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1b8f512b820a18bb1c0105f23e16257379d8f2

commit 6c1b8f512b820a18bb1c0105f23e16257379d8f2
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Sep 07 17:32:44 2018

[AF] Fixes migration of the kAutofillEnabledDeprecated pref

The migration was added for Android only by mistake (crrev.com/c/1194598)

Bug:  870328 , 877801 
Change-Id: Ie21b24ce67ef437dfa60755a5ec9ce03d5eb2661
Reviewed-on: https://chromium-review.googlesource.com/1213548
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589565}
[modify] https://crrev.com/6c1b8f512b820a18bb1c0105f23e16257379d8f2/chrome/browser/prefs/browser_prefs.cc

Comment 10 by mahmadi@chromium.org, Sep 7

Labels: Merge-Request-70
Requesting merge into M70 for the change in #c9
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 11

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ac1a4728115f93eb24928678b753a858259602e

commit 5ac1a4728115f93eb24928678b753a858259602e
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Sep 11 14:47:08 2018

[AF] Fixes migration of the kAutofillEnabledDeprecated pref

The migration was added for Android only by mistake (crrev.com/c/1194598)

TBR=mahmadi@chromium.org

(cherry picked from commit 6c1b8f512b820a18bb1c0105f23e16257379d8f2)

Bug:  870328 , 877801 
Change-Id: Ie21b24ce67ef437dfa60755a5ec9ce03d5eb2661
Reviewed-on: https://chromium-review.googlesource.com/1213548
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589565}
Reviewed-on: https://chromium-review.googlesource.com/1219776
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#270}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/5ac1a4728115f93eb24928678b753a858259602e/chrome/browser/prefs/browser_prefs.cc
►

Sign in to add a comment