New issue
Advanced search Search tips

Issue 870289 link

Starred by 3 users
Status: Fixed
Owner:
joelhockey@chromium.org
Closed: Aug 9
Cc:
cfroussios@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

CrostiniInstallerViewBrowserTest.InstallFlow flaky on chromium.chromiumos/linux-chromeos-rel

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 2 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of cfroussios@google.com

browser_tests, mash_browser_tests, viz_browser_tests failing on chromium.chromiumos/linux-chromeos-rel

Example build
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11434

First build that fails is
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11428
but it contains no Crostini CLs

The previous build passed and contains possible culrpits
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11427
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4

commit 1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4
Author: Christos Froussios <cfroussios@chromium.org>
Date: Thu Aug 02 12:40:08 2018

Revert "CrOS crostini: sshfs mount immediately when container starts"

This reverts commit 64ab6403e0d694c98d4da8a2dd961907e1ddf056.

Reason for revert: Suspected of making 
CrostiniInstallerViewBrowserTest.InstallFlow very flaky on 
linux-chromeos-rel

Original change's description:
> CrOS crostini: sshfs mount immediately when container starts
> 
> Perform sshfs mount to termina/penguin immediately when container
> starts.  Mounting code has moved from the chrome.fileManagerPrivate
> extension functions into CrostiniManager.
> 
> This change will make FilesApp more responsive to users who are
> likely to use terminal or some other crostini app before using FilesApp.
> 
> Bug: 846917
> Change-Id: I9fc246e45e54390e7a75f15a5571a24218cf2d5c
> Reviewed-on: https://chromium-review.googlesource.com/1158317
> Reviewed-by: Nicholas Verne <nverne@chromium.org>
> Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580094}

TBR=joelhockey@chromium.org,nverne@chromium.org

Change-Id: Ib00e4417faaa482d62f03bed708dd46b1e0f7902
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846917,  870289 
Reviewed-on: https://chromium-review.googlesource.com/1160541
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580145}
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/browser/chromeos/file_manager/path_util.h
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/browser/ui/views/crostini/crostini_installer_view.cc
[modify] https://crrev.com/1c3b10d1bacd74ecfc6cfb77e4e93b9f1fddc5c4/chrome/browser/ui/views/crostini/crostini_installer_view.h

Comment 3 by cfroussios@chromium.org, Aug 2 

 Issue 870283  has been merged into this issue.

Comment 4 by cfroussios@chromium.org, Aug 2

Cc: -cfroussios@google.com cfroussios@chromium.org
Labels: -Sheriff-Chromium OS-Chrome
Owner: joelhockey@chromium.org
Status: Assigned (was: Available)
Reverting seems to have worked

Comment 5 by weifangsun@chromium.org, Aug 3

Components: OS>Systems>Containers

Comment 6 by joelhockey@chromium.org, Aug 9

Status: Fixed (was: Assigned)
Relanded with fix in crosreview.com/1161761
►

Sign in to add a comment