New issue
Advanced search Search tips

Issue 870284 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 789094



Sign in to add a comment

"ResetFirstAfterBootTest.RollbackUnavailable" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 2

Issue description

"ResetFirstAfterBootTest.RollbackUnavailable" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitSZXNldEZpcnN0QWZ0ZXJCb290VGVzdC5Sb2xsYmFja1VuYXZhaWxhYmxlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: xiy...@chromium.org
Handing off to xiyuan, the OWNER who is TBR'd on the CL disabling the test, for further triage.
Labels: -Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ab795b0c56585083073b07c59768dd68da2e9bf

commit 0ab795b0c56585083073b07c59768dd68da2e9bf
Author: Tommy Martino <tmartino@chromium.org>
Date: Thu Aug 02 16:01:11 2018

Disabling Flaky Test RollbackUnavailable

ResetFirstAfterBootTest.RollbackUnavailable has been flaky. Disabling.

TBR=xiyuan@chromium.org

Bug: 870284
Change-Id: I7226ae73ca9c4cf440de3fbeae28886309d907d9
Reviewed-on: https://chromium-review.googlesource.com/1160866
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580207}
[modify] https://crrev.com/0ab795b0c56585083073b07c59768dd68da2e9bf/chrome/browser/chromeos/login/reset_browsertest.cc

Cc: hayato@chromium.org
The real problem is that login webui somehow triggered a DCHECK in the renderer and bailed. +hayato for insights of the failed DCHECK [1].

[1:1:0801/181440.850317:FATAL:flat_tree_traversal_ng.h(145)] Check failed: !node.NeedsDistributionRecalc().
#0 0x000004b8545c base::debug::StackTrace::StackTrace()
#1 0x000004aee5ab logging::LogMessage::~LogMessage()
#2 0x000004a6537a blink::FlatTreeTraversalNg::AssertPrecondition()
#3 0x0000087aee85 blink::FlatTreeTraversalNg::ContainsIncludingPseudoElement()
#4 0x0000087c6edf blink::Node::IsInert()
#5 0x0000089dfba7 blink::LocalFrame::PropagateInertToChildFrames()
#6 0x000008b87577 blink::HTMLDialogElement::showModal()
#7 0x00000829d211 blink::V8HTMLDialogElement::showModalMethodCallback()
#8 0x000003ea3ff7 v8::internal::FunctionCallbackArguments::Call()
#9 0x000003ea27bf v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#10 0x000003ea0be8 v8::internal::Builtin_Impl_HandleApiCall()
#11 0x000003ea0621 v8::internal::Builtin_HandleApiCall()
#12 0x00000086fd75 <unknown>
[30745:30974:0801/181441.041465:ERROR:crash_handler_host_linux.cc(442)] Failed to write crash dump for pid 31001
Cannot upload crash dump: failed to open
Failed to save crash dump: failed to open
[30745:30974:0801/181441.043468:ERROR:crash_handler_host_linux.cc(442)] Failed to write crash dump for pid 31001
Cannot upload crash dump: failed to open
Failed to save crash dump: failed to open
[30745:30745:0801/181441.178587:FATAL:login_display_host_webui.cc(839)] Renderer crash on login window

[1]: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/flat_tree_traversal_ng.h?rcl=9392ad2ec3734d7d25fc93e21c091182af1d93d6&l=145
Blockedon: 789094
I've seen a similar issue about Node::IsInert. 

Maybe this has the same root cause to https://bugs.chromium.org/p/chromium/issues/detail?id=789094.
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment