Arrow key input in selectric component sometimes cause NTP scrolling
Reported by
khushal....@etouch.net,
Aug 2
|
|||||||||
Issue descriptionChrome Version : 70.0.3510.0 (Official Build) Revision 1a6253886c7f5a78dc4e34f73371d56dd07595b5-refs/branch-heads/3510@{#1} (32/64-bit) OS: Win (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) & Linux (14.04 LTS) Pre-condition: Enable the flag "New Tab Page Background Selection" from chrome://flags. Steps to reproduce: 1. Launch chrome and open NTP. 2. Press 'Tab' key to get focus on gear icon and press 'Enter' key. 3. Now move the focus using keyboard Up/Down keys and Observe. Actual Result: Arrow key input in selectric component sometimes cause NTP scrolling. Expected Result: Arrow key input in selectric component should not cause NTP scrolling. This is a Non-regression issue seen from ‘M-70’ series build version 70.0.3505.0 as arrow key input is enabled for gear options. Kindly refer the attached screen-cast. Thank You..!!
,
Aug 3
Update: With respect to comment #1, As mentioned, rechecked the above issue by enabling the flags #ntp-custom-links or #ntp-icons on latest canary version 70.0.3511.0 and the issue is still reproducible. NOTE: Additionally observe that issue is only seen on monitors where Chrome NTP gets displayed with vertical scrollbar. Issue is not seen if NTP doesn't have vertical scrollbar. Please refer the attached screen-cast. Pardon me if it is an intended change. Thank You..!!
,
Aug 3
Ramya - if possible, can you bundle this with your check on Eve spacing? If not we can fix it for M70.
,
Aug 3
,
Aug 3
,
Aug 7
,
Aug 14
Reporter - can you check if this still reproduces?
,
Aug 22
I can repro on 70.0.3529.3, but only when the window size is smaller than the min height required to show both rows of icons (ie. this won't affect fullscreen on Eve). Weilun - can you take a look? Kristi cc'd as there may be a simple CSS fix here.
,
Aug 23
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d87ba298bf0b495beb1544941851f9f3be47223 commit 3d87ba298bf0b495beb1544941851f9f3be47223 Author: Weilun Shi <sweilun@chromium.org> Date: Thu Aug 23 04:08:53 2018 [NTP] Arrow key on customize this page dialog will not cause scrolling When open the dialog, the whole page is considered as the dialog. The default behavior of the arrow key on the scrollable page is to scroll the page. Adding preventDefault to each option and the dialog itself can prevent such behavior. Screencast: https://screencast.googleplex.com/cast/NTQ0OTg2NjI0MzIxMTI2NHxhYzQzMTRiYi01MA Bug: 870268 Change-Id: I5c3f92e6d2e9faaff704e053c0e9540f028ebed5 Reviewed-on: https://chromium-review.googlesource.com/1186073 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#585392} [modify] https://crrev.com/3d87ba298bf0b495beb1544941851f9f3be47223/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Aug 23
,
Aug 24
Update: Rechecked the above issue on Win (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) & Linux (14.04 LTS) using latest canary version 70.0.3532.0 and the issue is found FIXED. Hence, adding the respective labels. Please refer the attached screen-cast. Thank You..!! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by yyushkina@chromium.org
, Aug 2