“New Incognito tabs” text is seen for a second on tapping on tabswithcer icon |
|||||||
Issue descriptionApp Version: 69.0.3497.22 iOS Version: iOS 10.3.3,11.4,12 Device: iPhones only Steps to reproduce: 1. Launch Chrome 2. Tap on Menu > New Incognito tab. 3. Tap on Tabswithcer icon Observed results: New Incognito tabs” text is seen for a second Expected results: New Incognito tabs” text should not be seen Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : NA, New UI in M69 Bug reproducible on the current beta channel build : Yes in M69 Link to video/image: https://drive.google.com/file/d/1vwITBQONftKLQE7nYpMlkTfDBqdVG9Vy/view?usp=sharing
,
Aug 3
,
Aug 6
,
Aug 7
We should fix this for M70.
,
Aug 8
Issue 860183 has been merged into this issue.
,
Aug 15
In-flight.
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5202a6de86eff298ce8fb60e7871e4b2da65c1b1 commit 5202a6de86eff298ce8fb60e7871e4b2da65c1b1 Author: edchin <edchin@chromium.org> Date: Mon Aug 20 18:46:43 2018 [ios] Fix tab grid empty state disappearance Previously, the empty state was showing for a split second, then animating off. If there are items in the grid, the empty state should just not show, rather than animating off. Bug: 870267 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6de30daaf0fb7ee5b1fe0ffe3f2da78ac95c7a83 Reviewed-on: https://chromium-review.googlesource.com/1176647 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584516} [modify] https://crrev.com/5202a6de86eff298ce8fb60e7871e4b2da65c1b1/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
,
Aug 20
,
Aug 29
Verified in 70.0.3535.0 Canary in iPhone 8plus(iOS 12 beta 11), iPhone 7plus(iOS 10.3.3) and iPhone 8plus(iOS 11.4.1) “New Incognito tabs” text is not displayed on tapping tabswitcher icon. Looks good Link to video: https://drive.google.com/file/d/1X-VF20u4IMEoA5kHONenzsq0V74eoyyv/view?usp=sharing |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kkhorimoto@chromium.org
, Aug 2Owner: marq@chromium.org
Status: Assigned (was: Untriaged)