Regression : chrome does not accept passphrase event after entering valid passphrase
Reported by
pranjali...@etouch.net,
Aug 2
|
|||||
Issue descriptionChrome version : 70.0.3510.2 (Official Build) 19bbe7b51081dd5aca29d10d5f881cce7eb95ff8-refs/branch-heads/3510@{#4}(32/64 bit) OS: Windows(7,8,8.1.10) ,Linux(14.04 LTS) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14). Precondition: Sign into chrome which has passphrase sync What steps will reproduce the problem? 1.Launch chrome and click on avatar icon(i.e which shows an error) 2. Click on 'enter passphrase' button(such that it will navigate to 'chrome://settings/syncSetup'). 3. Now enter correct passphrase in passphrase textbox and click on 'submit' button. 4.Observe. Actual : chrome does not accept passphrase event after entering valid passphrase Expected: chrome should accept passphrase after entering valid passphrase This is a regression issue broken in ‘M-70’ and using per-revision bisect providing the bisect results, Good Build : 70.0.3508.0 Bad Build: 70.0.3509.0 You are probably looking for a change made after 579331 (known good), but no later than 579332 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/527bcdc02f68c12885551bebbeb20e412185f509..44c147a996a01562177ff939867aa7199ec72e09 Suspect : https://chromium.googlesource.com/chromium/src/+/44c147a996a01562177ff939867aa7199ec72e09 mastiz@Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Unwanted scrollbar is also seen after hovering mouse on iron-icon. Thank You!
,
Aug 3
,
Aug 3
Issue 870676 has been merged into this issue.
,
Aug 3
,
Aug 8
,
Aug 8
I could repro the issue locally and can confirm that the suspect patch is the culprit. I'll prepare a fix.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5959e98f577493fa9597ed89d87a3afdd0c8243f commit 5959e98f577493fa9597ed89d87a3afdd0c8243f Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Aug 08 13:12:39 2018 Fix sync setup UI not updated when passphrase entered This fixes a regression introduced in https://chromium-review.googlesource.com/1152812 due to an accidental behavioral change that dropped a notification to observers when the sync setup UI is opened (i.e. SyncServiceCrypto::OnPassphraseAccepted() always notified observers prior to the offending patch). This patch reverts that behavioral change. Bug: 870256 Change-Id: If51618607c85aee806f982680b5eb83b77b5c615 Reviewed-on: https://chromium-review.googlesource.com/1166904 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#581542} [modify] https://crrev.com/5959e98f577493fa9597ed89d87a3afdd0c8243f/components/browser_sync/profile_sync_service.cc
,
Aug 8
,
Aug 9
Update : Rechecked the above issue on Windows(7,8,8.1,10) OS and Linux(14.04 LTS) with latest Canary Chrome version #70.0.3517.0 and the issue is fixed. Unable to check the issue on Mac since latest Canary is not yet available .Will update Mac behavior once build is available. Kindly refer the attached screen cast.
,
Aug 10
Update : Rechecked the above issue on Windows(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS) with latest Canary Chrome version #70.0.3518.0 and the issue is fixed. Kindly refer the attached screen cast. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rbasuvula@chromium.org
, Aug 2Labels: ReleaseBlock-Stable