Keyboard accessory persists after keyboard is gone |
|||
Issue descriptionChrome Version: 70.0.3508.0 (Canary) OS: Android What steps will reproduce the problem? (1) Navigate to a sign-up form where generation is available. (2) Tap on the new password field (should display the accessory with the generation button), then on the key icon. (3) With the accessory sheet displayed, lock the device. What is the expected result? When the device is unlocked the keyboard and the accessory are gone. What happens instead? When the device is unlocked the keyboard is gone, but the accessory with the generation action is still shown.
,
Aug 2
Thanks, this seems to be closely related to issue 856039 . The underlying reason there seems to be that we don't restore the accessory state |onResume| of the ChromeActivity - so maybe the fix I am working on will solve that as well.
,
Aug 2
This seems to also happen without backgrounding Chrome, by tapping on the omnibox and navigating to another page when the accessory sheet is open.
,
Aug 2
Thanks, that's also related and now fixed and tested by the CL.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75644b6915c0d14913feec14b82e48bbab70bcdd commit 75644b6915c0d14913feec14b82e48bbab70bcdd Author: Friedrich Horschig <fhorschig@chromium.org> Date: Wed Aug 08 12:30:39 2018 [Android] Restore keyboard accessory on resume of Chrome When Chrome is backgrounded (e.g. by pressing home or locking the device), its state is properly preserved but wasn't restored before this CL. With this CL, this is done now. This fixes issues like the keyboard accessory being permanently dismissed or keeping a state that should have been reset (most notably the generation button). Bug: 856039 , 870238 Change-Id: I5543fb5b7dc8cfbe690d7df9a6ddb47346928704 Reviewed-on: https://chromium-review.googlesource.com/1160481 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581529} [modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java [modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java [modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java [modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java [modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java [modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
,
Aug 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ioanap@chromium.org
, Aug 2