New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870220 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Generation dropdown does not reappear after clearing manually generated password

Project Member Reported by maxwalker@chromium.org, Aug 2

Issue description

1. Focus field
2. Dropdown shows a saved password (mayap...@gmail.com) and Suggest strong password (ambiguous field)
3. Click Suggest strong password and then Use suggested password
4. Clear field
5. Unfocus field, focus field again
6. Dropdown does not reappear
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a9b1da85811ac1fef711e6e6e986393e76f73e1

commit 4a9b1da85811ac1fef711e6e6e986393e76f73e1
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Sep 14 17:34:22 2018

If a password was deleted somehow from the store, the password dropdown should
forget about it immediately.

Before the CL:
- you open a page with multiple credentials saved.
- delete one through the bubble.
- the credentials is still presented in the dropdown on click.

After the CL the credential is removed from the dropdown. If there is nothing
to show then the dropdown won't appear.

Bug:  870220 
Change-Id: I485a3243f51b0d5c738ec407c4ec71dc71aa06ff
Reviewed-on: https://chromium-review.googlesource.com/1226598
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591382}
[modify] https://crrev.com/4a9b1da85811ac1fef711e6e6e986393e76f73e1/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/4a9b1da85811ac1fef711e6e6e986393e76f73e1/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/4a9b1da85811ac1fef711e6e6e986393e76f73e1/components/password_manager/core/browser/new_password_form_manager.h
[modify] https://crrev.com/4a9b1da85811ac1fef711e6e6e986393e76f73e1/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/4a9b1da85811ac1fef711e6e6e986393e76f73e1/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/4a9b1da85811ac1fef711e6e6e986393e76f73e1/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/4a9b1da85811ac1fef711e6e6e986393e76f73e1/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/4a9b1da85811ac1fef711e6e6e986393e76f73e1/components/password_manager/core/browser/password_form_manager_for_ui.h
[modify] https://crrev.com/4a9b1da85811ac1fef711e6e6e986393e76f73e1/components/password_manager/core/browser/password_manager.cc

This is a wrong bug. The correct one should be Issue 876521
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/774332ae986db3ad058a2683790025cce1143992

commit 774332ae986db3ad058a2683790025cce1143992
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Nov 06 14:16:58 2018

Create a separate structure that tracks the current generation status for a
field in PasswordGenerationAgent.

Currently |generation_element_| has a double meaning. It's an element that
should trigger the automatic generation. However, if a manual generation is
triggered then it's overwritten by a password field. That's confusing.
The CL decouples the field that should trigger the automatic generation from
whatever is happening right now on a random password field.
In the future that will allow us to have multiple generation elements
simultaneously. For now it fixes 870220 where the manual generation on the
ambiguous field was suppressing the automatic generation on it.

Bug:  870220 ,852309
Change-Id: I6a3edd351e615289f6271fda5a45f6ff47e653af
Reviewed-on: https://chromium-review.googlesource.com/c/1310713
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605668}
[modify] https://crrev.com/774332ae986db3ad058a2683790025cce1143992/chrome/browser/password_manager/password_generation_interactive_uitest.cc
[modify] https://crrev.com/774332ae986db3ad058a2683790025cce1143992/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/774332ae986db3ad058a2683790025cce1143992/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/774332ae986db3ad058a2683790025cce1143992/components/autofill/content/renderer/password_generation_agent.h

Status: Fixed (was: Assigned)

Sign in to add a comment