New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870217 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 869890
Owner:
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 696597



Sign in to add a comment

Saved password dropdown stays visible after deleting a manually generated password

Project Member Reported by maxwalker@chromium.org, Aug 2

Issue description

After deleting the generated password (via select all, backspace) the dropdown keeps showing the saved-password state. Instead it should fall back to the suggestion state.
 
Saved Empty Password.png
92.0 KB View Download
Blocking: 696597
Labels: M-69
Mergedinto: 869890
Status: Duplicate (was: Assigned)
Status: Started (was: Duplicate)
This isn't really a duplicate.
What is the difference? :)
This is a bug really. We don't close the dropdown when leaving the editing state. Another issue is a feature request on when exactly to leave the editing state.
Got it, thanks for clarifying!
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205

commit 2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Aug 03 12:45:12 2018

Hide "edit generated password" prompt when leaving the editing state.

It's questionable whether the popup should move back to the generation state.
Curently for automatic generation it does and the bug isn't observed. For
manual generation it doesn't and therefore the editing prompt remains open.
The CL fixes that.

Bug:  870217 
Change-Id: Ib9758f87208d82fd8bd52cdcd1aef664d4f2cba5
Reviewed-on: https://chromium-review.googlesource.com/1160849
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580516}
[modify] https://crrev.com/2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205/components/autofill/content/renderer/password_generation_agent.cc

Cc: kolos@chromium.org
Labels: Merge-Request-69
I'd like to merge r580516 back. It's a bug fix for the password generation scheduled for M69.
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 6

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Is the change well baked/verified in canary, having enough automation tests coverage and safe to merge?
The change originally landed in 70.0.3512.0. Now it's 70.0.3515.0. I added an interactive UI test for it. The change is safe and tiny. It doesn't affect anything beyond password generation.
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge for r580516 to M69 branch 3497 based on comment #10 and #13. Please merge ASAP so we can pick it up for this week Beta release. Thank you.
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 7

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e5444890177ccb8758a447a12985b54afc9b4c6

commit 2e5444890177ccb8758a447a12985b54afc9b4c6
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Aug 07 14:37:43 2018

Hide "edit generated password" prompt when leaving the editing state.

It's questionable whether the popup should move back to the generation state.
Curently for automatic generation it does and the bug isn't observed. For
manual generation it doesn't and therefore the editing prompt remains open.
The CL fixes that.

TBR=vasilii@chromium.org

(cherry picked from commit 2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205)

Bug:  870217 
Change-Id: Ib9758f87208d82fd8bd52cdcd1aef664d4f2cba5
Reviewed-on: https://chromium-review.googlesource.com/1160849
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580516}
Reviewed-on: https://chromium-review.googlesource.com/1165350
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#463}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2e5444890177ccb8758a447a12985b54afc9b4c6/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/2e5444890177ccb8758a447a12985b54afc9b4c6/components/autofill/content/renderer/password_generation_agent.cc

Status: Fixed (was: Started)

Sign in to add a comment