Saved password dropdown stays visible after deleting a manually generated password |
|||||||||
Issue descriptionAfter deleting the generated password (via select all, backspace) the dropdown keeps showing the saved-password state. Instead it should fall back to the suggestion state.
,
Aug 2
,
Aug 2
This isn't really a duplicate.
,
Aug 2
What is the difference? :)
,
Aug 2
This is a bug really. We don't close the dropdown when leaving the editing state. Another issue is a feature request on when exactly to leave the editing state.
,
Aug 3
Got it, thanks for clarifying!
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205 commit 2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Aug 03 12:45:12 2018 Hide "edit generated password" prompt when leaving the editing state. It's questionable whether the popup should move back to the generation state. Curently for automatic generation it does and the bug isn't observed. For manual generation it doesn't and therefore the editing prompt remains open. The CL fixes that. Bug: 870217 Change-Id: Ib9758f87208d82fd8bd52cdcd1aef664d4f2cba5 Reviewed-on: https://chromium-review.googlesource.com/1160849 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580516} [modify] https://crrev.com/2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205/chrome/browser/password_manager/chrome_password_manager_client.cc [modify] https://crrev.com/2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205/components/autofill/content/renderer/password_generation_agent.cc
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d642660a22e0cfe35bc4502c9c26e9c00f60862 commit 3d642660a22e0cfe35bc4502c9c26e9c00f60862 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Aug 03 13:30:08 2018 Add tests for deleting the generated password. This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1160849. The tests are not to be merged back to M69. Bug: 870217 Change-Id: I0bc691bb8168c9a3887ef572f1bfa15d2e5cb68f Reviewed-on: https://chromium-review.googlesource.com/1160851 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#580524} [modify] https://crrev.com/3d642660a22e0cfe35bc4502c9c26e9c00f60862/chrome/browser/password_manager/password_generation_interactive_uitest.cc [modify] https://crrev.com/3d642660a22e0cfe35bc4502c9c26e9c00f60862/chrome/browser/password_manager/password_manager_interactive_test_base.cc [modify] https://crrev.com/3d642660a22e0cfe35bc4502c9c26e9c00f60862/chrome/browser/password_manager/password_manager_interactive_test_base.h [modify] https://crrev.com/3d642660a22e0cfe35bc4502c9c26e9c00f60862/chrome/browser/password_manager/password_manager_interactive_uitest.cc
,
Aug 6
,
Aug 6
I'd like to merge r580516 back. It's a bug fix for the password generation scheduled for M69.
,
Aug 6
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 6
Is the change well baked/verified in canary, having enough automation tests coverage and safe to merge?
,
Aug 7
The change originally landed in 70.0.3512.0. Now it's 70.0.3515.0. I added an interactive UI test for it. The change is safe and tiny. It doesn't affect anything beyond password generation.
,
Aug 7
Approving merge for r580516 to M69 branch 3497 based on comment #10 and #13. Please merge ASAP so we can pick it up for this week Beta release. Thank you.
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e5444890177ccb8758a447a12985b54afc9b4c6 commit 2e5444890177ccb8758a447a12985b54afc9b4c6 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue Aug 07 14:37:43 2018 Hide "edit generated password" prompt when leaving the editing state. It's questionable whether the popup should move back to the generation state. Curently for automatic generation it does and the bug isn't observed. For manual generation it doesn't and therefore the editing prompt remains open. The CL fixes that. TBR=vasilii@chromium.org (cherry picked from commit 2c920ffcf89a4bed8c5cd6aa550bd5c6fcb94205) Bug: 870217 Change-Id: Ib9758f87208d82fd8bd52cdcd1aef664d4f2cba5 Reviewed-on: https://chromium-review.googlesource.com/1160849 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#580516} Reviewed-on: https://chromium-review.googlesource.com/1165350 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#463} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/2e5444890177ccb8758a447a12985b54afc9b4c6/chrome/browser/password_manager/chrome_password_manager_client.cc [modify] https://crrev.com/2e5444890177ccb8758a447a12985b54afc9b4c6/components/autofill/content/renderer/password_generation_agent.cc
,
Aug 7
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by maxwalker@chromium.org
, Aug 2Labels: M-69