New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870208 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: ----



Sign in to add a comment

device_unittests failing on chromium.win/Win10 Tests x64 (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 2

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of cfroussios@google.com

device_unittests failing on chromium.win/Win10 Tests x64 (dbg)

Builders failed on: 
- Win10 Tests x64 (dbg): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29

A bunch of bluetooth tests started failing with
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235


 
Labels: OS-Windows
There are 3 bluetooth-related CLs, 2 of them touch Windows-specific code. I will revert speculatively.
Cc: jdoerrie@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67ca5a07611f7b375f58f822364ce294a2d8b5fc

commit 67ca5a07611f7b375f58f822364ce294a2d8b5fc
Author: Christos Froussios <cfroussios@chromium.org>
Date: Thu Aug 02 08:02:09 2018

Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"

This reverts commit 20f64257cc9c09b466c4ae3944dbc165f83a9ae8.

Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg)

Original change's description:
> [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors
> 
> This change implements obtainining Remote Gatt Descriptors for WinRT by
> hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
> appropriate tests are enabled.
> 
> Bug:  821766 
> Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
> Reviewed-on: https://chromium-review.googlesource.com/1156392
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579830}

TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 ,  870208 
Reviewed-on: https://chromium-review.googlesource.com/1159943
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580106}
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_device_service_winrt.h

Cc: ortuno@chromium.org reillyg@chromium.org
 Issue 870210  has been merged into this issue.
Owner: jdoerrie@chromium.org
Status: Started (was: Available)
Cc: -cfroussios@google.com cfrouss...@chromium.com
Labels: -Sheriff-Chromium
The builder is green again after the reverts.
Cc: -cfrouss...@chromium.com cfroussios@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd

commit 9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Aug 02 15:29:48 2018

[Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set

BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of
std::set_union in order to merge advertised uuids and service uuids.
However, std::set_union requires sorted ranges as input, which wasn't
necessarily guaranteed before this change. When using a
std::unordered_set the order of elements is not specified and
std::set_union is not guaranteed to work correctly. Using a
base::flat_set for UUIDSet instead fixes this issue. In order to prevent
future regressions this change also replaces the usage of std::set_union
with base::STLSetUnion performing an explicit IsSorted() check in Debug
builds.

Bug:  821766 ,  870208 
Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0
Reviewed-on: https://chromium-review.googlesource.com/1159374
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580198}
[modify] https://crrev.com/9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd/device/bluetooth/bluetooth_device.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2632acba18473ed38a6d093e0f654aadcc0bea

commit be2632acba18473ed38a6d093e0f654aadcc0bea
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Thu Aug 02 15:37:55 2018

Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"

This reverts commit 67ca5a07611f7b375f58f822364ce294a2d8b5fc.

Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.

Original change's description:
> Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> 
> This reverts commit 20f64257cc9c09b466c4ae3944dbc165f83a9ae8.
> 
> Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg)
> 
> Original change's description:
> > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors
> > 
> > This change implements obtainining Remote Gatt Descriptors for WinRT by
> > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
> > appropriate tests are enabled.
> > 
> > Bug:  821766 
> > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
> > Reviewed-on: https://chromium-review.googlesource.com/1156392
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#579830}
> 
> TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 ,  870208 
> Reviewed-on: https://chromium-review.googlesource.com/1159943
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580106}

TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org

Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 ,  870208 
Reviewed-on: https://chromium-review.googlesource.com/1160901
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580200}
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_device_service_winrt.h

Landed the fix and relanded both original CLs. Let's see if the bots stay green.
Status: Fixed (was: Started)
Build 2254 contained the relands and passed device_unittests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2254

Thus marking this as fixed now.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bfa3b56405a9d622dd43939ee7c7ad4e777d760

commit 1bfa3b56405a9d622dd43939ee7c7ad4e777d760
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Thu Aug 02 20:53:40 2018

Revert "[Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set"

This reverts commit 9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd.

Reason for revert: Linux CFI and Android CFI both breaking on bluetooth tests after this landed:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9368
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2352

Original change's description:
> [Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set
> 
> BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of
> std::set_union in order to merge advertised uuids and service uuids.
> However, std::set_union requires sorted ranges as input, which wasn't
> necessarily guaranteed before this change. When using a
> std::unordered_set the order of elements is not specified and
> std::set_union is not guaranteed to work correctly. Using a
> base::flat_set for UUIDSet instead fixes this issue. In order to prevent
> future regressions this change also replaces the usage of std::set_union
> with base::STLSetUnion performing an explicit IsSorted() check in Debug
> builds.
> 
> Bug:  821766 ,  870208 
> Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0
> Reviewed-on: https://chromium-review.googlesource.com/1159374
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580198}

TBR=ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: I6e3ce514af12bc718a2b759d73086d24d3446c9b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 ,  870208 
Reviewed-on: https://chromium-review.googlesource.com/1161022
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580312}
[modify] https://crrev.com/1bfa3b56405a9d622dd43939ee7c7ad4e777d760/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/1bfa3b56405a9d622dd43939ee7c7ad4e777d760/device/bluetooth/bluetooth_device.h

Status: Assigned (was: Fixed)
This started failing again after the revert of #12.
Looks like we have to revert 3 more CLs to get it back to all-green state:

43db955e7da0 [Bluetooth][WinRT] Implement Subscribing to Notifications
ffac89b53cf4 Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
be2632acba18 Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c62545a1caf3dc17c5045a83094a73695371da6d

commit c62545a1caf3dc17c5045a83094a73695371da6d
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Aug 03 03:30:11 2018

Revert "[Bluetooth][WinRT] Implement Subscribing to Notifications"

This reverts commit 43db955e7da0a36e38823c84371ebac3b6eff326.

Reason for revert: Broka device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 

Original change's description:
> [Bluetooth][WinRT] Implement Subscribing to Notifications
> 
> This change implements subscribing to Gatt Notifications for WinRT and
> enables corresponding tests.
> 
> Bug:  821766 
> Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7
> Reviewed-on: https://chromium-review.googlesource.com/1156686
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580279}

TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: I8db3ae54ee129c51522a879bff6cad32431b6cb6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 , 870208 
Reviewed-on: https://chromium-review.googlesource.com/1161661
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580437}
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/BUILD.gn
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[delete] https://crrev.com/553ec6dab428099a9b73418e016c68f4d45edbf8/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.cc
[delete] https://crrev.com/553ec6dab428099a9b73418e016c68f4d45edbf8/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.h

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa8728a79dce84609c98f92911e862b6c7cf280

commit dfa8728a79dce84609c98f92911e862b6c7cf280
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Aug 03 03:34:50 2018

Revert "Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors""

This reverts commit ffac89b53cf458497a4f1b8022e9aaccc22495e2.

Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 

Original change's description:
> Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
> 
> This reverts commit d01b7c9e8df0568084a589486949a54ca82e89f1.
> 
> Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
> 
> Original change's description:
> > Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
> > 
> > This reverts commit f61df6f91aee2f8073ee409ab2ed624cd390931a.
> > 
> > Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change.
> > 
> > Sample builds:
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235
> > 
> > failures:
> > BluetoothTestWinrtOnly.GattServices_ObserversCalls/0
> > BluetoothTestWinrt.GetPrimaryServices/1
> > BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1
> > BluetoothTestWinrt.GetPrimaryServicesByUUID/1
> > BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0
> > BluetoothTestWinrt.GetGattServices_and_GetGattService/1
> > BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1
> > BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0
> > 
> > Original change's description:
> > > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors
> > > 
> > > This change implements reading and writing of Remote Gatt Descriptors
> > > for WinRT. Furthermore, it enables corresponding tests.
> > > 
> > > Bug:  821766 
> > > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe
> > > Reviewed-on: https://chromium-review.googlesource.com/1156703
> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#579838}
> > 
> > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > 
> > Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  821766 
> > Reviewed-on: https://chromium-review.googlesource.com/1159961
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580062}
> 
> TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 
> Reviewed-on: https://chromium-review.googlesource.com/1160902
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580201}

TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: I0b4eac30dd4f35b8fb275bed74d69f7b7b1b0f38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 , 870208 
Reviewed-on: https://chromium-review.googlesource.com/1161681
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580440}
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/fake_gatt_descriptor_winrt.h

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b050a38a869f3259cbef8c3862b7ad0c06f7f01e

commit b050a38a869f3259cbef8c3862b7ad0c06f7f01e
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Aug 03 03:38:45 2018

Revert "Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors""

This reverts commit be2632acba18473ed38a6d093e0f654aadcc0bea.

Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 

Original change's description:
> Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> 
> This reverts commit 67ca5a07611f7b375f58f822364ce294a2d8b5fc.
> 
> Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
> 
> Original change's description:
> > Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> > 
> > This reverts commit 20f64257cc9c09b466c4ae3944dbc165f83a9ae8.
> > 
> > Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg)
> > 
> > Original change's description:
> > > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors
> > > 
> > > This change implements obtainining Remote Gatt Descriptors for WinRT by
> > > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
> > > appropriate tests are enabled.
> > > 
> > > Bug:  821766 
> > > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
> > > Reviewed-on: https://chromium-review.googlesource.com/1156392
> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#579830}
> > 
> > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > 
> > Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  821766 ,  870208 
> > Reviewed-on: https://chromium-review.googlesource.com/1159943
> > Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> > Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580106}
> 
> TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 ,  870208 
> Reviewed-on: https://chromium-review.googlesource.com/1160901
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580200}

TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org

Change-Id: I9bd3f94b1be3b58b7975e1e57dff09cd7a9c2910
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 ,  870208 
Reviewed-on: https://chromium-review.googlesource.com/1161682
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580442}
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_device_service_winrt.h

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/922ae26be08b68e6ffc18509a8e37f0f3da2aa6d

commit 922ae26be08b68e6ffc18509a8e37f0f3da2aa6d
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Aug 03 14:00:18 2018

Reland "[Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set"

This is a reland of 9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd

In order to address the CFI failures [1,2] causing the revert of the
initial CL, this change also de-virtualizes BluetoothUUID. BluetoothUUID
has no subclasses and is meant to use as a value type, which is why a virtual
destructor does not make sense.

[1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9368
[2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2352

Original change's description:
> [Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set
>
> BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of
> std::set_union in order to merge advertised uuids and service uuids.
> However, std::set_union requires sorted ranges as input, which wasn't
> necessarily guaranteed before this change. When using a
> std::unordered_set the order of elements is not specified and
> std::set_union is not guaranteed to work correctly. Using a
> base::flat_set for UUIDSet instead fixes this issue. In order to prevent
> future regressions this change also replaces the usage of std::set_union
> with base::STLSetUnion performing an explicit IsSorted() check in Debug
> builds.
>
> Bug:  821766 ,  870208 
> Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0
> Reviewed-on: https://chromium-review.googlesource.com/1159374
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580198}

TBR=ortuno@chromium.org

Bug:  821766 ,  870208 
Change-Id: I3fc55939ff5b8b136db0d45978c5b19083adb1d9
Reviewed-on: https://chromium-review.googlesource.com/1161883
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580530}
[modify] https://crrev.com/922ae26be08b68e6ffc18509a8e37f0f3da2aa6d/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/922ae26be08b68e6ffc18509a8e37f0f3da2aa6d/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/922ae26be08b68e6ffc18509a8e37f0f3da2aa6d/device/bluetooth/bluetooth_uuid.h

I will wait with relanding the other CLs just in case another failure pops up. If r580530 didn't get reverted until Monday, I will reland the remaining CLs.
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4

commit 7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Mon Aug 06 09:06:57 2018

Reland "Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors""

This reverts commit b050a38a869f3259cbef8c3862b7ad0c06f7f01e.

Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by this CL.

Original change's description:
> Revert "Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors""
> 
> This reverts commit be2632acba18473ed38a6d093e0f654aadcc0bea.
> 
> Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 
> 
> Original change's description:
> > Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> > 
> > This reverts commit 67ca5a07611f7b375f58f822364ce294a2d8b5fc.
> > 
> > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
> > 
> > Original change's description:
> > > Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> > > 
> > > This reverts commit 20f64257cc9c09b466c4ae3944dbc165f83a9ae8.
> > > 
> > > Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg)
> > > 
> > > Original change's description:
> > > > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors
> > > > 
> > > > This change implements obtainining Remote Gatt Descriptors for WinRT by
> > > > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
> > > > appropriate tests are enabled.
> > > > 
> > > > Bug:  821766 
> > > > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
> > > > Reviewed-on: https://chromium-review.googlesource.com/1156392
> > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#579830}
> > > 
> > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > > 
> > > Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug:  821766 ,  870208 
> > > Reviewed-on: https://chromium-review.googlesource.com/1159943
> > > Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> > > Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#580106}
> > 
> > TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org
> > 
> > Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  821766 ,  870208 
> > Reviewed-on: https://chromium-review.googlesource.com/1160901
> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580200}
> 
> TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I9bd3f94b1be3b58b7975e1e57dff09cd7a9c2910
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 ,  870208 
> Reviewed-on: https://chromium-review.googlesource.com/1161682
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580442}

TBR=reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  821766 ,  870208 
Change-Id: I29824289cbd23722a5e0397f07f40b62769549d4
Reviewed-on: https://chromium-review.googlesource.com/1163382
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580828}
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_device_service_winrt.h

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad

commit d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Mon Aug 06 10:15:45 2018

Reland "Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors""

This reverts commit dfa8728a79dce84609c98f92911e862b6c7cf280.

Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by a CL this one depended on.

Original change's description:
> Revert "Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors""
> 
> This reverts commit ffac89b53cf458497a4f1b8022e9aaccc22495e2.
> 
> Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 
> 
> Original change's description:
> > Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
> > 
> > This reverts commit d01b7c9e8df0568084a589486949a54ca82e89f1.
> > 
> > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
> > 
> > Original change's description:
> > > Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
> > > 
> > > This reverts commit f61df6f91aee2f8073ee409ab2ed624cd390931a.
> > > 
> > > Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change.
> > > 
> > > Sample builds:
> > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242
> > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240
> > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236
> > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235
> > > 
> > > failures:
> > > BluetoothTestWinrtOnly.GattServices_ObserversCalls/0
> > > BluetoothTestWinrt.GetPrimaryServices/1
> > > BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1
> > > BluetoothTestWinrt.GetPrimaryServicesByUUID/1
> > > BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0
> > > BluetoothTestWinrt.GetGattServices_and_GetGattService/1
> > > BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1
> > > BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0
> > > 
> > > Original change's description:
> > > > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors
> > > > 
> > > > This change implements reading and writing of Remote Gatt Descriptors
> > > > for WinRT. Furthermore, it enables corresponding tests.
> > > > 
> > > > Bug:  821766 
> > > > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe
> > > > Reviewed-on: https://chromium-review.googlesource.com/1156703
> > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#579838}
> > > 
> > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > > 
> > > Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug:  821766 
> > > Reviewed-on: https://chromium-review.googlesource.com/1159961
> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#580062}
> > 
> > TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > 
> > Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  821766 
> > Reviewed-on: https://chromium-review.googlesource.com/1160902
> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580201}
> 
> TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I0b4eac30dd4f35b8fb275bed74d69f7b7b1b0f38
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 , 870208 
> Reviewed-on: https://chromium-review.googlesource.com/1161681
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580440}

TBR=kinuko@chromium.org,reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  821766 ,  870208 
Change-Id: Icaf844c0c0aa72ab38db3e834df3100088339f1b
Reviewed-on: https://chromium-review.googlesource.com/1163384
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580837}
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/fake_gatt_descriptor_winrt.h

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9

commit e0029d1291f50cbccfa89e44d53b9ee80f5e77f9
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Mon Aug 06 14:06:08 2018

Reland "[Bluetooth][WinRT] Implement Subscribing to Notifications"

This reverts commit c62545a1caf3dc17c5045a83094a73695371da6d.

Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by a CL this one depended on.

Original change's description:
> Revert "[Bluetooth][WinRT] Implement Subscribing to Notifications"
> 
> This reverts commit 43db955e7da0a36e38823c84371ebac3b6eff326.
> 
> Reason for revert: Broka device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 
> 
> Original change's description:
> > [Bluetooth][WinRT] Implement Subscribing to Notifications
> > 
> > This change implements subscribing to Gatt Notifications for WinRT and
> > enables corresponding tests.
> > 
> > Bug:  821766 
> > Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7
> > Reviewed-on: https://chromium-review.googlesource.com/1156686
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580279}
> 
> TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I8db3ae54ee129c51522a879bff6cad32431b6cb6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 , 870208 
> Reviewed-on: https://chromium-review.googlesource.com/1161661
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580437}

TBR=reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  821766 ,  870208 
Change-Id: Ic15f662b5c221d675edad297224a8643d52f496a
Reviewed-on: https://chromium-review.googlesource.com/1162123
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580861}
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/BUILD.gn
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[add] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.cc
[add] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.h

Status: Fixed (was: Assigned)

Sign in to add a comment