New issue
Advanced search Search tips

Issue 870205 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : Cookies details list unexpectedly expands and collapses while selecting the text.

Reported by avsha...@etouch.net, Aug 2

Issue description

Chrome Version : 70.0.3510.0 (Official Build) 1a6253886c7f5a78dc4e34f73371d56dd07595b5-refs/branch-heads/3510@{#1} 32/64 bit
OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.14, 10.13.6)

Precondition : Navigate to few web pages to generate some cookies in content settings sub-page.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings/siteData 
2. Click on the first site entry (page navigates to cookies sub-page)
3. Now try to select the text of first entry using mouse click and drag over the text.
4. Observe the details section.

Actual Result : Cookies details list unexpectedly expands and collapses while selecting the text.

Expected Result : Cookies details section should not expand or collapse while selecting the text.

This is a regression issue broken in ‘M-69’ and below is the bisect info:
Good Build : 69.0.3444.0 (Revision : 562314)
Bad Build : 69.0.3445.0 (Revision : 562690)

(Unable to narrow down the range using per-revision bisect, hence providing bisect using old script)

Narrow bisect URL :
https://chromium.googlesource.com/chromium/src/+log/a4f64484f29611d079cb54f591fb91643138707d..fba7635322a3be23675c78c01b5eb22b5dfd20cb

Suspecting : r562659 ?

Hector@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
 
Actual_Result.mp4
411 KB View Download
Expected_Result.mp4
343 KB View Download
Cc: pbomm...@chromium.org
Labels: ReleaseBlock-Stable
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Friendly ping! Could you please provide any update on this issue as it has been marked as a stable blocker.

Thank You!
Status: Started (was: Assigned)
Sorry, I missed this. Taking a look right now.
Owner: aee@chromium.org
Status: Assigned (was: Started)
Suspecting https://crrev.com/c/1069718

aee@ can you PTAL?
Labels: -Pri-1 Pri-3
Status: Started (was: Assigned)
M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
Labels: -ReleaseBlock-Stable
I compared this with the expand button with label in the language section. The actual result is consistent with selecting the text in other labels. I noticed one difference. The label has an actionable attribute which shows a pointer for the cursor. 

In most places in settings when selecting text in a label for a control, the control action is taken (links, toggles, and expansion).

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d6f04d4a269351dcb2597a1712d100c001a3c28

commit 7d6f04d4a269351dcb2597a1712d100c001a3c28
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Mon Aug 13 23:58:26 2018

Settings: cr-expand-button, use pointer cursor for label

The label when clicked toggles expansion. The bug as reported was
selecting the label text causes expansion. Without the pointer cursor
it's surprising to the user that an action will be taken while clicking
on the label text during selection. The problem is the surprising
expansion and not the expansion on clicking the text.

Bug:  870205 
Change-Id: I5c5200f54a54bba50cb6fc67c668b8d298b98c94
Reviewed-on: https://chromium-review.googlesource.com/1166216
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582755}
[modify] https://crrev.com/7d6f04d4a269351dcb2597a1712d100c001a3c28/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
[modify] https://crrev.com/7d6f04d4a269351dcb2597a1712d100c001a3c28/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.js

Labels: TE-Verified-M70 TE-Verified-70.0.3522.0
Update :
-------
Tested above issue in latest Canary build #70.0.3522.0 on Mac(10.12.6, 10.13.1 ,10.13.6, 10.14), Windows(7, 8, 8.1, 10) and Linux(14.04 LTS) OS and the issue is fixed. 
Now 'hand pointer' is seen when user is selecting the label text and the expansion action is taken (which is expected now due to the hand pointer). 
This behavior now matches with the behavior of most of places in setting page when selecting a label text.

This is working as intended as per the commit: https://chromium.googlesource.com/chromium/src.git/+/7d6f04d4a269351dcb2597a1712d100c001a3c28

Hence adding TE-Verified labels, kindly review an attached screen-cast for reference.

Thank you..!
Canary_build_behaviour.mp4
317 KB View Download
Status: Verified (was: Started)

Sign in to add a comment