New issue
Advanced search Search tips

Issue 870202 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : [Settings] Tooltip is seen chopped on mouse hovering on iron-icon

Reported by pranjali...@etouch.net, Aug 2

Issue description

Chrome version : 70.0.3509.0 (Official Build)  3696a8e82d75671fe1c391a5496e6718a54c4fc7-refs/branch-heads/3509@{#1}(32/64 bit)

OS:  Windows(7,8,8.1.10) ,Linux(14.04 LTS)  and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14).

What steps will reproduce the problem?
1.Launch chrome and navigate to ' chrome://settings/content/notifications'.
2. Now mouse hover on iron-icon and observe.

Actual  : Tooltip is seen chopped on mouse hovering on iron-icon in ' chrome://settings/content/notifications'
Expected: Tooltip should not be seen chopped on mouse hovering on iron-icon in' chrome://settings/content/notifications'

This is a regression issue broken in ‘M-70’ and using per-revision bisect providing the bisect results,
Good Build : 70.0.3501.0
Bad Build: 70.0.3502.0

You are probably looking for a change made after 577742 (known good), but no later than 577743 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/b3d2f01439976295d1a529f29f2dd7ebe4482caf..fc566d1c1a2d8da82ccce610b153f3b54524eab4

Suspect: https://chromium.googlesource.com/chromium/src/+/fc566d1c1a2d8da82ccce610b153f3b54524eab4

aee@Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Unwanted scrollbar is also seen after hovering mouse on iron-icon.

Thank You!
 
Actual Result.mp4
238 KB View Download
Expected Result.mp4
219 KB View Download
Status: Started (was: Assigned)
Screenshots for CL https://chromium-review.googlesource.com/c/chromium/src/+/1168144.
tooltip_cuttoff_long_list.png
82.0 KB View Download
tooltip_working_long_list.png
79.6 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ed906898265932c23a17a297ddcc241d46826d1

commit 2ed906898265932c23a17a297ddcc241d46826d1
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Aug 10 19:33:50 2018

Settings: site-list, set iron-list display to contents so tooltips are not cutoff

Bug:  870202 
Change-Id: Id1afc62ba99ce648068b773e900f1373413cb8d7
Reviewed-on: https://chromium-review.googlesource.com/1168144
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582287}
[modify] https://crrev.com/2ed906898265932c23a17a297ddcc241d46826d1/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/2ed906898265932c23a17a297ddcc241d46826d1/chrome/browser/resources/settings/site_settings/site_list.js

Status: Fixed (was: Started)
Update:
------

Retested this issue in latest Canary build #70.0.3521.0 on Windows(7,8,8.1.10), Linux(14.04 LTS) & Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and the Tool-tip is still not visible completely. In tooltip, "by an" text is still not visible. Please review an attached screenshot of the Tool-tip.

Thank you..!
Canary_behaviour.mp4
264 KB View Download
Tooltip.png
31.4 KB View Download
Cc: ligim...@chromium.org
Status: Assigned (was: Fixed)
Assigning back to owner since the issue is not fixed.
Status: Started (was: Assigned)
Screenshot for https://chromium-review.googlesource.com/c/chromium/src/+/1176586.
policy_tooltip.png
45.2 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/508ebd69e877434b4966b33a702fe389566244d7

commit 508ebd69e877434b4966b33a702fe389566244d7
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Aug 23 04:10:55 2018

Settings: site-list, use common tooltip to avoid entry tooltip from being cut off

Bug:  870202 
Change-Id: Iaa3c6ebcfc62636a7343b2d0720aaef710a60208
Reviewed-on: https://chromium-review.googlesource.com/1176586
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585393}
[modify] https://crrev.com/508ebd69e877434b4966b33a702fe389566244d7/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/508ebd69e877434b4966b33a702fe389566244d7/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/508ebd69e877434b4966b33a702fe389566244d7/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/508ebd69e877434b4966b33a702fe389566244d7/chrome/browser/resources/settings/site_settings/site_list_entry.html
[modify] https://crrev.com/508ebd69e877434b4966b33a702fe389566244d7/chrome/browser/resources/settings/site_settings/site_list_entry.js
[modify] https://crrev.com/508ebd69e877434b4966b33a702fe389566244d7/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/508ebd69e877434b4966b33a702fe389566244d7/chrome/test/data/webui/settings/site_list_entry_tests.js
[modify] https://crrev.com/508ebd69e877434b4966b33a702fe389566244d7/chrome/test/data/webui/settings/site_list_tests.js

Status: Fixed (was: Started)

Sign in to add a comment