New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870193 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Fix potential sigsev error during WebAuthN UI dialog flow

Project Member Reported by hongjunchoi@chromium.org, Aug 2

Issue description

Fix potential nullptr de-reference while setting FidoRequestHandler as observer for UI components.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/644319ebc83e8919a061afc9f449f8edcd7dd0b4

commit 644319ebc83e8919a061afc9f449f8edcd7dd0b4
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Thu Aug 02 19:06:31 2018

Fix nullptr deference in FidoRequestHandlerBase

Bug:  870193 
Change-Id: Ie7131514e1cf45f958dca11df8a142ea92440cad
Reviewed-on: https://chromium-review.googlesource.com/1159992
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580276}
[modify] https://crrev.com/644319ebc83e8919a061afc9f449f8edcd7dd0b4/device/fido/fido_request_handler_base.cc

Labels: Merge-Request-69
Requesting merge of https://chromium-review.googlesource.com/c/chromium/src/+/1159992 to M69. 
Status: Fixed (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 3

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
How is the change listed at #2 looking in canary? Also could you pls justify the merge to M69? Is this regressed in M69?
Labels: -Hotlist-Merge-Review -M-69 -Merge-Review-69 M-70
Removing merge review label as is not critical for M69. 
Jun, just to double-check: we never have an |observer_| unless the UI is enabled by command line flags, right?

Sign in to add a comment