New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870186 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Aug 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[PIP] Close icon should be one size regardless of window size.

Project Member Reported by apaci...@chromium.org, Aug 2

Issue description

Close icon should be only the small size, rather than scaling depending on the size of the window.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/158b343fd882e310b16ae9c35b6dd9d28b3c4087

commit 158b343fd882e310b16ae9c35b6dd9d28b3c4087
Author: Jennifer Apacible <japacible@gmail.com>
Date: Thu Aug 02 17:42:13 2018

[Picture in Picture] Make close button fixed size.

This change updates the close button to be a fixed size regardless of
the window size.

Bug:  870186 
Change-Id: Ib9de9508cef6f1faea272be7a223a15e86d7ac87
Reviewed-on: https://chromium-review.googlesource.com/1159987
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580237}
[modify] https://crrev.com/158b343fd882e310b16ae9c35b6dd9d28b3c4087/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/158b343fd882e310b16ae9c35b6dd9d28b3c4087/chrome/browser/ui/views/overlay/overlay_window_views.h

Labels: Merge-Request-69
Labels: TE-Verified-70.0.3511.0 TE-Verified-M70
Able to reproduce this issue on reported version hence verifying the fix on latest canary 70.0.3511.0 using Windows 10,Mac 10.13.6,Debian.

Now close icon is in fixed size regardless of window size.

As fix is working as expected adding Verified labels.

Thanks!
Aug 3 2018 3_02 PM.webm
2.3 MB View Download
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 3

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge your change to M69 branch 3497 by 4:00 PM PT, Monday (08/06) so we can pick it up for next week M69 beta release. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 6

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efe11a7a01e03b6702af248fdcc3d1ce46a63b49

commit efe11a7a01e03b6702af248fdcc3d1ce46a63b49
Author: Jennifer Apacible <japacible@gmail.com>
Date: Mon Aug 06 19:13:53 2018

[Picture in Picture] Make close button fixed size.

This change updates the close button to be a fixed size regardless of
the window size.

Bug:  870186 
Change-Id: Ib9de9508cef6f1faea272be7a223a15e86d7ac87
Reviewed-on: https://chromium-review.googlesource.com/1159987
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580237}(cherry picked from commit 158b343fd882e310b16ae9c35b6dd9d28b3c4087)
Reviewed-on: https://chromium-review.googlesource.com/1163967
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#427}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/efe11a7a01e03b6702af248fdcc3d1ce46a63b49/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/efe11a7a01e03b6702af248fdcc3d1ce46a63b49/chrome/browser/ui/views/overlay/overlay_window_views.h

Labels: TE-Verified-M69 TE-Verified-69.0.3497.32
Able to reproduce this issue on reported version hence verifying the fix on latest beta # 69.0.3497.32 using Windows 10,Mac 10.13.6,Debian.

Now close icon is in fixed size regardless of window size.

As fix is working as expected adding Verified labels.

Thanks!
Closeicon_withfix_M69.webm
3.1 MB View Download
Status: Fixed (was: Started)

Sign in to add a comment