Issue 871693  has been merged into this issue.

Run all existing tests with OOR-CORS and Servicified Service Worker enabled,
https://chromium-review.googlesource.com/c/chromium/src/+/1163547,
and classify failure cases (layout test failures are ignored this time, since we have tracked them in virtual tests).

https://docs.google.com/document/d/1H6K5zjosoVWjQunO1tDSAzv6dlu5Vg0hJ3fZQua2_d0/edit?usp=sharing

In short, all failed tests can be roughly classified into following cases. First two cases dominate.

- CORS requests from Chrome Extensions are blocked unexpectedly
- Polymer load fails and can not start testing (html import related?)

- File access is blocked unexpectedly
- CORS requests from PPAPI are blocked unexpectedly
- Unknown timeout (needs further investigation)
- CORS related flag does not work
  + CORS disabler (--disable-web-sercurity)
  + File access enabler (--allow-file-access)
- CHECK failures
  + in CORSURLLoader redirect logic
  + IO thread check
- RANGE header is not permitted by CORS
- Save-Data header disappears in SW
- Different net error (ERR_ABORTED vs ERR_FAILED)
- unexpected network request completion

- failures due to Servicified Service Worker (we'll ignore them at this moment)

"Different net error (ERR_ABORTED vs ERR_FAILED)" comes from mojo connection between CORSURLLoader and network::URLLoader (or MojoAsyncResourceHandler). I'll fix the issue.

The first one will be fixed by 870172.

I will investigate more clear reason why the second case, Polymer load failures, happens to file another dedicated bug for that.

Other cases look minor issues, only a few tests failing.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c

commit 43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Aug 08 07:37:45 2018

[OOR-CORS] Implement redirect location checks

This CL:
 - fixes CheckRedirectLocation implementation so that we can use it
   from CORSURLLoader.
 - fixes CORS flag handling in ResourceLoader so that it can use
   CheckRedirectLocation,
 - removes WebCORS::HandleRedirect, and has it implemented in
   blink::ResourceLoader instead,
 - integrates CheckRedirectLocation with CORSURLLoader, and
 - removes mojom::CORSError::kRedirectDisallowedScheme in favor of
   mojom::CORSError::kCORSDisabledScheme.

Bug: 736308,  800669 , 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib31ab135b03dcc0beca137cbc39592fe3f314790
Reviewed-on: https://chromium-review.googlesource.com/1158089
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581495}
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/public/cpp/cors/cors.h
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/public/cpp/cors/cors_unittest.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/public/mojom/cors.mojom
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/public/platform/web_cors.h
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/core/loader/threadable_loader.h
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/exported/web_cors.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/cors/cors.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/cors/cors.h
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/fetch/resource_loader.h

Polymer failure cases was due to import failures from chrome:// scheme.
Scheme whitelist may fix this issue too, or need something additional for html import. I will work on whitelist impl. first.

Note: the request to chrome:// are made by an internal extension for the PDF viewer.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/665678831244e8216f01b92e357cad997c3347cb

commit 665678831244e8216f01b92e357cad997c3347cb
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Aug 31 03:40:31 2018

[CORS] Fix credentials flag handling

CORSURLLoaderFactory rejects a request whose credentials mode and
load flags contradict each other. The load flags rely on
blink::ResourceRequest::allow_stored_credentials_, so let's configure
the member when out-of-blink CORS is enabled.

Now we have response tainting, so use it to configure load_flags. This
changes the existing behavior (even when out-of-blink CORS is
disabled), which leads to test changes. See
https://github.com/whatwg/fetch/issues/169 for the corresponding spec
change.

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I8163ce45780b0b6bf9e8ee61e8bee0c433ea0967
Reviewed-on: https://chromium-review.googlesource.com/1174080
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587937}
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/services/network/public/cpp/cors/cors.h
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/auth-nocors.js
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/cookie-nocors.js
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/third_party/blink/renderer/platform/loader/cors/cors.cc
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/third_party/blink/renderer/platform/loader/cors/cors.h
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/665678831244e8216f01b92e357cad997c3347cb/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5825804e1054dff6b812fa9df63c16777ad827a9

commit 5825804e1054dff6b812fa9df63c16777ad827a9
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Aug 31 05:29:26 2018

Do not set CORS flag for data URLs

The fetch spec says data URLs should be treated as same-origin, but
currently Chrome treats it as cross-origin, and attaches
"access-control-allow-origin: *" to every response to a request to
data URLs. Let's align with the spec. See [1] for details.

There are some modules using FetchRequestMode::kSameOrigin for which
it's not obvious whether handling data URLs as same-origin is correct.

 1. SVG
   - a. ExternalSVGResource::Load
   - b. SVGUseElement::UpdateTargetReference
 2. XSLT
   - a. XSLStyleSheet::LoadChildSheet
   - b. DocLoaderFunc

2a is not affected by this change because of LibXSLT implementation.
For 2b I wrote a test. The test result is aligned with Firefox.

1: https://docs.google.com/document/d/1_BD15unoPJVwKyf5yOUDu5kie492TTaBxzhJ58j1rD4/edit

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_mojo;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I666c9cb46c83e0e6b290e03b5b999db501c20541
Reviewed-on: https://chromium-review.googlesource.com/1160126
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587950}
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/net/url_request/url_request_data_job.cc
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/net/url_request/url_request_data_job_unittest.cc
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/9c69a18d9bd3ba49ba14a8b28559f0a3c66408a5/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-data-url-expected.txt
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/WebKit/LayoutTests/external/wpt/xhr/data-uri-expected.txt
[add] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/WebKit/LayoutTests/http/tests/security/data-url-xsl-expected.txt
[add] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/WebKit/LayoutTests/http/tests/security/data-url-xsl.html
[add] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/WebKit/LayoutTests/http/tests/security/resources/data-url-xsl.xml
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/blink/renderer/core/loader/threadable_loader.h
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/blink/renderer/platform/loader/cors/cors.cc
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/blink/renderer/platform/loader/cors/cors.h
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9/third_party/blink/renderer/platform/weborigin/security_origin.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/312341022f3038960dd947d316104fd638b88871

commit 312341022f3038960dd947d316104fd638b88871
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Aug 31 06:21:05 2018

Follow up on stopping setting CORS flag for data URLs

 - Replace |url.ProtocolIsData() || origin->CanRequest(url)|
   with |origin->CanReadContent(url)|.
 - Remove cross-origin settings for data URLs in workers as data URLs
   are now considered as same-origin.

This is a follow up for [1].

1: https://chromium-review.googlesource.com/c/chromium/src/+/1160126

Bug: 870173
Change-Id: Ie95e82c57882e4ce7d52e8ab0607c81e4b18c171
Reviewed-on: https://chromium-review.googlesource.com/1177472
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587955}
[modify] https://crrev.com/312341022f3038960dd947d316104fd638b88871/third_party/blink/renderer/core/execution_context/execution_context.cc
[modify] https://crrev.com/312341022f3038960dd947d316104fd638b88871/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/312341022f3038960dd947d316104fd638b88871/third_party/blink/renderer/core/workers/abstract_worker.cc
[modify] https://crrev.com/312341022f3038960dd947d316104fd638b88871/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/312341022f3038960dd947d316104fd638b88871/third_party/blink/renderer/platform/loader/cors/cors.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/449e22adadca12253abd8580af2db21963753aec

commit 449e22adadca12253abd8580af2db21963753aec
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Sep 05 05:49:26 2018

OOR-CORS: Add navigation and security tests to virtual LayoutTests suites

There are some tests that call testRunner.addOriginAccessAllowListEntry
even in navigation and security test directories.

They are expected to call it to bypass renderer-side security checks,
but let me run them in our outofblink-cors(-ns) virtual environments
just in case.

Also the security directory seems to contain many relevant tests
that rely on CORS check on ResourceFetcher.

Bug:  870172 , 870173,  879991 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_mojo
Change-Id: I55c75b6766da6b98c7a2d816fbcfec555d181b68
Reviewed-on: https://chromium-review.googlesource.com/1193524
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588773}
[modify] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=HeapIncrementalMarkingStress
[modify] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
[modify] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/LeakExpectations
[modify] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/navigation/README.txt
[add] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/security/README.txt
[add] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/navigation/README.txt
[add] https://crrev.com/449e22adadca12253abd8580af2db21963753aec/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/security/README.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9512f17e65f185abcbfce0a30ecbeeac728753bc

commit 9512f17e65f185abcbfce0a30ecbeeac728753bc
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Sep 05 06:56:42 2018

Keep upload notification settings across redirects

ThreadableLoader re-creates the request on redirect for some cases. We
need to remember whether we need notification for uploading.

Bug: 870173
Change-Id: Ic7e4847c4d4c9facb57cd09cb85b04ca78ddfca7
Reviewed-on: https://chromium-review.googlesource.com/1206170
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588784}
[modify] https://crrev.com/9512f17e65f185abcbfce0a30ecbeeac728753bc/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/third_party/WebKit/LayoutTests/external/wpt/xhr/event-upload-progress-crossorigin-expected.txt
[delete] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/third_party/WebKit/LayoutTests/external/wpt/xhr/event-upload-progress-expected.txt
[modify] https://crrev.com/9512f17e65f185abcbfce0a30ecbeeac728753bc/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/9512f17e65f185abcbfce0a30ecbeeac728753bc/third_party/blink/renderer/core/loader/threadable_loader.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81951e6fa514dbdc48e3b4a7deaa25d2507b34d5

commit 81951e6fa514dbdc48e3b4a7deaa25d2507b34d5
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Sep 05 07:38:06 2018

[OOR-CORS] Update TestExpectations

 - send-redirect-bogus-sync.htm is not failing any more. Remove the
   entries.
 - send-authentication-existing-session-manual.htm and
   send-authentication-prompt-2-manual.htm are listed in
   NeverFixTests. Move the virtual/outoblink-cors[-ns] entries to the
   file as well.

Bug: 870173
Change-Id: I6c94bb6b3559727133b94a1915f0b8cc89705525
Reviewed-on: https://chromium-review.googlesource.com/1206052
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588787}
[modify] https://crrev.com/81951e6fa514dbdc48e3b4a7deaa25d2507b34d5/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/81951e6fa514dbdc48e3b4a7deaa25d2507b34d5/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/81951e6fa514dbdc48e3b4a7deaa25d2507b34d5/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dcf14e40129f98f4bd64c98e5c78830fc11d49b

commit 2dcf14e40129f98f4bd64c98e5c78830fc11d49b
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Sep 05 07:46:41 2018

[OOR-CORS] Reset request body on 301/302/303 redirect

On 301/302/303 redirect, we may change the request method to "GET".
While that is done by net/ logic, we need to reset the body manually
in CORSURLLoader for some cases.

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id864729a8adaa29af52bc4e7d8c3455b57e2528c
Reviewed-on: https://chromium-review.googlesource.com/1205974
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588789}
[modify] https://crrev.com/2dcf14e40129f98f4bd64c98e5c78830fc11d49b/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/2dcf14e40129f98f4bd64c98e5c78830fc11d49b/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2592c9eaa7ec5f8406c0a95e41c54f456b03c3ad

commit 2592c9eaa7ec5f8406c0a95e41c54f456b03c3ad
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Sep 12 09:44:36 2018

TestExpectations: A flaky test is so not only on Win7, but also on Win10

rename-subframe-goback.html was marked for Win7, but it is flaky
even on Win10 for newly added virtual tests. Since this should not
be a feature specific, let's change it mark for Win so to affect
Win10 too.

See also Findit's comment on a CL below.
https://chromium-review.googlesource.com/c/chromium/src/+/1193524

Bug:  855816 , 870173
Change-Id: I3fdc95e335fcd42b88be6957151e59c92563c5dd
Tbr: yhirano@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1220952
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590629}
[modify] https://crrev.com/2592c9eaa7ec5f8406c0a95e41c54f456b03c3ad/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2120864fc526adf9cf1d296eb54b7286d5478d2

commit f2120864fc526adf9cf1d296eb54b7286d5478d2
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Sep 18 05:55:38 2018

OOR-CORS: Fix SearchProviderTest to use TestURLLoaderFactory always

Current KeywordOrderingAndDescriptions test does not use
TestURLLoaderFactory and it results in making actual network
requests. This causes a DCHECK failure that says network code
runs not on the IO thread. This does not actually happen on TOT,
but when OOR-CORS feature is enabled, it happens.

This patch makes the test use TestAutocompleteProviderClient
instead of ChromeAutocompleteProviderClient so to use
TestURLLoaderFactory that avoid making actual requests.

Bug: 870173
Change-Id: Ifb02d36b3c9be35c99037350e9676a671f948f6f
Reviewed-on: https://chromium-review.googlesource.com/1226672
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591952}
[modify] https://crrev.com/f2120864fc526adf9cf1d296eb54b7286d5478d2/chrome/browser/autocomplete/search_provider_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75

commit 1415b5f0a7e468d91bdc8ce518a4df04f05b2e75
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Sep 19 05:45:57 2018

Layout tests should not rely on file URL's universal access on CORS

Layout tests run with "AllowUniversalAccessFromFileURLs" which grants
universal access to file: origins. This CL modifies layout tests
relying on the settings *for CORS* as out-of-blink CORS doesn't support
the settings.

This is basically done by adding "access-control-allow-access: *" to
a lot of resources.

Bug: 870173
Change-Id: Ie38eba9674419786e1acd2a0e12e172bea6ebb1e
Reviewed-on: https://chromium-review.googlesource.com/1224151
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592326}
[add] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/devtools/.htaccess
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-expected.txt
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging.js
[add] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/devtools/resources/cors-disabled/.htaccess
[add] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/devtools/resources/cors-disabled/xhr-exists.html
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/resources/file-last-modified.php
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/resources/post-and-verify-hybrid.cgi
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/resources/post-and-verify.cgi
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/resources/reset-temp-file.php
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/resources/touch-temp-file.php
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/resources/write-temp-file.php
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/resources/multipart-post-echo-filenames.php
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/resources/multipart-post-echo.php
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/resources/post-echo.cgi
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/resources/post-echo.php
[modify] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/blink/renderer/devtools/BUILD.gn
[add] https://crrev.com/1415b5f0a7e468d91bdc8ce518a4df04f05b2e75/third_party/blink/renderer/devtools/htaccess

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87b74c7ed39458b89b8d0ab343181b95ca88b113

commit 87b74c7ed39458b89b8d0ab343181b95ca88b113
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Sep 21 07:24:04 2018

[CORS] Fix "too many redirects" error message in ThreadableLoader

Bug: 870173
Change-Id: I4217a9700239bbb736f7442c20e5fba9d68b4fd9
Reviewed-on: https://chromium-review.googlesource.com/1233275
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593099}
[modify] https://crrev.com/87b74c7ed39458b89b8d0ab343181b95ca88b113/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/87b74c7ed39458b89b8d0ab343181b95ca88b113/third_party/WebKit/LayoutTests/http/tests/fetch/chromium/error-messages-expected.txt
[modify] https://crrev.com/87b74c7ed39458b89b8d0ab343181b95ca88b113/third_party/WebKit/LayoutTests/http/tests/fetch/chromium/error-messages.html
[modify] https://crrev.com/87b74c7ed39458b89b8d0ab343181b95ca88b113/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/87b74c7ed39458b89b8d0ab343181b95ca88b113/third_party/blink/renderer/core/loader/threadable_loader.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdf9d6d3fd8a088aaa6fb180886fccc09886689a

commit fdf9d6d3fd8a088aaa6fb180886fccc09886689a
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Sep 25 06:20:15 2018

OOR-CORS: Use net::ERR_ABORTED on OnConnectionError

Currently, some tests expect it does not complete, and others do
returning net::ERR_ABORTED. But it's really tough to realize the
same behavior when OutOfBlinkCORS is enabled because timing differs.

With this fix, CORSURLLoader is changed to return net::ERR_ABORTED
on OnConnectionError that happens when a client destructs a loader.

Existing tests that expect it does not complete are also modified
to check if it does not complete or it completes with the error.

This patch will make tests below pass even with OutOfBlinkCORS enabled.
- ResourceDispatcherHostTest.DataSentBeforeDetach
- ResourceDispatcherHostTest.Cancel
- ResourceDispatcherHostTest.DetachedResourceTimesOut
- ResourceDispatcherHostTest.TestBlockedRequestsProcessDies
- ResourceDispatcherHostTest.TestBlockingCancelingRequests

Bug:  872634 , 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I2f7f40de49d5820413eaf4e80debf747ba66632a
Reviewed-on: https://chromium-review.googlesource.com/1230039
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593836}
[modify] https://crrev.com/fdf9d6d3fd8a088aaa6fb180886fccc09886689a/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/fdf9d6d3fd8a088aaa6fb180886fccc09886689a/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/fdf9d6d3fd8a088aaa6fb180886fccc09886689a/services/network/test/test_url_loader_client.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd172dba7f30f6d5cc4139b86b20dd5ce3acda61

commit cd172dba7f30f6d5cc4139b86b20dd5ce3acda61
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Sep 25 06:28:00 2018

Do not use about:blank in javascript-detached-frame-no-crash.html

Currently the test is working because CORS is disabled due to the
AllowUniversalAccessFromFileURLs setting. We will not be able to rely on
the setting with out-of-blink CORS, so let's use an empty file rather
than about:blank.

Bug: 870173
Change-Id: I4317b29d462d5377a54618201c29f769daafd6ce
Reviewed-on: https://chromium-review.googlesource.com/1235777
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593838}
[add] https://crrev.com/cd172dba7f30f6d5cc4139b86b20dd5ce3acda61/third_party/WebKit/LayoutTests/fast/loader/resources/empty.html
[modify] https://crrev.com/cd172dba7f30f6d5cc4139b86b20dd5ce3acda61/third_party/WebKit/LayoutTests/fast/loader/resources/javascript-detached-frame-iframe.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20a34133c595148668a91237dd2b468310aaa336

commit 20a34133c595148668a91237dd2b468310aaa336
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Sep 25 06:55:59 2018

Unify origins on Resource, ResourceRequest and ResourceLoadOptions

blink::ResourceRequest::RequestorOrigin() has ignored iframe
sandboxing, but the reason why doing so is unknown even to OWNERS -
some comments say it's for site-for-cookies, but ResourceRequest
has a dedicated member for the concept, and there is no corresponding
concept of "RequestorOrigin" in the spec. Let's stop doing that, and
make it "request's origin" specified at
https://fetch.spec.whatwg.org/#concept-request-origin .

This CL also unifies ResourceRequest::RequestorOrigin with members that
are corresponding to "request's origin", i.e., Resource::source_origin_
and ResourceLoadOptions::security_origin.

This CL fixes some layout tests for outofblink-cors, because
network::CORSURLLoader uses network::ResourceRequest::request_initiator
which is corresponding to ResourceRequest::RequestorOrigin() as
"request's origin".

Bug:  867834 ,  811669 ,  879991 , 870173
Change-Id: Ie42d38dcfcc16e0a56d8fb1029475b72bd45f2ca
Reviewed-on: https://chromium-review.googlesource.com/1213422
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593840}
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/public/platform/web_url_request.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/exported/web_associated_url_loader_impl.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/ping_loader.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/resource/image_resource.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/resource/image_resource.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/threadable_loader.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/modules/eventsource/event_source.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/modules/notifications/notification_image_loader.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/fetch_parameters.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/memory_cache_test.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/raw_resource.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/raw_resource.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/raw_resource_test.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/resource_loader.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/resource_loader_options.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/resource_request.cc
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/fetch/resource_request.h
[modify] https://crrev.com/20a34133c595148668a91237dd2b468310aaa336/third_party/blink/renderer/platform/loader/subresource_integrity_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47b4b34aa7157f1c0ef12b7fbaeafb8a9e4adc22

commit 47b4b34aa7157f1c0ef12b7fbaeafb8a9e4adc22
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Sep 25 07:07:55 2018

[OOR-CORS] Do not use about:blank in worker-empty-nocrash.html

The test was added at https://bugs.webkit.org/show_bug.cgi?id=77593,
and the original motivation was verifying that there is no crash when
Worker is initiated with an empty script.

Currently the test is working because the same-origin restriction
is disabled due to the AllowUniversalAccessFromFileURLs setting. We
will not be able to rely on the setting with out-of-blink CORS, so
let's use an empty script rather than about:blank.

Bug: 870173
Change-Id: I8beb3c83229134e92dab51eb670fdbb3236e7bff
Reviewed-on: https://chromium-review.googlesource.com/1235776
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593843}
[modify] https://crrev.com/47b4b34aa7157f1c0ef12b7fbaeafb8a9e4adc22/third_party/WebKit/LayoutTests/fast/workers/chromium/empty-worker-nocrash.html
[add] https://crrev.com/47b4b34aa7157f1c0ef12b7fbaeafb8a9e4adc22/third_party/WebKit/LayoutTests/fast/workers/chromium/resources/empty.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2057e4ba6eb16fa960b0c12c93a5a0031ddec0a2

commit 2057e4ba6eb16fa960b0c12c93a5a0031ddec0a2
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Sep 26 01:12:56 2018

[OOR-CORS] Treat two opaque origins equivalent for blob: requests

Ususally, two opaque url::Origins are not equivalent each other, but
for a blob: request initiated by a opaque origin, we want to say that
the request is a same-origin request.

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ibb23cf485ec840bda8e449e13248e142011e0454
Reviewed-on: https://chromium-review.googlesource.com/1220257
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594172}
[modify] https://crrev.com/2057e4ba6eb16fa960b0c12c93a5a0031ddec0a2/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/2057e4ba6eb16fa960b0c12c93a5a0031ddec0a2/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91b55a349cca777864bd0a536800cfb62cb3f6fe

commit 91b55a349cca777864bd0a536800cfb62cb3f6fe
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Mon Oct 01 07:10:16 2018

OOR-CORS: Make ResourceDispatcherHostTest pass

ResourceDispatcherHostTest was modified to run with TestMode, but
I forgot to setup features for each param.

This patch puts right configurations and makes failed tests
pass with some modification around how to manage RunLoops.

Bug: 870173
Change-Id: I2b61774668ca5dd7ca2f587b68a9a8671c18fe2d
Reviewed-on: https://chromium-review.googlesource.com/1249462
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595394}
[modify] https://crrev.com/91b55a349cca777864bd0a536800cfb62cb3f6fe/content/browser/loader/resource_dispatcher_host_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66fa60b44e13d830d39b3eb52da41e04e377813b

commit 66fa60b44e13d830d39b3eb52da41e04e377813b
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Oct 03 05:22:12 2018

[OOR-CORS] Fix xmlhttprequest-no-file-access-real.html

The test has used synchronous XHR, but blink::ThreadableLoader ignores
a network error for the synchronous case. Currently CORS is implemented
in ThreadableLoader and thus the error is notified, but that will not
be true with out-of-blink CORS. This CL fixes the test so that it uses
asynchronous XHR to make it pass even with out-of-blink CORS.

Bug: 870173
Change-Id: I1c315ddf7f2a25d54f6de7f297d16677da8ba862
Reviewed-on: https://chromium-review.googlesource.com/c/1245057
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596124}
[modify] https://crrev.com/66fa60b44e13d830d39b3eb52da41e04e377813b/third_party/WebKit/LayoutTests/fast/xmlhttprequest/resources/xmlhttprequest-no-file-access-real.html
[delete] https://crrev.com/8dd90fa6dda0da939adec675686fb933d1ac96e5/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt
[modify] https://crrev.com/66fa60b44e13d830d39b3eb52da41e04e377813b/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-no-file-access.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a32141e61162aacff18f6ec605b5be57d6c37e1

commit 5a32141e61162aacff18f6ec605b5be57d6c37e1
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Oct 03 09:43:50 2018

[OOR-CORS] Ignore headers added by blink initiated revalidation

With OOR-CORS, CORS logic is moved out of blink. This is problematic for
the memory cache in blink, because the relationship between caching and
CORS is different from what is specced. Ignore headers added by
blink-initiated revalidation.

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I64346ee908cd4b3ab5b6cd8442dfaa8f8d7a2368
Reviewed-on: https://chromium-review.googlesource.com/c/1244998
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596167}
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/cors/cors.h
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/cors/cors_unittest.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/cors/preflight_cache.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/cors/preflight_cache.h
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/cors/preflight_cache_unittest.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/cors/preflight_result.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/cors/preflight_result.h
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/cors/preflight_result_unittest.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/third_party/blink/public/platform/web_url_request.h
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/third_party/blink/renderer/platform/exported/web_url_request.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/third_party/blink/renderer/platform/loader/cors/cors.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/5a32141e61162aacff18f6ec605b5be57d6c37e1/third_party/blink/renderer/platform/loader/fetch/resource_request.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2493671b9f185659cae98ea82970b6784e35044

commit b2493671b9f185659cae98ea82970b6784e35044
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Oct 04 09:09:25 2018

OOR-CORS: Remove DCHECK on {Pause|Resume}ReadingBodyFromNet

There were DCHECKs there, but it is ok to be called, and happens
actually on running tests with NetworkService enabled, e.g.
some tests in SafeBrowsingBlockingPageBrowserTest hit.

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I27721bf4c3ea445266797cbe6e06b5e19773bd1d
Reviewed-on: https://chromium-review.googlesource.com/c/1260744
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596552}
[modify] https://crrev.com/b2493671b9f185659cae98ea82970b6784e35044/services/network/cors/cors_url_loader.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/110901d35bc3b23e9241f9a6db6e1c2b1cd3521a

commit 110901d35bc3b23e9241f9a6db6e1c2b1cd3521a
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Oct 10 04:54:49 2018

[OOR-CORS] Update TestExpectations

Remove stale entries.

Bug: 870173
Change-Id: If292364ee3577a8de8fb516d2e72366cc87e396b
Reviewed-on: https://chromium-review.googlesource.com/c/1272335
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598213}
[modify] https://crrev.com/110901d35bc3b23e9241f9a6db6e1c2b1cd3521a/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eddf738e4804b82d248082a0b9e369507edbb05

commit 6eddf738e4804b82d248082a0b9e369507edbb05
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Oct 10 06:44:04 2018

Reject CORS enabled requests on FileURLLoaderFactory

FileURLLoader is not covered by CORSURLLoader, so it should reject CORS
enabled requests manually.

Bug: 870173
Change-Id: I590dbeffae18a97daece073d559f3e022fca7b1b
Reviewed-on: https://chromium-review.googlesource.com/c/1270301
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598229}
[modify] https://crrev.com/6eddf738e4804b82d248082a0b9e369507edbb05/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/6eddf738e4804b82d248082a0b9e369507edbb05/content/browser/loader/cors_file_origin_browsertest.cc
[modify] https://crrev.com/6eddf738e4804b82d248082a0b9e369507edbb05/content/test/data/loader/cors_file_origin_test.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd51642f04dee142270320486943bea13b677f73

commit bd51642f04dee142270320486943bea13b677f73
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Oct 10 06:50:23 2018

Do not attach "origin" header for navigation requests

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I3fe11cd9e07d73547004ce25a307865347e2bc7e
Reviewed-on: https://chromium-review.googlesource.com/c/1270378
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598233}
[modify] https://crrev.com/bd51642f04dee142270320486943bea13b677f73/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/bd51642f04dee142270320486943bea13b677f73/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a25f94ac28aa7fc70de2d3418da135f11e43e5c

commit 8a25f94ac28aa7fc70de2d3418da135f11e43e5c
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Oct 10 07:06:05 2018

OOR-CORS: X-Requested-With should be set to the request header later

Chrome internally sets the 'X-Requested-With' header for requests
from plugins. To avoid counting it in the existing CORS check, the
header information is stored as an ExtraData rather than in actual
headers. But, the ExtraData is expanded into the headers in the
renderer process. As a result, OOR-CORS in the browser process sees
the 'X-Requested-With' header on checking CORS conditions.

This patch stops expanding it in the renderer process, but does it
later, at the timing just making a net::URLRequest in the browser
process or Network Service so that it always should be after any
CORS checks.

This will make OutOfProcessPPAPITest.URLLoader2 pass with OOR-CORS
regardless of NetworkService existence.

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iee0272d66b18b4ccaa77b29a0f845be67e943c3f
Reviewed-on: https://chromium-review.googlesource.com/c/1260326
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598237}
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/content/renderer/loader/request_extra_data.h
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/content/renderer/pepper/url_request_info_util.cc
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/services/network/url_loader.cc
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/third_party/blink/public/platform/web_url_request.h
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/third_party/blink/renderer/platform/exported/web_url_request.cc
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/third_party/blink/renderer/platform/loader/fetch/resource_request.cc
[modify] https://crrev.com/8a25f94ac28aa7fc70de2d3418da135f11e43e5c/third_party/blink/renderer/platform/loader/fetch/resource_request.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c6ce7173722c5e0734d19787138dc12753ef741

commit 5c6ce7173722c5e0734d19787138dc12753ef741
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Oct 10 09:50:12 2018

OOR-CORS: Skip some CrossSiteDocumentBlockingTest tests

CrossSiteDocumentBlockingTest relied on
WebPreferences::web_security_enabled that won't be supported by
OOR-CORS, and some tests do not make much sense if CORS checks
are implemented in out of renderer processes.

This patch modifies CrossSiteDocumentBlockingTest to run with
or without kOutOfBlinkCORS feature, and skips test cases that
won't make much sense for kOutOfBlinkCORS.

Bug: 870173, 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: If45b213d8e14039a19af1e54a11759ebba42694a
Reviewed-on: https://chromium-review.googlesource.com/c/1253623
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598270}
[modify] https://crrev.com/5c6ce7173722c5e0734d19787138dc12753ef741/content/browser/loader/cross_site_document_blocking_browsertest.cc
[modify] https://crrev.com/5c6ce7173722c5e0734d19787138dc12753ef741/services/network/cross_origin_read_blocking.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/793f7c3583a9b2061ced839baa09468b691e7f0b

commit 793f7c3583a9b2061ced839baa09468b691e7f0b
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Oct 11 11:06:56 2018

OOR-CORS: Provide preflight ResourceTiming information

If OOR-CORS is enabled, CORS preflight requests are made outside
Blink, and their ResourceTiming information usually collected via
Resource instances could not be captured.

This patch adds PreflightTimingInfo to URLLoaderCompletionStatus
so that Blink can generate a correspond ResourceTiming information.

This will make following layout tests pass with kOutOfBlinkCORS.

 - http/tests/misc/resource-timing-sizes-cors-preflight.html
 - http/tests/misc/resource-timing-sizes-cors-preflight-worker.html

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iba425d83ba1163cadc6b96f41c7329901b79c65d
Reviewed-on: https://chromium-review.googlesource.com/c/1268996
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598721}
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/cors/cors_url_loader.h
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/cors/preflight_controller.h
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/cors/preflight_controller_unittest.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/public/cpp/cors/preflight_timing_info.cc
[add] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/public/cpp/cors/preflight_timing_info.h
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/public/cpp/url_loader_completion_status.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/services/network/public/cpp/url_loader_completion_status.h
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/public/platform/DEPS
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/public/platform/web_url_loader_client.h
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/core/loader/resource/image_resource.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/core/loader/resource/image_resource_test.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/core/testing/sim/sim_network.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/core/testing/sim/sim_request.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/platform/exported/web_url_loader_test_delegate.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/793f7c3583a9b2061ced839baa09468b691e7f0b/third_party/blink/renderer/platform/loader/fetch/resource_loader.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/143c15ec1bb5d831c3dc896ef319e376d613eb5b

commit 143c15ec1bb5d831c3dc896ef319e376d613eb5b
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Fri Oct 19 16:16:37 2018

Stop relying on disabled web security in CORB tests.

This CL:

1. Transitions core CORB test coverage away from the fetch API (where
   blocking by OOR-CORS can interfere with test results) to triggering
   fetches via <img> tags (where CORB stays applicable even after
   OOR-CORS ships).

   Tests covering CORS/CORB intersection continue to be done via fetch
   API (in CrossSiteDocumentBlockingTest.BlockFetches test).

   Verification of response body no longer depends on disabled web
   security (and inspecting fetch API results), but is instead done
   via RequestInterceptor helper that lives next to the tests.
   The CL also uncovered and fixes a threading issue in the
   implementation of RequestInterceptor.

2. Stops testing range requests in content_browsertests and starts to
   rely on existing and new test coverage in content_unittests (fetch
   API seems to be the only directly-test-controllable way of making
   range requests).

I've tested this CL by manually running CrossSiteDocumentBlockingTest
from content_browsertests 1) in default mode, 2) with NetworkService
enabled and 3) with NetworkService and OutOfBlinkCORS enabled.

Bug: 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iec5c9f0e7ddad0ff02627b88dcfab276795e7be9
Reviewed-on: https://chromium-review.googlesource.com/c/1279351
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601174}
[modify] https://crrev.com/143c15ec1bb5d831c3dc896ef319e376d613eb5b/content/browser/loader/cross_site_document_blocking_browsertest.cc
[modify] https://crrev.com/143c15ec1bb5d831c3dc896ef319e376d613eb5b/content/browser/loader/cross_site_document_resource_handler_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d77502b28d7d93a7913a8517e48af9f52c79e4a

commit 7d77502b28d7d93a7913a8517e48af9f52c79e4a
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Nov 07 07:11:47 2018

Gardening: service-worker clients-matchall-order does not timeout.

Since adding the long timeout in
https://github.com/web-platform-tests/wpt/pull/13684, it doesn't
timeout. However, it still has recently started timing out on
Mac for oob-cors.

Bug:  868225 , 870173
Change-Id: I3b460ae75d0e25916ed2d836e0e5d75d29f2124b
Reviewed-on: https://chromium-review.googlesource.com/c/1322335
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605982}
[modify] https://crrev.com/7d77502b28d7d93a7913a8517e48af9f52c79e4a/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/866643108a002c98736eb3cdfb505056a60947b8

commit 866643108a002c98736eb3cdfb505056a60947b8
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Nov 14 12:41:37 2018

Mark wpt/.../clients-matchall-order.https.html as Timeout

It's marked as Skip but we cannot investigate the failure without
running it.

Bug: 870173
Change-Id: I110fdf24cbe625974f9596deaedcee88a92e384e
Reviewed-on: https://chromium-review.googlesource.com/c/1334990
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607962}
[modify] https://crrev.com/866643108a002c98736eb3cdfb505056a60947b8/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78d71e6e1c74a97fd22a8387de36ff8c61ddfccf

commit 78d71e6e1c74a97fd22a8387de36ff8c61ddfccf
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Nov 16 03:33:35 2018

Remove wpt/.../clients-matchall-order.https.html Timeout expectation

It's no longer failing.

Bug: 870173
Change-Id: Iad2a11e4d91f93fc13b52c0d93de01a84af12b61
Reviewed-on: https://chromium-review.googlesource.com/c/1337222
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608650}
[modify] https://crrev.com/78d71e6e1c74a97fd22a8387de36ff8c61ddfccf/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2141c235865db17d233f727b9d4303dafb324d31

commit 2141c235865db17d233f727b9d4303dafb324d31
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Nov 22 05:44:03 2018

OOR-CORS: Make VariationsHttpHeadersBrowserTest pass with kOutOfBlinkCORS

Chrome internally uses X-Client-Data header, and this should not
triggers CORS preflight request.

TBR=jochen@chromium.org

Bug: 870173,  907018 
Change-Id: I67f1711b9065223f9e174e207980940e175031e9
Reviewed-on: https://chromium-review.googlesource.com/c/1335076
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610313}
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/chrome/common/google_url_loader_throttle.cc
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/content/renderer/pepper/url_request_info_util.cc
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/services/network/url_loader.cc
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/third_party/blink/public/platform/web_url_request.h
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/third_party/blink/renderer/platform/exported/web_url_request.cc
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/third_party/blink/renderer/platform/loader/fetch/resource_request.cc
[modify] https://crrev.com/2141c235865db17d233f727b9d4303dafb324d31/third_party/blink/renderer/platform/loader/fetch/resource_request.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d96c8eda9afb578f13ed9e952b69c525f539ce7f

commit d96c8eda9afb578f13ed9e952b69c525f539ce7f
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Dec 04 09:38:35 2018

Gardening: Tweak outofblink-cors failures after WPT import.

The import bot at https://crrev.com/c/1359866 added Mac expectations for
outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types,
which is surprising because the test should have no platform
differences. Probably the test is just flaky everywhere. Remove the Mac
expectations in favor of flaky expectations.

Bug:  911442 , 870173
Change-Id: I1cfae61ceee615bcd5654920590a53c0d8447d3e
TBR: toyoshim
Reviewed-on: https://chromium-review.googlesource.com/c/1360453
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613484}
[modify] https://crrev.com/d96c8eda9afb578f13ed9e952b69c525f539ce7f/third_party/blink/web_tests/TestExpectations
[delete] https://crrev.com/4413fc16ca9a076f683f6cdbaa4e43b8166f4c99/third_party/blink/web_tests/platform/mac-mac10.11/virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
[delete] https://crrev.com/4413fc16ca9a076f683f6cdbaa4e43b8166f4c99/third_party/blink/web_tests/platform/mac-retina/virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62025e05f777541733a8653bad8a3bf3cce2823c

commit 62025e05f777541733a8653bad8a3bf3cce2823c
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Dec 05 02:04:46 2018

Gardening: remove OOB-CORS expectation for clients-matchall-client-types

The test is no longer flaky according to the dashboard.

Bug: 870173
Change-Id: I9d69be00ee913a87006d693baccdf7fb79b35aed
No-Try: true
TBR: toyoshim
Reviewed-on: https://chromium-review.googlesource.com/c/1361758
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613813}
[modify] https://crrev.com/62025e05f777541733a8653bad8a3bf3cce2823c/third_party/blink/web_tests/TestExpectations