Triage: pbos@ can you take a first shot? Thanks!

The primary reason for using a fade here was to maximize the space allotted to bookmark text (the same reason we began using a fade in the tabstrip years back; it didn't originally have anything to do with depth cues).  We just never bothered to fix Mac.  I'm worried about chopping a couple characters off each bookmark here.  Can we instead be consistent by fading everywhere?

FWIW I think fade out looks weird when there's no trailing divider to "dive in under". The bookmark items kinda "fade into nothing" which feels less intuitive than ellipsis.

I think we should unify them on all platforms (regardless of if that means ellipsis or fade out), so +ellyjones@ for Mac platform concerns. If Mac style has strong opinions here I think they should take precedence.

markchang@ can you folks figure this one out at triage?

The Mac elision style looks like the attached screenshot. I'd prefer to use that style if we can :)

Deleted: Screen Shot 2018-08-14 at 9.08.03 AM.png 65.2 KB

	Screen Shot 2018-08-14 at 9.08.03 AM.png 65.2 KB View Download

Here's using gfx::ELIDE_MIDDLE. I think this style is weird on Windows, but I don't think diverging here is too bad either. I can put in whatever consensus tells me to do here.

Deleted: middle-ellipsis.png 22.0 KB

	middle-ellipsis.png 22.0 KB View Download

Marking as untriaged to get a decision from triage. We can use ELIDE_MIDDLE on Mac (which sounds preferred, per #7), but #4 and the original report is in conflict.

FWIW I think the elide style looks better on Windows, but eliding the middle looks very out of place to me.

I prefer ELIDE_MIDDLE for all uses on Mac. I have no opinion about Windows - maybe robliao@ does?

Windows generally reserves something like ELIDE_MIDDLE for paths in very special cases (like security impacting UI). Otherwise, Windows generally does ELIDE_TAIL.

For Windows, I have a strong preference towards ELIDE_TAIL.

SGTM. I think we should try moving toward platform adherence in this area. I hear Peter's concern though. For users where density is paramount, this change may prove irritating. However, if I had to guess, total number of bookmarks visible in the bar is more important than the number of characters visible. This change doesn't make the bar less dense.

Per pending CL for posterity, it looks like a lot of page <title>s are using "Google Docs", "Stack Overflow", ... as suffixes, which means that the tail end of ELIDE_MIDDLE is not likely to hold relevant information that's not conveyed by the favicon.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e48e42897d9d8dd00c7bf45fa317067387222f2e

commit e48e42897d9d8dd00c7bf45fa317067387222f2e
Author: Peter Boström <pbos@chromium.org>
Date: Fri Oct 19 18:06:32 2018

Always use ELIDE_TAIL for bookmarks-bar buttons

This keeps bookmarks-bar entries more aligned with Windows style.

Bug:  chromium:870158 
Change-Id: I7a9e5a147cd9c12a1a5c5de58b40dfdd4c8eb0c9
Reviewed-on: https://chromium-review.googlesource.com/c/1284052
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601224}
[modify] https://crrev.com/e48e42897d9d8dd00c7bf45fa317067387222f2e/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/e48e42897d9d8dd00c7bf45fa317067387222f2e/ui/views/style/platform_style.cc
[modify] https://crrev.com/e48e42897d9d8dd00c7bf45fa317067387222f2e/ui/views/style/platform_style.h
[modify] https://crrev.com/e48e42897d9d8dd00c7bf45fa317067387222f2e/ui/views/style/platform_style_mac.mm

Able to reproduce the issue on chrome version build without fix #70.0.3503.0 on Windows 10 by following steps as per comment #0.

Verified the fix on  Windows 10, as per comment#0 on latest chrome version #72.0.3588.0.
Attaching screen shot for reference.
Observed that the text at the end of the bookmark which is saved is shown in ellipsis and not faded.
Hence, the fix is working as expected.
Adding the verified labels.

Thanks...!!

Deleted: 870158(M70).PNG 413 KB

	870158(M70).PNG 413 KB View Download

Deleted: 870158_(M72).png 459 KB

	870158_(M72).png 459 KB View Download