New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870153 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Include resident key option in CTAP MakeCredential request

Project Member Reported by hongjunchoi@chromium.org, Aug 2

Issue description

Resident key option is currently always set to false even if relying party sets resident key option in AuthenticatorSelectionCriteria to be true.

Add resident key option to CTAP request. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43ccd34e724824a0a3516887cecaa7a25c1b1505

commit 43ccd34e724824a0a3516887cecaa7a25c1b1505
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Thu Aug 02 20:44:21 2018

Include resident key option in MakeCredential

Currently resident key option in CTAP MakeCredential request parameter
is set to false regardless of what the relying party sets in
AuthenticatorSelectionCriteria. Add resident key option to CTAP
MakeCredential request accordingly.

Bug:  870153 
Change-Id: I3c964c0e036008f3d38d60a5ab3c6610eb80085b
Reviewed-on: https://chromium-review.googlesource.com/1159825
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580308}
[modify] https://crrev.com/43ccd34e724824a0a3516887cecaa7a25c1b1505/device/fido/make_credential_handler_unittest.cc
[modify] https://crrev.com/43ccd34e724824a0a3516887cecaa7a25c1b1505/device/fido/make_credential_request_handler.cc

Labels: Merge-Request-69
Status: Fixed (was: Started)
Requesting merge of https://chromium-review.googlesource.com/c/chromium/src/+/1159825 to M69. 
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 3

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
How is the change listed at #2 looking in canary? Also could you pls justify the merge to M69?
Labels: -Hotlist-Merge-Review -M-69 -Merge-Review-69 M-70
Removing merge review label as is not critical for M69. 

Sign in to add a comment