New issue
Advanced search Search tips

Issue 870151 link

Starred by 1 user
Status: Fixed
Owner:
pkl@chromium.org
Closed: Aug 2
Cc:
marq@chromium.org
linds...@chromium.org
rohitrao@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q3



Sign in to add a comment

Change infobars to new design that fits UI refresh

Project Member Reported by ghendel@google.com, Aug 2 
Implement the changes to button font, shape and padding that are hidden behind the  #infobars-ui-reboot flag.

Comment 1 by pkl@chromium.org, Aug 2

Cc: rohitrao@chromium.org
This CL https://chromium-review.googlesource.com/c/chromium/src/+/1132564 has been sitting in the wings for a while. I ran several suites of egtests locally today and didn't see any breakage.

Comment 2 by marq@chromium.org, Aug 2

Labels: -Pri-2 Q3 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e44aedab4b00663f7ab9185220af100f747da86

commit 0e44aedab4b00663f7ab9185220af100f747da86
Author: Peter K. Lee <pkl@chromium.org>
Date: Thu Aug 02 14:00:40 2018

Enables Infobars Phase 1

Bug:  870151 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8e1fc458e9316be19e35b5e0f3edaefb5d3244f3
Reviewed-on: https://chromium-review.googlesource.com/1132564
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580159}
[modify] https://crrev.com/0e44aedab4b00663f7ab9185220af100f747da86/ios/chrome/browser/ui/ui_util.mm

Comment 4 by pkl@chromium.org, Aug 2

Status: Fixed (was: Assigned)
►

Sign in to add a comment