New issue
Advanced search Search tips

Issue 870140 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Touch event listener in distilled view became passive

Project Member Reported by wychen@chromium.org, Aug 2 
Chrome Version: M70
OS: Android

What steps will reproduce the problem?
(1) Use "Simplified view" (set chrome://flags#reader-mode-heuristics to Always for easier triggering)
(2) Inspect the distilled view from desktop through chrome://inspect/#devices.
(3) Pinch-zoom the page

What is the expected result?
No errors on the console.

What happens instead?
Errors on the console:
[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/5093566007214080
[Intervention] Ignored attempt to cancel a touchend event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71a3eca5f1ecdd499b63dc644814bab5361ac483

commit 71a3eca5f1ecdd499b63dc644814bab5361ac483
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Thu Aug 16 00:49:36 2018

Make touch event handlers in distiller viewer non-passive

Document-level touch event listeners are treated as passive since
M56. These touch event handlers in DOM distiller viewer are indeed
intended to block scrolling, so make them non-passive to restore
the old behavior.

Bug: 870140, b/80346318
Change-Id: I9daa7e46564607a15b0d00f092616da9be2a570e
Reviewed-on: https://chromium-review.googlesource.com/1175560
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583473}
[modify] https://crrev.com/71a3eca5f1ecdd499b63dc644814bab5361ac483/components/dom_distiller/core/javascript/dom_distiller_viewer.js
►

Sign in to add a comment