New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add DeviceSync service metrics

Project Member Reported by khorimoto@chromium.org, Aug 2

Issue description

This includes both code which implements the service as well as nested CryptAuth classes.
 
Status: Assigned (was: Available)
Labels: Pri-2
Cc: -jlklein@chromium.org vimistry@google.com
Cc: -vimistry@google.com -jessejames@chromium.org jlklein@chromium.org vimistry@chromium.org
Cc: jessejames@chromium.org
Labels: -M-70 M-71
Components: -UI>ProximityAuth UI>Multidevice
Labels: -M-71 M-72
As per go/beto-metrics, we want the following metrics (this bug will cover progress on them):

MultiDevice.DeviceSyncService.ForceEnrollmentNow.SuccessRate
MultiDevice.DeviceSyncService.ForceSyncNow.SuccessRate
MultiDevice.DeviceSyncService.SetSoftwareFeatureState.SuccessRate
MultiDevice.DeviceSyncService.SetSoftwareFeatureState.FailureReason
MultiDevice.DeviceSyncService.FindEligibleDevices.SuccessRate
MultiDevice.DeviceSyncService.FindEligibleDevices.FailureReason
One more metric: 

MultiDevice.CryptAuth.DeviceSync.Result
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a1015c38042a222d3408e3062dd3c5eb80e15f6

commit 0a1015c38042a222d3408e3062dd3c5eb80e15f6
Author: Regan Hsu <hsuregan@chromium.org>
Date: Wed Oct 31 03:30:29 2018

[CrOS MultiDevice] Add metric for MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Success
Add success of enabling and disabling features for devices.

Bug:  870138 

Change-Id: I27a96eceb4d1c9ec3fe00ad37c1606785ab4449d
Reviewed-on: https://chromium-review.googlesource.com/c/1306915
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604136}
[modify] https://crrev.com/0a1015c38042a222d3408e3062dd3c5eb80e15f6/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/0a1015c38042a222d3408e3062dd3c5eb80e15f6/chromeos/services/device_sync/device_sync_impl.h
[modify] https://crrev.com/0a1015c38042a222d3408e3062dd3c5eb80e15f6/chromeos/services/device_sync/device_sync_service_unittest.cc
[modify] https://crrev.com/0a1015c38042a222d3408e3062dd3c5eb80e15f6/tools/metrics/histograms/histograms.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dec7e58f53d48081c9ffb5ea586def3ad05de702

commit dec7e58f53d48081c9ffb5ea586def3ad05de702
Author: Regan Hsu <hsuregan@chromium.org>
Date: Thu Nov 01 19:11:49 2018

[CrOS MultiDevice] Add metrics for
MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Result.FailureReason

Add metrics which breaks down the percentages of reasons when
failure occurs on SetSoftwareFeatureState.

Bug:  870138 
Change-Id: I277eeb3f0e0e3fe4418affb91977c7ddf74a9365
Reviewed-on: https://chromium-review.googlesource.com/c/1308979
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604660}
[modify] https://crrev.com/dec7e58f53d48081c9ffb5ea586def3ad05de702/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/dec7e58f53d48081c9ffb5ea586def3ad05de702/chromeos/services/device_sync/device_sync_impl.h
[modify] https://crrev.com/dec7e58f53d48081c9ffb5ea586def3ad05de702/chromeos/services/device_sync/device_sync_service_unittest.cc
[modify] https://crrev.com/dec7e58f53d48081c9ffb5ea586def3ad05de702/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/dec7e58f53d48081c9ffb5ea586def3ad05de702/tools/metrics/histograms/histograms.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1d15730e79017ec402409e3f51588c5223dd363

commit b1d15730e79017ec402409e3f51588c5223dd363
Author: Regan Hsu <hsuregan@chromium.org>
Date: Thu Nov 01 20:44:36 2018

[CrOS MultiDevice] Add metrics for
MultiDevice.DeviceSyncService.FindEligibleDevices.Result*

Add success of finding eligible devices (FindEligibleDevices), and
metrics which breaks down the percentages of reasons when
failure occurs on FindEligibleDevices.

Bug:  870138 
Change-Id: I63140be659f5d4723998a0cc87b53e830f36f09d
Reviewed-on: https://chromium-review.googlesource.com/c/1311086
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604697}
[modify] https://crrev.com/b1d15730e79017ec402409e3f51588c5223dd363/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/b1d15730e79017ec402409e3f51588c5223dd363/chromeos/services/device_sync/device_sync_service_unittest.cc
[modify] https://crrev.com/b1d15730e79017ec402409e3f51588c5223dd363/tools/metrics/histograms/histograms.xml

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01aafe525b441269afedf8c02da9cdcaf310b912

commit 01aafe525b441269afedf8c02da9cdcaf310b912
Author: Regan Hsu <hsuregan@chromium.org>
Date: Fri Nov 02 00:46:31 2018

[CrOS CryptAuth] Source metrics for CryptAuth.Enrollment.Result at another location.

Metric collection was missing in OnFinishEnrollmentFailure.

Bug:  870138 
Change-Id: Ia10d63753f7732257b1e7195d117fa4725ba1542
Reviewed-on: https://chromium-review.googlesource.com/c/1313754
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604778}
[modify] https://crrev.com/01aafe525b441269afedf8c02da9cdcaf310b912/components/cryptauth/cryptauth_enroller_impl.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86e38f591583a58d767e97abaafb03b9f9ece47b

commit 86e38f591583a58d767e97abaafb03b9f9ece47b
Author: Regan Hsu <hsuregan@chromium.org>
Date: Sat Nov 03 00:07:25 2018

[CrOS MultiDevice] Force Sync & Force Enrollment metrics

Add metrics for:
(1) MultiDevice.DeviceSyncService.ForceEnrollmentNow.Result, and
(2) MultiDevice.DeviceSyncService.ForceSyncNow.Result.

Both currently are enumerated histograms with 2 buckets:
(1) Success
(2) Service not ready.

Bug:  870138 
Change-Id: I78acaea600885c1e44be249d37237a49f8b81e9f
Reviewed-on: https://chromium-review.googlesource.com/c/1312569
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605101}
[modify] https://crrev.com/86e38f591583a58d767e97abaafb03b9f9ece47b/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/86e38f591583a58d767e97abaafb03b9f9ece47b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/86e38f591583a58d767e97abaafb03b9f9ece47b/tools/metrics/histograms/histograms.xml

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77b36177ac0a3d6b9d5d6920165dd183ad2f48ec

commit 77b36177ac0a3d6b9d5d6920165dd183ad2f48ec
Author: Regan Hsu <hsuregan@chromium.org>
Date: Sat Nov 03 00:23:37 2018

[CrOS CryptAuth] Add metrics for CryptAuth.DeviceSync.Result

Add metrics for when DeviceSync succeeds or fails upon retrieving supported devices.

Bug:  870138 
Change-Id: I270d35effa7de2161544ead77929e2913d2b2108
Reviewed-on: https://chromium-review.googlesource.com/c/1313565
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605106}
[modify] https://crrev.com/77b36177ac0a3d6b9d5d6920165dd183ad2f48ec/components/cryptauth/cryptauth_device_manager_impl.cc
[modify] https://crrev.com/77b36177ac0a3d6b9d5d6920165dd183ad2f48ec/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
All work is done here; I've also made sure to subscribe to all of the listed metrics with UMA Chirp.
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42dae1b6a7a392159b6b3d765780db33165b4130

commit 42dae1b6a7a392159b6b3d765780db33165b4130
Author: Regan Hsu <hsuregan@chromium.org>
Date: Wed Nov 07 02:03:32 2018

[CrOS MultiDevice] MultiDevice.Setup.HostStatus metrics

Add metrics for host status during MultiDevice Setup.

Bug:  870138 
Change-Id: Iee0ff8ed4a1408ccb2db3ef2a9902476acd9db72
Reviewed-on: https://chromium-review.googlesource.com/c/1313338
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605925}
[modify] https://crrev.com/42dae1b6a7a392159b6b3d765780db33165b4130/chromeos/services/multidevice_setup/host_status_provider_impl.cc
[modify] https://crrev.com/42dae1b6a7a392159b6b3d765780db33165b4130/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/42dae1b6a7a392159b6b3d765780db33165b4130/tools/metrics/histograms/histograms.xml

Owner: hsuregan@chromium.org
Status: Started (was: Fixed)
We have two additional metrics that we would also like to add:

MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Enable.FailedFeature
MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Disable.FailedFeature

(also described in go/beto-metrics)
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cc5b2b802b49f95b70f2e2483a021ad066ba50c

commit 2cc5b2b802b49f95b70f2e2483a021ad066ba50c
Author: Regan Hsu <hsuregan@chromium.org>
Date: Thu Nov 08 03:00:41 2018

[CrOS MultiDevice] Metrics for MultiDevice.SetupNotification.Dismissed

An enumerated histogram with 3 buckets:
1) “New user, potential host exists”,
2) “Existing user, host switched”, and
3) “Existing user, new Chromebook added”.

Tracks if users are actively dismissing our notifications.

Bug:  870138 
Change-Id: If46245c1be7528d63a92d51607c63bded8b391d2
Reviewed-on: https://chromium-review.googlesource.com/c/1316446
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606305}
[modify] https://crrev.com/2cc5b2b802b49f95b70f2e2483a021ad066ba50c/ash/multi_device_setup/multi_device_notification_presenter.cc
[modify] https://crrev.com/2cc5b2b802b49f95b70f2e2483a021ad066ba50c/ash/multi_device_setup/multi_device_notification_presenter.h
[modify] https://crrev.com/2cc5b2b802b49f95b70f2e2483a021ad066ba50c/ash/multi_device_setup/multi_device_notification_presenter_unittest.cc
[modify] https://crrev.com/2cc5b2b802b49f95b70f2e2483a021ad066ba50c/tools/metrics/histograms/histograms.xml

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/987237f297fab8f3f37d7ec6fee3ffb250a4d447

commit 987237f297fab8f3f37d7ec6fee3ffb250a4d447
Author: Regan Hsu <hsuregan@chromium.org>
Date: Thu Nov 08 22:47:47 2018

[CrOS MultiDevice] Create metrics that break down failures
of enabling and disabling features.

Bug:  870138 
Change-Id: Ia4e517b191d08ef906d359bf8e8decd627096f63
Reviewed-on: https://chromium-review.googlesource.com/c/1324852
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606632}
[modify] https://crrev.com/987237f297fab8f3f37d7ec6fee3ffb250a4d447/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/987237f297fab8f3f37d7ec6fee3ffb250a4d447/chromeos/services/device_sync/device_sync_impl.h
[modify] https://crrev.com/987237f297fab8f3f37d7ec6fee3ffb250a4d447/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/987237f297fab8f3f37d7ec6fee3ffb250a4d447/tools/metrics/histograms/histograms.xml

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e70b9c4868da9032fe47b5d7101a2549a22cbb

commit b1e70b9c4868da9032fe47b5d7101a2549a22cbb
Author: Regan Hsu <hsuregan@chromium.org>
Date: Tue Nov 13 23:39:22 2018

[CrOS MultiDevice] Add metrics for feature states.

MultiDevice.BetterTogetherSuite.MultiDeviceFeatureState
AndroidSms.MultiDeviceFeatureState
SmartLock.MultiDeviceFeatureState
InstantTethering.MultiDeviceFeatureState

Multiple enumerated histograms with the same 9 buckets:
1) “Prohibited by policy”,
2) “Disabled by user”,
3) “Enabled by user”,
4) “Not supported by Chromebook”,
5) “Not supported by phone”,
6) “Unavailable, no verified host”,
7) “Unavailable, insufficient security”,
8) “Unavailable, suite disabled”, and
9) “Further setup required”.

Bug:  870138 
Change-Id: Ic96b673a10b4ecd52b9f44b0f29abc52d29858b3
Reviewed-on: https://chromium-review.googlesource.com/c/1315938
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607804}
[modify] https://crrev.com/b1e70b9c4868da9032fe47b5d7101a2549a22cbb/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/b1e70b9c4868da9032fe47b5d7101a2549a22cbb/chromeos/services/multidevice_setup/public/mojom/multidevice_setup.mojom
[modify] https://crrev.com/b1e70b9c4868da9032fe47b5d7101a2549a22cbb/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b1e70b9c4868da9032fe47b5d7101a2549a22cbb/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Looks like we accidentally directed two unrelated MultiDevice metrics to this bug, but Comment #20 resolved remaining issues. As before, I've added MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Enable.FailedFeature and MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Disable.FailedFeature to my UMA Chirp subscriptions.

Sign in to add a comment