Sort devices in setup flow by "last seen" date |
|||||||||||||||
Issue descriptionThis ensures that if a user has many phones, the most-recently-used phone shows up first in the list.
,
Aug 16
,
Sep 11
,
Sep 14
P2 because this is an edge case.
,
Sep 20
,
Sep 20
,
Oct 10
,
Oct 10
Hey Josh, this one is a P3. Do you mind grabbing one of the open P2s from go/beto-blockers instead? Actually, it might even make sense for you to chat with Kyle about https://bugs.chromium.org/p/chromium/issues/detail?id=892349 if you're freed up because I'm not sure when he'll be free.
,
Oct 15
Bumping back up to P2 because several people have accidentally set up the wrong device because the dropdown is hard to notice. This is a pretty trivial fix, so we should just go for it.
,
Oct 17
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a26626104593ec9d9afe92b5abc1b46d084bdc29 commit a26626104593ec9d9afe92b5abc1b46d084bdc29 Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Oct 17 16:49:57 2018 [CrOS MultiDevice] Sort eligible devices before returning them. This CL sorts returned devices from most-recently-updated to least-recently-updated. This increases the likelihood that users who go through multi-device setup will set up the correct device, since usually the most-recently-updated the device is the one that users want to set. Bug: 870133 Change-Id: I954f3bde8ccb62c1f796ec62e8f12af65012e528 Reviewed-on: https://chromium-review.googlesource.com/c/1285769 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#600426} [modify] https://crrev.com/a26626104593ec9d9afe92b5abc1b46d084bdc29/chromeos/services/multidevice_setup/multidevice_setup_impl.cc [modify] https://crrev.com/a26626104593ec9d9afe92b5abc1b46d084bdc29/chromeos/services/multidevice_setup/multidevice_setup_impl_unittest.cc
,
Oct 17
,
Oct 17
Oops, closed this too early. Requesting M-71 merge.
,
Oct 18
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30f0eaa277177fb16e3bf6ccb743850e112c1a09 commit 30f0eaa277177fb16e3bf6ccb743850e112c1a09 Author: Kyle Horimoto <khorimoto@google.com> Date: Thu Oct 18 18:03:47 2018 [CrOS MultiDevice] Sort eligible devices before returning them. This CL sorts returned devices from most-recently-updated to least-recently-updated. This increases the likelihood that users who go through multi-device setup will set up the correct device, since usually the most-recently-updated the device is the one that users want to set. TBR=khorimoto@google.com (cherry picked from commit a26626104593ec9d9afe92b5abc1b46d084bdc29) Bug: 870133 Change-Id: I954f3bde8ccb62c1f796ec62e8f12af65012e528 Reviewed-on: https://chromium-review.googlesource.com/c/1285769 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600426} Reviewed-on: https://chromium-review.googlesource.com/c/1289088 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#123} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/30f0eaa277177fb16e3bf6ccb743850e112c1a09/chromeos/services/multidevice_setup/multidevice_setup_impl.cc [modify] https://crrev.com/30f0eaa277177fb16e3bf6ccb743850e112c1a09/chromeos/services/multidevice_setup/multidevice_setup_impl_unittest.cc
,
Oct 18
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30f0eaa277177fb16e3bf6ccb743850e112c1a09 Commit: 30f0eaa277177fb16e3bf6ccb743850e112c1a09 Author: khorimoto@google.com Commiter: khorimoto@chromium.org Date: 2018-10-18 18:03:47 +0000 UTC [CrOS MultiDevice] Sort eligible devices before returning them. This CL sorts returned devices from most-recently-updated to least-recently-updated. This increases the likelihood that users who go through multi-device setup will set up the correct device, since usually the most-recently-updated the device is the one that users want to set. TBR=khorimoto@google.com (cherry picked from commit a26626104593ec9d9afe92b5abc1b46d084bdc29) Bug: 870133 Change-Id: I954f3bde8ccb62c1f796ec62e8f12af65012e528 Reviewed-on: https://chromium-review.googlesource.com/c/1285769 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600426} Reviewed-on: https://chromium-review.googlesource.com/c/1289088 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#123} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by khorimoto@chromium.org
, Aug 2