New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870125 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 870156
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in spvtools::val::Function::AddFunctionCallTarget

Project Member Reported by ClusterFuzz, Aug 2

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6510743655284736

Fuzzer: afl_spvtools_val_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 8
Crash Address: 0x61b0000000f0
Crash State:
  spvtools::val::Function::AddFunctionCallTarget
  spvtools::val::ValidationState_t::AddFunctionCallTarget
  spvtools::val::ProcessInstruction
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=579912:579914

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6510743655284736

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 2

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 2

Labels: M-69 Target-69
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 2

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 2

Labels: Pri-1
Cc: ehsann@google.com andreyt@google.com
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
ehsann@, andreyt@, could you please take a look. Your validation related changes are in the regression range.

Assigning to dsinclair@ since ehsann@ and andreyt@ don't seem to have @chromium.org accounts. Please re-route if you know their @chromium.org handles.
Cc: -andreyt@google.com alanbaker@google.com
Labels: -Security_Impact-Head -ReleaseBlock-Stable Security_Impact-None
The SPIRV-Tools aren't used in Chromium yet, we're getting the fuzzers running before anything uses them. Removing ReleaseBlock-Stable.
Possibly a dupe of  crbug.com/870156 
Mergedinto: 870156
Status: Duplicate (was: Assigned)
Project Member

Comment 9 by ClusterFuzz, Aug 3

ClusterFuzz has detected this issue as fixed in range 580360:580362.

Detailed report: https://clusterfuzz.com/testcase?key=6510743655284736

Fuzzer: afl_spvtools_val_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 8
Crash Address: 0x61b0000000f0
Crash State:
  spvtools::val::Function::AddFunctionCallTarget
  spvtools::val::ValidationState_t::AddFunctionCallTarget
  spvtools::val::ProcessInstruction
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=579912:579914
Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=580360:580362

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6510743655284736

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 9

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment