New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870124 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove "setup failed" screen from setup flow

Project Member Reported by khorimoto@chromium.org, Aug 2

Issue description

Now that we retry setting the host until it fails, this view is no longer necessary.
 
Labels: -Pri-1 Pri-2
Labels: Pri-3
Labels: -M-70 M-71
Components: -UI>ProximityAuth UI>Multidevice
Can this be closed?
It hasn't been done yet, so no.
Owner: hsuregan@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdacba62e9072624959c8706ec55d4fd9fba9b15

commit cdacba62e9072624959c8706ec55d4fd9fba9b15
Author: Regan Hsu <hsuregan@chromium.org>
Date: Mon Jan 07 23:50:23 2019

[CrOS MultiDevice] Remove setup-failed page.

Now that we retry setting the host until it fails, this view is no
longer necessary.

Bug:  870124 
Change-Id: I953229195b078ef7ef814fa9a5c34a0e16602c3e
Reviewed-on: https://chromium-review.googlesource.com/c/1391778
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620537}
[modify] https://crrev.com/cdacba62e9072624959c8706ec55d4fd9fba9b15/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/cdacba62e9072624959c8706ec55d4fd9fba9b15/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_localized_strings_provider.cc
[modify] https://crrev.com/cdacba62e9072624959c8706ec55d4fd9fba9b15/ui/webui/resources/cr_components/chromeos/multidevice_setup/BUILD.gn
[modify] https://crrev.com/cdacba62e9072624959c8706ec55d4fd9fba9b15/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.html
[modify] https://crrev.com/cdacba62e9072624959c8706ec55d4fd9fba9b15/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.js
[delete] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/ui/webui/resources/cr_components/chromeos/multidevice_setup/setup_failed_page.html
[delete] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/ui/webui/resources/cr_components/chromeos/multidevice_setup/setup_failed_page.js
[modify] https://crrev.com/cdacba62e9072624959c8706ec55d4fd9fba9b15/ui/webui/resources/cr_components/cr_components_resources.grdp

Status: Fixed (was: Available)

Sign in to add a comment