Finally unblocked on this, so I'm tackling this now.

To implement this change, we should rely on the FeatureState obtained from the MultiDeviceSetup service.

As part of this change, ProximityAuthProfilePrefManager and ProximityAuthLocalStatePrefManager need to be updated; specifically, their IsEasyUnlockAllowed() and IsEasyUnlockEnabled() functions rely on reading from preferences. These should no longer read from preferences and should read from the MultiDeviceSetup service instead. That being said, it might be better to remove those functions entirely and replace them with a more general function, since presumably client would need to call both functions and && the result to determine the actual state.

Hi Shiba - can you clarify your comment #4? What action item needs to be taken regarding the screenshot?

Oops - Shiba, I saw your comment in your spreadsheet. Copying it here for clarity: "Smart lock setup notification should only pop up once the user finishes set up flow."

Ryan, to accomplish this task, you'll need to make a modification to the dialog class at [1]. Currently, that class only has a static Show() function, but it does not have a way to tell clients whether the dialog is showing. You'll need to add that functionality as well as adding some sort of observer pattern to be notified when the dialog has been closed.

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_dialog.h

This is not an ideal state, to be sure, but this is not launch blocking.

Most of this bug was fixed when  crbug.com/881435  was resolved. The fix for it followed the steps outline in comment #3. EasyUnlockServiceRegular now depends on MultiDeviceSetupService to inform it if Smart Lock is enabled (and this is gated on whether or not Unified Setup has been completed).

Removing "Started" status on this bug for now because I'm not actively working on this at the moment.

The only work left here should be to:

1) Hide Smart Lock in Screen Lock settings until Unified Setup has been completed. It seems like this work should be punted until  crbug.com/870130  is finished. If we decide to simply remove Smart Lock from Screen Lock page, this work item is irrelevant.

2) Address comment #6: "Smart lock setup notification should only pop up once the user finishes set up flow." Kyle or Shiba, can you clarify this item? AFAICT, this is existing behavior. I don't see what needs to be added here. Thanks!

Now that item 2) has been moved to  crbug.com/883069 , only item 1) is relevant. Marking as blocked on  crbug.com/870130 .

As per c#8, we're migrating Smart Lock out of the Lock Screen page into its own page. That work is tracked at  crbug.com/870130 ; this bug can be closed.