New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870120 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

PiP hover state only visible on click, not hover

Project Member Reported by bettes@chromium.org, Aug 2

Issue description

Chrome Version: 70.0.3508.0
OS: MacOS

What steps will reproduce the problem?
(1)Hover over pip window
(2)Hover out of pip window

What is the expected result?
Mouse out should remove hover state

What happens instead?
Hover state is persistent 

 
pip-hover.gif
2.2 MB View Download
Description: Show this description
Summary: PiP hover state only visible on click, not hover (was: PiP hover state is persistent when mouse out)
I'm realizing that the hover state is only visible on click. Changing title.
Cc: mlamouri@chromium.org
Components: Blink>Media>PictureInPicture
Status: Available (was: Untriaged)
I think it's a regression from my fix for Windows. We should probably have the windows fix behind OS_WIN.
Cc: -apaci...@chromium.org
Owner: apaci...@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6698555a6f8132847bd6198fa4d39a507999d6cd

commit 6698555a6f8132847bd6198fa4d39a507999d6cd
Author: Jennifer Apacible <japacible@gmail.com>
Date: Fri Aug 03 05:31:48 2018

[Picture in Picture] Only show controls when mouse is moving on Windows.

A previous change made controls always appear when the mouse is moving
on all OS except Windows. This change gates handling the ET_MOUSE_MOVED
event to Windows OS.

Bug:  870120 
Change-Id: I556c354643a920c34b973066369e26f38130705f
Reviewed-on: https://chromium-review.googlesource.com/1161300
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580457}
[modify] https://crrev.com/6698555a6f8132847bd6198fa4d39a507999d6cd/chrome/browser/ui/views/overlay/overlay_window_views.cc

Labels: M-69 Merge-Request-69
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 4

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
How is the change listed at #5 looking in canary? Also could you pls justify the merge to M69?
Labels: Needs-Feedback
Able to verify this issue on build without fix #70.0.3508.0, but seeing same behavior on build with fix #70.0.3514.0. Attaching screen-cast for reference.

@apacible: Could you please refer to the screen-cast and let us know if we missed anything from our end. Also please help in verifying the fix.

Thanks!
Build_without fix.webm
2.7 MB View Download
build with fix.webm
3.0 MB View Download
I cannot open Canary at 3514, but I am unable to repro the issue on 70.0.3515.0.
Per offline conversation -- this is a regression post-branch and the feature is behind finch.
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #10 and #11. Please merge now, thank you.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 6

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2264c9322eb657e08b1583a383e6459fa0efe3e

commit d2264c9322eb657e08b1583a383e6459fa0efe3e
Author: Jennifer Apacible <japacible@gmail.com>
Date: Mon Aug 06 20:14:10 2018

[Picture in Picture] Only show controls when mouse is moving on Windows.

A previous change made controls always appear when the mouse is moving
on all OS except Windows. This change gates handling the ET_MOUSE_MOVED
event to Windows OS.

Bug:  870120 
Change-Id: I556c354643a920c34b973066369e26f38130705f
Reviewed-on: https://chromium-review.googlesource.com/1161300
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580457}(cherry picked from commit 6698555a6f8132847bd6198fa4d39a507999d6cd)
Reviewed-on: https://chromium-review.googlesource.com/1163970
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#433}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/d2264c9322eb657e08b1583a383e6459fa0efe3e/chrome/browser/ui/views/overlay/overlay_window_views.cc

Status: Fixed (was: Started)

Sign in to add a comment