New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 870118 link

Starred by 2 users
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Aug 10
Cc:
jbanavatu@chromium.org
lethalantidote@chromium.org
amyroberts@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

PiP icon is pixelated

Project Member Reported by bettes@chromium.org, Aug 2 
What is the expected result?
Assuming we're using svgs, use the custom drawn icon at: 
https://drive.google.com/open?id=1V7H2gMpnK9IQCRrD8QB47yCkOiN31VAf

What happens instead?
I think we're using the default 24dp icon and scaling it down.
Screen Shot 2018-08-01 at 5.25.38 PM.png
46.6 KB View Download

Comment 1 by bettes@chromium.org, Aug 2

Status: Untriaged (was: Accepted)

Comment 2 by apaci...@chromium.org, Aug 2

Cc: -apaci...@chromium.org
Owner: apaci...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f245415132da4dbcab74a3008e0e3c0ce65782a

commit 8f245415132da4dbcab74a3008e0e3c0ce65782a
Author: Jennifer Apacible <apacible@chromium.org>
Date: Thu Aug 02 17:36:33 2018

[Picture in Picture] Update picture_in_picture_alt.icon.

This updates the icon to use the custom drawn icon supplied by UX. This
icon is only used in the toolbar indicator.

Bug:  870118 
Change-Id: Idd3ee8767e372c855d149cd7debb0ec6d6b4aa90
Reviewed-on: https://chromium-review.googlesource.com/1159993
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580233}
[modify] https://crrev.com/8f245415132da4dbcab74a3008e0e3c0ce65782a/chrome/app/vector_icons/picture_in_picture_alt.icon

Comment 4 by apaci...@chromium.org, Aug 2

Labels: M-69 Merge-Request-69

Comment 5 by jbanavatu@chromium.org, Aug 3

Cc: jbanavatu@chromium.org
Labels: Needs-Feedback
Unable to verify this on Mac OS due to  Issue 870652  - we are not seeing PiP icon in casting tab.

Thanks!
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 3

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, Aug 3 

How is the change looking in canary? Is it safe to merge? Also pls justify the merge to M69.

Comment 8 by apaci...@chromium.org, Aug 3

Labels: -Hotlist-Merge-Review -Needs-Feedback -Merge-Review-69
Cancelling merge request.

Comment 9 by apaci...@chromium.org, Aug 10

Status: Fixed (was: Started)
►

Sign in to add a comment