New issue
Advanced search Search tips

Issue 870117 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 869904



Sign in to add a comment

ThreadRestrictions crash in MaybeUpgradeCrostini

Project Member Reported by achuith@chromium.org, Aug 2

Issue description

Stack:
[3008:3008:0801/172017.334242:FATAL:thread_restrictions.cc(29)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the TaskScheduler, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking (see its documentation for best practices).
#0 0x5bef0223691c base::debug::StackTrace::StackTrace()
#1 0x5bef0218f4f0 logging::LogMessage::~LogMessage()
#2 0x5bef02209a56 base::AssertBlockingAllowed()
#3 0x5bef0223bebe base::PathExists()
#4 0x5bef01f07bb7 component_updater::CrOSComponentManager::IsRegistered()
#5 0x5bef00bbe907 crostini::CrostiniManager::MaybeUpgradeCrostini()
#6 0x5bef00d24c22 chromeos::UserSessionManager::FinalizePrepareProfile()
#7 0x5bef00d248ae chromeos::UserSessionManager::PrepareTpmDeviceAndFinalizeProfile()
#8 0x5beeff4bb2d8 _ZN4base8internal7InvokerINS0_9BindStateIMN2ui14GbmSurfacelessEFvPNS4_12PendingFrameEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#9 0x5bef022596eb base::debug::TaskAnnotator::RunTask()
#10 0x5bef02197c56 base::MessageLoop::RunTask()
#11 0x5bef02198162 base::MessageLoop::DoWork()
#12 0x5bef022551c9 base::MessagePumpLibevent::Run()
#13 0x5bef02197621 base::MessageLoop::Run()
#14 0x5bef021c4a16 base::RunLoop::Run()
#15 0x5bef01d74b58 ChromeBrowserMainParts::MainMessageLoopRun()
#16 0x5beeffd553f4 content::BrowserMainLoop::RunMainMessageLoopParts()
#17 0x5beeffd583c3 content::BrowserMainRunnerImpl::Run()
#18 0x5beeffd5121d content::BrowserMain()
#19 0x5bef01d617df content::ContentMainRunnerImpl::Run()


CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1144591


 
Blocking: 869904
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90ed3e55ebf1db93db956c753f48d692e8f46c8b

commit 90ed3e55ebf1db93db956c753f48d692e8f46c8b
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Aug 02 06:33:19 2018

IsRegistered check is now async

It uses a blocking PathExists call under the hood, so cannot be called
sync on the UI thread.

The IsRegistered check now runs when MaybeUpgradeCrostini runs, which is
at user session startup time

Bug:  870117 
Change-Id: I000887e2e76a0cbebfe7c12a37fe1e7d7911e22d
Reviewed-on: https://chromium-review.googlesource.com/1159936
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580091}
[modify] https://crrev.com/90ed3e55ebf1db93db956c753f48d692e8f46c8b/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/90ed3e55ebf1db93db956c753f48d692e8f46c8b/chrome/browser/chromeos/crostini/crostini_manager.h

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Yup, can't see the crash with TOT. Thanks!
Components: OS>Systems>Containers
Issue 870058 has been merged into this issue.

Sign in to add a comment