New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870113 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 876436



Sign in to add a comment

Add/use enterprise policies

Project Member Reported by khorimoto@chromium.org, Aug 2

Issue description

Policies should exist for:
(1) Better Together suite
(2) Smart Lock for unlocking
(3) Smart Lock for logging in (required by security review)
(4) Instant Tethering
(5) Android Messages

Accompanying these policies should be UI indicators in settings; see mocks: https://docs.google.com/presentation/d/1hloC0CmSxtuwHbVLbKSaq1HWpxyYt4EDTTxMuPu0wHc/edit#slide=id.g3e412ae573_14_0
 
UX has asked for a different treatment for enterprise and edu policies but I'm not clear on how to make the distinction in implementation in the code. jessejames said he would check with former colleagues at Cloud offline for some examples to help figure out handle edu and enterprise policies on a given pref separately.
Owner: khorimoto@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Blocking: 876436
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4372b34cc73165079047784431dd06b2b7a9a94c

commit 4372b34cc73165079047784431dd06b2b7a9a94c
Author: Kyle Horimoto <khorimoto@google.com>
Date: Fri Aug 24 19:22:49 2018

[CrOS MultiDevice] Refactor multi-device preferences.

This CL:
(1) Moves SmartLock's enabled and allowed preferences to the
    MultiDeviceSetup service (see go/cros-multidevice-prefs).
(2) Renames existing preferences so that they are named in the same
    format.
(3) Removes some of these preferences from the settings whitelist,
    since they are not edited in settings.

Note: This CL unblocks adding enterprise policies to
FeatureStateManager, which must have access to the preferences.

TBR=stevenjb@chromium.org

Bug:  870113 , 824568
Change-Id: Icffa4ed6b80095dd51e53b30a352289f584deba7
Reviewed-on: https://chromium-review.googlesource.com/1186033
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585932}
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.h
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chrome/browser/chromeos/device_sync/device_sync_client_factory.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/components/proximity_auth/proximity_auth_local_state_pref_manager.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/components/proximity_auth/proximity_auth_local_state_pref_manager_unittest.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/components/proximity_auth/proximity_auth_pref_names.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/components/proximity_auth/proximity_auth_pref_names.h
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/services/multidevice_setup/public/cpp/prefs.cc
[modify] https://crrev.com/4372b34cc73165079047784431dd06b2b7a9a94c/chromeos/services/multidevice_setup/public/cpp/prefs.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60c690a94250dd00a5728c3b13c9c62096795b74

commit 60c690a94250dd00a5728c3b13c9c62096795b74
Author: Kyle Horimoto <khorimoto@google.com>
Date: Sat Aug 25 00:34:37 2018

[CrOS MultiDevice] Add SMS Messages policy for managed users.

This policy allows administrators to prohibit users from utilizing the
upcoming feature which allows users to sync their SMS messages between
their laptops and phones.

Bug:  870113 , 824568
Change-Id: I12515b75c1f62d5c99bfb1a0adacddad80de0196
Reviewed-on: https://chromium-review.googlesource.com/1187730
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586079}
[modify] https://crrev.com/60c690a94250dd00a5728c3b13c9c62096795b74/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/60c690a94250dd00a5728c3b13c9c62096795b74/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/60c690a94250dd00a5728c3b13c9c62096795b74/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/60c690a94250dd00a5728c3b13c9c62096795b74/chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc
[modify] https://crrev.com/60c690a94250dd00a5728c3b13c9c62096795b74/chromeos/services/multidevice_setup/public/cpp/prefs.cc
[modify] https://crrev.com/60c690a94250dd00a5728c3b13c9c62096795b74/chromeos/services/multidevice_setup/public/cpp/prefs.h
[modify] https://crrev.com/60c690a94250dd00a5728c3b13c9c62096795b74/components/policy/resources/policy_templates.json
[modify] https://crrev.com/60c690a94250dd00a5728c3b13c9c62096795b74/tools/metrics/histograms/enums.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55af357da8782ec9399e219fcfd6bdc7f003cb5c

commit 55af357da8782ec9399e219fcfd6bdc7f003cb5c
Author: Kyle Horimoto <khorimoto@google.com>
Date: Sat Aug 25 01:37:47 2018

[CrOS MultiDevice] Update "feature states" computations.

This CL adds functionality for two edge cases:
(1) If all sub-features are prohibited by policy, the Better Together
    suite should also be prohibited.
(2) If a feature would have been enabled except that the suite as a
    whole is disabled, the feature is now in the
    kUnavailableSuiteDisabled state.

Note: This CL also renames the kDisabledByPolicy enum value to be
kProhibitedByPolicy instead for clarity.

Bug:  870113 , 824568
Change-Id: I11bdfcfbfd3313490599831606d31cb5ffa22983
Reviewed-on: https://chromium-review.googlesource.com/1187834
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586095}
[modify] https://crrev.com/55af357da8782ec9399e219fcfd6bdc7f003cb5c/chrome/browser/resources/settings/multidevice_page/multidevice_constants.js
[modify] https://crrev.com/55af357da8782ec9399e219fcfd6bdc7f003cb5c/chrome/browser/resources/settings/multidevice_page/multidevice_feature_behavior.js
[modify] https://crrev.com/55af357da8782ec9399e219fcfd6bdc7f003cb5c/chrome/test/data/webui/settings/multidevice_feature_toggle_tests.js
[modify] https://crrev.com/55af357da8782ec9399e219fcfd6bdc7f003cb5c/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/55af357da8782ec9399e219fcfd6bdc7f003cb5c/chromeos/services/multidevice_setup/feature_state_manager_impl.h
[modify] https://crrev.com/55af357da8782ec9399e219fcfd6bdc7f003cb5c/chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc
[modify] https://crrev.com/55af357da8782ec9399e219fcfd6bdc7f003cb5c/chromeos/services/multidevice_setup/public/mojom/multidevice_setup.mojom

Status: Fixed (was: Started)

Sign in to add a comment